starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab Switcher occasionally stops updating tab order properly #11300

New Issue
Closed
opened 2026-01-31 02:43:46 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:43:46 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Nov 7, 2020).

I do not know how to get terminal into this state, but I know that I cannot get it out of this state.

When I am using MRU switching, I occasionally get into a "switcher hole" where it puts the tabs in the wrong order with the current tab being selected as the next tab. Result: my switcher takes me to the current tab.

It seems to dislike the 0th tab

current tab (0) is the 2nd tab (1) and is selected by a basic switch operation

When I switch to inOrder switching, the list does not update from MRU order (!) during hot reload, so I can't test it out.

When I open the tab search it remains in MRU order.

A screenshot of my tabs in "in-order" order where the top tab is.. not correct

Adding tabs doesn't seem to break or fix this; they just get added.

This could be a conflict between @zadjii-msft and @Don-Vito's recent work in this area.
Something is unusual with the 0th tab.

Marking blocking because I managed to trivially run into it three times today.

Originally created by @DHowett on GitHub (Nov 7, 2020). I do not know how to get terminal into this state, but I know that I cannot get it _out_ of this state. When I am using MRU switching, I occasionally get into a "switcher hole" where it puts the tabs in the wrong order with the _current_ tab being selected as the _next_ tab. Result: my switcher takes me to the current tab. ![It seems to dislike the 0th tab](https://user-images.githubusercontent.com/189190/98428016-778cf400-2054-11eb-86a1-6b62a9d1bbe9.png) > current tab (0) is the 2nd tab (1) and is selected by a basic switch operation When I switch to `inOrder` switching, the list _does not update_ from MRU order (!) during hot reload, so I can't test it out. When I open the _tab search_ it remains in MRU order. ![A screenshot of my tabs in "in-order" order where the top tab is.. not correct](https://user-images.githubusercontent.com/189190/98427991-5c21e900-2054-11eb-976a-3c968be6c9dd.png) Adding tabs doesn't seem to break or fix this; they just get added. This could be a conflict between @zadjii-msft and @Don-Vito's recent work in this area. Something is unusual with the 0th tab. Marking blocking because I managed to trivially run into it three times today.
claunia commented 2026-01-31 02:43:49 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 7, 2020):

@DHowett - I am taking a look. I believe this is really somewhere in the integration you mentioned. Sorry.

@Don-Vito commented on GitHub (Nov 7, 2020): @DHowett - I am taking a look. I believe this is really somewhere in the integration you mentioned. Sorry.
claunia commented 2026-01-31 02:43:49 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 7, 2020):

I believe I found it: I introduced a bug where tabs in palette are also sorted by name. I guess performing tests where all tabs have the same name was a bad idea.

@Don-Vito commented on GitHub (Nov 7, 2020): I believe I found it: I introduced a bug where tabs in palette are also sorted by name. I guess performing tests where all tabs have the same name was a bad idea.
claunia commented 2026-01-31 02:43:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 7, 2020):

No need to apologize! These things happen all the time 😄

@DHowett commented on GitHub (Nov 7, 2020): No need to apologize! These things happen all the time :smile:
claunia commented 2026-01-31 02:43:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 7, 2020):

(I've introduced more regressions than I'm entitled to! I personally broke defaultProfile for two whole releases before we realized it. That was a fun one!)

@DHowett commented on GitHub (Nov 7, 2020): (I've introduced more regressions than I'm entitled to! I personally broke `defaultProfile` for two whole releases before we realized it. That was a fun one!)
claunia commented 2026-01-31 02:43:50 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 7, 2020):

Mine was very basic.. 😿 I added a UT for it, and I would like to add much more tests. But my main gap / concern is that adding more tests will result in even more CI instability. There is a lot of async logic when testing UI, I've seen some attempts to handle this with Sleeps, but this sounds not robust enough.

@Don-Vito commented on GitHub (Nov 7, 2020): Mine was very basic.. 😿 I added a UT for it, and I would like to add much more tests. But my main gap / concern is that adding more tests will result in even more CI instability. There is a lot of async logic when testing UI, I've seen some attempts to handle this with Sleeps, but this sounds not robust enough.
claunia commented 2026-01-31 02:43:50 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8188, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8188, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Blocking
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11300
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?