Command Palette: page up/down "wrap" backwards when you're too close to the bottom of the list #11306

Closed
opened 2026-01-31 02:43:55 +00:00 by claunia · 7 comments
Owner

Originally created by @DHowett on GitHub (Nov 7, 2020).

We may need to clamp the index when moving down/up.

A video of me reproducing the issue.

/cc @Hegunumo

Originally created by @DHowett on GitHub (Nov 7, 2020). We may need to clamp the index when moving down/up. ![A video of me reproducing the issue.](https://user-images.githubusercontent.com/189190/98450751-23d1e780-20f4-11eb-9177-df73262b1a12.gif) /cc @Hegunumo
Author
Owner

@Don-Vito commented on GitHub (Nov 7, 2020):

@DHowett - I was sure it was a feature when it was released 😄

@Don-Vito commented on GitHub (Nov 7, 2020): @DHowett - I was sure it was a feature when it was released 😄
Author
Owner

@ghost commented on GitHub (Nov 8, 2020):

Sorry I didn’t notice that.

@ghost commented on GitHub (Nov 8, 2020): Sorry I didn’t notice that.
Author
Owner

@Don-Vito commented on GitHub (Nov 8, 2020):

@Hegunumo - please ignore my PR - it is quick and dirty. I will gladly abandon it if you plan to working on this in the future.

@Don-Vito commented on GitHub (Nov 8, 2020): @Hegunumo - please ignore my PR - it is quick and dirty. I will gladly abandon it if you plan to working on this in the future.
Author
Owner

@ghost commented on GitHub (Nov 8, 2020):

@Don-Vito - Oh it's fine. You don't need to abandon it 😊

@ghost commented on GitHub (Nov 8, 2020): @Don-Vito - Oh it's fine. You don't need to abandon it 😊
Author
Owner

@Don-Vito commented on GitHub (Nov 8, 2020):

@Don-Vito - Oh it's fine. You don't need to abandon it 😊

@Hegunumo - Then may I ask you to help reviewing it? 😊

@Don-Vito commented on GitHub (Nov 8, 2020): > > > @Don-Vito - Oh it's fine. You don't need to abandon it 😊 @Hegunumo - Then may I ask you to help reviewing it? :blush:
Author
Owner

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8190, which has now been successfully released as Windows Terminal v1.4.3141.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8190, which has now been successfully released as `Windows Terminal v1.4.3141.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.4.3141.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Author
Owner

@ghost commented on GitHub (Nov 11, 2020):

:tada:This issue was addressed in #8190, which has now been successfully released as Windows Terminal Preview v1.5.3142.0.🎉

Handy links:

@ghost commented on GitHub (Nov 11, 2020): :tada:This issue was addressed in #8190, which has now been successfully released as `Windows Terminal Preview v1.5.3142.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.3142.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11306