starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

"theme": "dark" has no effect in 1.4.2652.0 #11318

New Issue
Closed
opened 2026-01-31 02:44:24 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:44:24 +00:00
Owner
Copy Link

Originally created by @savchenko on GitHub (Nov 10, 2020).

Environment

Windows build number: 10.0.19041.0
Windows Terminal version (if applicable): v1.4.2652.0

Steps to reproduce

  1. Add "theme": "dark" to your settings.
  2. Ensure "App mode" is set to light "Light":
    image
  3. Launch Terminal

Expected behavior

Terminal has "dark" look, like this:
image

Actual behavior

Terminal disregards theme property:
image

Originally created by @savchenko on GitHub (Nov 10, 2020). # Environment ```none Windows build number: 10.0.19041.0 Windows Terminal version (if applicable): v1.4.2652.0 ``` # Steps to reproduce 1. Add `"theme": "dark"` to your settings. 2. Ensure "App mode" is set to light "Light": ![image](https://user-images.githubusercontent.com/300146/98670673-efa43400-234a-11eb-9591-17a73a65c1e1.png) 3. Launch Terminal # Expected behavior Terminal has "dark" look, like this: ![image](https://user-images.githubusercontent.com/300146/98670748-106c8980-234b-11eb-8fba-33b8de8ad854.png) # Actual behavior Terminal disregards `theme` property: ![image](https://user-images.githubusercontent.com/300146/98670808-2c702b00-234b-11eb-9d4c-1b3f21a2122c.png)
claunia added the Issue-QuestionNeeds-Tag-FixResolution-Answered labels 2026-01-31 02:44:24 +00:00
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 10, 2020):

Did you restart the Terminal after changing theme to dark? I think that's one of the few properties that doesn't hot-reload

@zadjii-msft commented on GitHub (Nov 10, 2020): Did you restart the Terminal after changing `theme` to `dark`? I think that's one of the few properties that doesn't hot-reload
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@savchenko commented on GitHub (Nov 10, 2020):

Did you restart the Terminal after changing theme to dark?

Yes.

@savchenko commented on GitHub (Nov 10, 2020): > Did you restart the Terminal after changing theme to dark? Yes.
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 10, 2020):

Well that's certainly weird. Could you share your entire settings.json file?

@zadjii-msft commented on GitHub (Nov 10, 2020): Well that's certainly weird. Could you share your entire `settings.json` file?
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@savchenko commented on GitHub (Nov 10, 2020):

@zadjii-msft , 442bdff131/roles/dotfiles/files/wt.json

@savchenko commented on GitHub (Nov 10, 2020): @zadjii-msft , https://github.com/stoptracking/playbook/blob/442bdff131ab5f9c07223cff4e48129f5d8d3023/roles/dotfiles/files/wt.json
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 10, 2020):

Move theme up above line 4. It's what we consider an "application" setting -- it doesn't apply to a profile, so it doesn't go in the profiles section.

@DHowett commented on GitHub (Nov 10, 2020): Move `theme` up above line 4. It's what we consider an "application" setting -- it doesn't apply to a profile, so it doesn't go in the profiles section.
claunia commented 2026-01-31 02:44:26 +00:00
Author
Owner
Copy Link

@savchenko commented on GitHub (Nov 11, 2020):

Move theme up above line 4.

Works, thank you.

@savchenko commented on GitHub (Nov 11, 2020): > Move theme up above line 4. Works, thank you.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Question Needs-Tag-Fix Resolution-Answered
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11318
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?