starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Default profiles appear even if removed from the config.json #11408

New Issue
Closed
opened 2026-01-31 02:46:49 +00:00 by claunia · 12 comments
claunia commented 2026-01-31 02:46:49 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Nov 14, 2020).

Description of the new feature/enhancement

When one of the default profiles (PowerShell, Command Prompt, Azure Cloud Shell) is deleted from the configuration file, it still appears in the Terminal. As it is not in the configuration file, it can no longer be edited.

It would be more intuitive if the profiles are either re-created in the config file, or they disappear from the new session dropdown in the terminal.
If they were to be removed from the terminal, it would make sense if a dynamic profile was added to the configuration file when a new shell is installed, so that the user would be able to configure or delete it.

Originally created by @ghost on GitHub (Nov 14, 2020). # Description of the new feature/enhancement When one of the default profiles (PowerShell, Command Prompt, Azure Cloud Shell) is deleted from the configuration file, it still appears in the Terminal. As it is not in the configuration file, it can no longer be edited. It would be more intuitive if the profiles are either re-created in the config file, or they disappear from the new session dropdown in the terminal. If they were to be removed from the terminal, it would make sense if a dynamic profile was added to the configuration file when a new shell is installed, so that the user would be able to configure or delete it.
claunia added the Resolution-Fix-CommittedArea-SettingsIssue-TaskProduct-Terminal labels 2026-01-31 02:46:49 +00:00
claunia commented 2026-01-31 02:46:50 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 14, 2020):

@dev-kittens - to "remove" auto-generated profile you need to mark it as "hidden"

You can find more details and explanations about this here: https://docs.microsoft.com/en-us/windows/terminal/dynamic-profiles

@Don-Vito commented on GitHub (Nov 14, 2020): @dev-kittens - to "remove" auto-generated profile you need to mark it as `"hidden"` You can find more details and explanations about this here: https://docs.microsoft.com/en-us/windows/terminal/dynamic-profiles
claunia commented 2026-01-31 02:46:51 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 14, 2020):

@Don-Vito Thank you for the link. I've added the unwanted profiles to disabledProfileSources in my config.

I'm not satisfied with this answer, though. It's quite unintuitive to have profiles appear even though they were deleted in the configuration file.
I would suggest for Windows Terminal to either re-add the items to the JSON file on start or to only generate dynamic profiles when creating a configuration or when a new shell is installed.

@ghost commented on GitHub (Nov 14, 2020): @Don-Vito Thank you for the link. I've added the unwanted profiles to `disabledProfileSources` in my config. I'm not satisfied with this answer, though. It's quite unintuitive to have profiles appear even though they were deleted in the configuration file. I would suggest for Windows Terminal to either re-add the items to the JSON file on start or to only generate dynamic profiles when creating a configuration or when a new shell is installed.
claunia commented 2026-01-31 02:46:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 14, 2020):

@dev-kittens - I am not from the team, but what you write makes sense, the behavior is not the most intuitive. Probably you should update the issue title and expected behavior. So once the team gets to it, they know that you are aware of current behavior but ask for an improvement.

@Don-Vito commented on GitHub (Nov 14, 2020): @dev-kittens - I am not from the team, but what you write makes sense, the behavior is not the most intuitive. Probably you should update the issue title and expected behavior. So once the team gets to it, they know that you are aware of current behavior but ask for an improvement.
claunia commented 2026-01-31 02:46:51 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 14, 2020):

Oh, sure. I've just done that.

@ghost commented on GitHub (Nov 14, 2020): Oh, sure. I've just done that.
claunia commented 2026-01-31 02:46:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 16, 2020):

Thanks for the feedback! We actually went throguh a pretty lengthy design discussion about this last year when we were implementing cascading settings and dynamic profiles the first time. If you really want to read more of our decision making process, you can refer to #1258 and #1321. While this wasn't the most intuitive feature I've ever shipped, this behavior had the least drawbacks.

I've added some additional docs over at https://github.com/MicrosoftDocs/terminal/pull/186, hopefully that should help mitigate the confusion a bit.

@zadjii-msft commented on GitHub (Nov 16, 2020): Thanks for the feedback! We actually went throguh a pretty lengthy design discussion about this last year when we were implementing cascading settings and dynamic profiles the first time. If you really want to read more of our decision making process, you can refer to #1258 and #1321. While this wasn't the _most_ intuitive feature I've ever shipped, this behavior had the least drawbacks. I've added some additional docs over at https://github.com/MicrosoftDocs/terminal/pull/186, hopefully that should help mitigate the confusion a bit.
claunia commented 2026-01-31 02:46:52 +00:00
Author
Owner
Copy Link

@markdall commented on GitHub (Jun 1, 2021):

So, in order to stop seeing a shell for something I don't have and don't use yet (Azure) I needed to add "disabledProfileSources": ["Windows.Terminal.Azure"], to settings.json. I honestly feel like just deleting it should have been sufficient, but I understand that it probably wasn't up to you.

@markdall commented on GitHub (Jun 1, 2021): So, in order to stop seeing a shell for something I don't have and don't use yet (Azure) I needed to add `"disabledProfileSources": ["Windows.Terminal.Azure"],` to settings.json. I honestly feel like just deleting it should have been sufficient, but I understand that it probably wasn't up to you.
claunia commented 2026-01-31 02:46:52 +00:00
Author
Owner
Copy Link

@DaveEM commented on GitHub (Jul 19, 2021):

@Don-Vito / @zadjii-msft - I'm just another Windows Terminal user here, but here are a few thoughts:

  1. Can the Settings UI indicate when a profile is dynamic and provide a one-click option to delete it and do whatever is needed to keep it from showing up again?

  2. For people editing the JSON directly, it seems like a comment for dynamically generated profiles saying how to keep it from getting re-created is needed at a minimum. Even better, have a setting per dynamic profile to disable the profile (hiding it leaves it in the settings UI). On a related note, can multiple dynamic profiles come from one profile source? If so, disabling at the per-profile level seems like a better option than disabling the whole profile source.

Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion.

@DaveEM commented on GitHub (Jul 19, 2021): @Don-Vito / @zadjii-msft - I'm just another Windows Terminal user here, but here are a few thoughts: 1. Can the Settings UI indicate when a profile is dynamic and provide a one-click option to delete it and do whatever is needed to keep it from showing up again? 2. For people editing the JSON directly, it seems like a comment for dynamically generated profiles saying how to keep it from getting re-created is needed at a minimum. Even better, have a setting per dynamic profile to disable the profile (hiding it leaves it in the settings UI). On a related note, can multiple dynamic profiles come from one profile source? If so, disabling at the per-profile level seems like a better option than disabling the whole profile source. Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion.
claunia commented 2026-01-31 02:46:52 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jul 19, 2021):

(1 A) IIRC, the "delete profile" button on a profile in the SUI should hide dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this

(1 B) RE:

Can the Settings UI indicate when a profile is dynamic

I thought we were going to be adding that text to the SUI at some point, but clearly we forgot to do that.

Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion.

That's definitely unexpected. When the settings UI loads up the settings, it actually just uses the contents of the file, so perhaps it's possible that your editor had the file open and didn't notice that the file contents changed out from underneath it?

@zadjii-msft commented on GitHub (Jul 19, 2021): (1 A) IIRC, the "delete profile" button on a profile in the SUI should _hide_ dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this (1 B) RE: > Can the Settings UI indicate when a profile is dynamic I thought we were going to be adding that text to the SUI at some point, but clearly we forgot to do that. > Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion. That's definitely unexpected. When the settings UI loads up the settings, it actually just uses the contents of the file, so perhaps it's possible that your editor had the file open and didn't notice that the file contents changed out from underneath it?
claunia commented 2026-01-31 02:46:52 +00:00
Author
Owner
Copy Link

@DaveEM commented on GitHub (Jul 20, 2021):

(1 A) IIRC, the "delete profile" button on a profile in the SUI should hide dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this

The problems in this case are:
a. The Delete Profile button for the Windows PowerShell profile is greyed out. I added a comment to #10547 about this since that issue is currently closed as a dupe of the work to remember which dynamic profiles have been deleted but won't be fully resolved unless the block on deleting the profile is removed.

b. Hiding the profile doesn't remove it from the Settings menu. If I delete a profile I expect it to act like it's fully deleted - at least in the UI.

(1 B) RE:

Can the Settings UI indicate when a profile is dynamic

I thought we were going to be adding that text to the SUI at some point, but clearly we forgot to do that.

Thanks for getting an issue opened for this!

Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion.

That's definitely unexpected. When the settings UI loads up the settings, it actually just uses the contents of the file, so perhaps it's possible that your editor had the file open and didn't notice that the file contents changed out from underneath it?

This definitely repros:

  1. Run Windows Terminal on Windows 10 19043.1147.
  2. Go to Settings -> Open JSON file
  3. Remove the "Windows PowerShell" profile from the settings JSON.
  4. Close Windows Terminal.
  5. Close the editor.
  6. Run Windows Terminal again.
  7. Go to Settings (notice that Windows PowerShell is still there still) -> Open JSON file
  8. See that the "Windows PowerShell" profile has not been restored.
  9. For extra bonus points, go back to Windows Terminal, click the Save to save Settings, and then see that an empty profile entry has been added to the profile list (i.e. "{}")
@DaveEM commented on GitHub (Jul 20, 2021): > (1 A) IIRC, the "delete profile" button on a profile in the SUI should _hide_ dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this The problems in this case are: a. The Delete Profile button for the Windows PowerShell profile is greyed out. I added a comment to #10547 about this since that issue is currently closed as a dupe of the work to remember which dynamic profiles have been deleted but won't be fully resolved unless the block on deleting the profile is removed. b. Hiding the profile doesn't remove it from the Settings menu. If I delete a profile I expect it to act like it's fully deleted - at least in the UI. > (1 B) RE: > > > Can the Settings UI indicate when a profile is dynamic > > I thought we were going to be adding that text to the SUI at some point, but clearly we forgot to do that. Thanks for getting an issue opened for this! > > > Also, I ran into the same issue as @spiralw where I deleted the profile from the config file and found it odd that the deleted profile was restored in the UI but wasn't in the config file. The suggested solution of Windows Terminal re-adding the items to the JSON file on start seems reasonable to eliminate this confusion. > > That's definitely unexpected. When the settings UI loads up the settings, it actually just uses the contents of the file, so perhaps it's possible that your editor had the file open and didn't notice that the file contents changed out from underneath it? This definitely repros: 1. Run Windows Terminal on Windows 10 19043.1147. 2. Go to Settings -> Open JSON file 3. Remove the "Windows PowerShell" profile from the settings JSON. 4. Close Windows Terminal. 5. Close the editor. 6. Run Windows Terminal again. 7. Go to Settings (notice that Windows PowerShell is still there still) -> Open JSON file 8. See that the "Windows PowerShell" profile has not been restored. 9. For extra bonus points, go back to Windows Terminal, click the Save to save Settings, and then see that an empty profile entry has been added to the profile list (i.e. "{}")
claunia commented 2026-01-31 02:46:52 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 27, 2021):

(1 A) IIRC, the "delete profile" button on a profile in the SUI should hide dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this

In box and dynamic profiles disable the delete button and display a text explaining why it's disabled:

  • In box profiles (CMD and Windows PowerShell):
    This profile cannot be deleted because it is included by default.
  • Dynamic profiles (WSL distros, PowerShell Core)
    This profile cannot be deleted because it is automatically generated.

We still show hidden profiles in the SUI so hiding it won't fix the issue. We need #8324 so that we can know when the user deleted (via JSON or SUI) the profile and we make sure it doesn't show up again. Not great but we're getting there.

@DaveEM You're seeing the same bug here. The Windows PowerShell profile should basically be an empty profile IIRC. The problem shouldn't repro for non-dynamic non-in-box profiles (brand new profiles you created yourself).

@carlos-zamora commented on GitHub (Jul 27, 2021): > (1 A) IIRC, the "delete profile" button on a profile in the SUI should _hide_ dynamic profiles, instead of just removing them from the json. @carlos-zamora can correct me if I'm wrong on that. If it doesn't today, the works that's being done as a follow up to #10513, #8324 should take care of this In box and dynamic profiles disable the delete button and display a text explaining why it's disabled: - In box profiles (CMD and Windows PowerShell): ![This profile cannot be deleted because it is included by default.](https://user-images.githubusercontent.com/11050425/127069763-b65f44f1-cbde-4bd5-9ee7-97fd3b4b1749.png) - Dynamic profiles (WSL distros, PowerShell Core) ![This profile cannot be deleted because it is automatically generated.](https://user-images.githubusercontent.com/11050425/127069813-0f150fda-5749-4952-9ea0-fb683414122a.png) We still show hidden profiles in the SUI so hiding it won't fix the issue. We need #8324 so that we can know when the user deleted (via JSON or SUI) the profile and we make sure it doesn't show up again. Not great but we're getting there. @DaveEM You're seeing the same bug here. The Windows PowerShell profile should basically be an empty profile IIRC. The problem shouldn't repro for non-dynamic non-in-box profiles (brand _new_ profiles you created yourself).
claunia commented 2026-01-31 02:46:53 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Jul 27, 2021):

@zadjii-msft removing the Resolution-By-Design tag since we'll want to do this after #8324.

@carlos-zamora commented on GitHub (Jul 27, 2021): @zadjii-msft removing the Resolution-By-Design tag since we'll want to do this after #8324.
claunia commented 2026-01-31 02:46:53 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Aug 31, 2021):

:tada:This issue was addressed in #10910, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.🎉

Handy links:

@ghost commented on GitHub (Aug 31, 2021): :tada:This issue was addressed in #10910, which has now been successfully released as `Windows Terminal Preview v1.10.2383.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.10.2383.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11408
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?