Add a setting to configure display of auto detected links, normally and on hover #11444

Open
opened 2026-01-31 02:47:52 +00:00 by claunia · 5 comments
Owner

Originally created by @PankajBhojwani on GitHub (Nov 16, 2020).

Description of the new feature/enhancement

Allow the user to define how detected patterns should be displayed, when hovered and not.

See (see https://github.com/microsoft/terminal/pull/7691#issuecomment-727620804) and this

Wanted to make this an official issue where we can discuss the extent to which this should be implemented (should it just be limited to font style? or also font face? and what about font size? or other effects too)

Originally created by @PankajBhojwani on GitHub (Nov 16, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Allow the user to define how detected patterns should be displayed, when hovered and not. See (see https://github.com/microsoft/terminal/pull/7691#issuecomment-727620804) and [this](https://github.com/microsoft/terminal/pull/8148#issuecomment-721422578) Wanted to make this an official issue where we can discuss the extent to which this should be implemented (should it just be limited to font style? or also font face? and what about font size? or other effects too) <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). -->
claunia added the Issue-FeatureProduct-TerminalArea-TerminalControlArea-Schema labels 2026-01-31 02:47:52 +00:00
Author
Owner

@zadjii-msft commented on GitHub (Nov 16, 2020):

So, mixing and matching multiple fonts in the same TermControl might be Hard, so let's leave different font faces out of the question for now. I think different attributes seems reasonable, but how do we express that in the JSON?

@zadjii-msft commented on GitHub (Nov 16, 2020): So, mixing and matching multiple fonts in the same `TermControl` might be **H**ard, so let's leave _different font faces_ out of the question for now. I think different attributes seems reasonable, but how do we express that in the JSON?
Author
Owner

@PankajBhojwani commented on GitHub (Nov 17, 2020):

I think different attributes seems reasonable, but how do we express that in the JSON?

How does a map of key-value pairs sound? Allowed keys are foreground, background and any of the ExtendedAttributes values

@PankajBhojwani commented on GitHub (Nov 17, 2020): > I think different attributes seems reasonable, but how do we express that in the JSON? How does a map of key-value pairs sound? Allowed keys are `foreground`, `background` and any of the `ExtendedAttributes` values
Author
Owner

@zadjii-msft commented on GitHub (Nov 17, 2020):

wait so then it's

"foreground": "red", // a 16-color table value
"background": "#0044ff", // an RGB value
"underlined": true // ?
@zadjii-msft commented on GitHub (Nov 17, 2020): wait so then it's ```jsonc "foreground": "red", // a 16-color table value "background": "#0044ff", // an RGB value "underlined": true // ? ```
Author
Owner

@DHowett commented on GitHub (Nov 17, 2020):

We need to comport this with the configuration flags for specifying different fonts, suggested in ... some workitem that exists on this repo. I don't want to do this without doing that, and they should definitely look roughly the same in terms of user-facing options.

@DHowett commented on GitHub (Nov 17, 2020): We need to comport this with the configuration flags for specifying different fonts, suggested in ... some workitem that exists on this repo. I don't want to do this without doing that, and they should definitely look roughly the same in terms of user-facing options.
Author
Owner

@DHowett commented on GitHub (Nov 17, 2020):

That would be #1790.

@DHowett commented on GitHub (Nov 17, 2020): That would be #1790.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11444