starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Selected text should populate search box #11470

New Issue
Closed
opened 2026-01-31 02:48:33 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 02:48:33 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Nov 17, 2020).

Description of the new feature/enhancement

If there is an active selection in the terminal, opening the search box should be populated with the selected text.

Originally created by @carlos-zamora on GitHub (Nov 17, 2020). # Description of the new feature/enhancement If there is an active selection in the terminal, opening the search box should be populated with the selected text.
claunia commented 2026-01-31 02:48:34 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 17, 2020):

What if there's already a needle in the search box?

@DHowett commented on GitHub (Nov 17, 2020): What if there's already a needle in the search box?
claunia commented 2026-01-31 02:48:34 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 17, 2020):

I vote replace it with the new selection.

@zadjii-msft commented on GitHub (Nov 17, 2020): I vote replace it with the new selection.
claunia commented 2026-01-31 02:48:35 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 6, 2020):

This one is quite straightforward, but I am not sure what to do with multi-line selection.

Options are:

  1. Do not populate the search if multiple lines are selected (this is what VSCode does)
  2. Populate only with the first line
  3. Populate with the trimmed selection returned by RetrieveSelectedTextFromBuffer(true) (this is what notepad++ does)

I personally played with the 3rd option and liked it more.
WDYT?

@Don-Vito commented on GitHub (Dec 6, 2020): This one is quite straightforward, but I am not sure what to do with multi-line selection. Options are: 1. Do not populate the search if multiple lines are selected (this is what VSCode does) 2. Populate only with the first line 3. Populate with the trimmed selection returned by `RetrieveSelectedTextFromBuffer(true)` (this is what notepad++ does) I personally played with the 3rd option and liked it more. WDYT?
claunia commented 2026-01-31 02:48:35 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 6, 2020):

The funny stuff that multi-line selection works.. but I am not sure I can assume it works in all scenarios.
SelectText

However after some thoughts.. I suggest to start with what VS Code do.. populate only if single line selected.

@Don-Vito commented on GitHub (Dec 6, 2020): The funny stuff that multi-line selection works.. but I am not sure I can assume it works in all scenarios. ![SelectText](https://user-images.githubusercontent.com/4639110/101292873-d3e16000-381a-11eb-8264-7aee193268d5.gif) However after some thoughts.. I suggest to start with what VS Code do.. populate only if single line selected.
claunia commented 2026-01-31 02:48:35 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8521, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8521, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Interaction good first issue Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11470
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?