starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Make the Command Line Mode easier to access #11483

New Issue
Closed
opened 2026-01-31 02:48:52 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:48:52 +00:00
Owner
Copy Link

Originally created by @Don-Vito on GitHub (Nov 18, 2020).

Description of the new feature/enhancement

Today, to get to the command line mode I need to open the action mode and then to delete a ">" symbol, which is not very convenient.

While discussing this with @zadjii-msft few ideas were raised:

  1. Adding a separate binding for ToggleCommandPalette(mode=commandline)
  2. Having ToggleCommandPalette() switch between modes: closed->action->command line->closed.
  3. Both of them ☺️

Proposed technical implementation details (optional)

The most straightforward solution is to add an optional command palette mode to the ToggleCommandPalette, with two "launch modes": action and command line.

We will be able to implement option 2 only once https://github.com/microsoft/terminal/pull/8044 gets merged.

Originally created by @Don-Vito on GitHub (Nov 18, 2020). # Description of the new feature/enhancement Today, to get to the command line mode I need to open the action mode and then to delete a ">" symbol, which is not very convenient. While discussing this with @zadjii-msft few ideas were raised: 1. Adding a separate binding for ToggleCommandPalette(mode=commandline) 2. Having ToggleCommandPalette() switch between modes: closed->action->command line->closed. 3. Both of them ☺️ # Proposed technical implementation details (optional) The most straightforward solution is to add an optional command palette mode to the ToggleCommandPalette, with two "launch modes": action and command line. We will be able to implement option 2 only once https://github.com/microsoft/terminal/pull/8044 gets merged.
claunia commented 2026-01-31 02:48:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 18, 2020):

I'll be danged, I could have sworn I had already filed a task for this.

Ideas:

  • I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the toggleCommandPalette(mode=commandline) keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa)
  • Action and commandline mode definitely, tab search maybe? I suppose { action: toggleCommandPalette, mode: tabSearch } doesn't really make sense now does it.
@zadjii-msft commented on GitHub (Nov 18, 2020): I'll be danged, I could have sworn I had already filed a task for this. Ideas: * I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the `toggleCommandPalette(mode=commandline)` keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa) * Action and commandline mode definitely, tab search maybe? I suppose `{ action: toggleCommandPalette, mode: tabSearch }` doesn't _really_ make sense now does it.
claunia commented 2026-01-31 02:48:56 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 18, 2020):

I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

@DHowett commented on GitHub (Nov 18, 2020): I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users :smile:
claunia commented 2026-01-31 02:48:56 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 18, 2020):

I'll be danged, I could have sworn I had already filed a task for this.

Ideas:

* I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the `toggleCommandPalette(mode=commandline)` keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa)

* Action and commandline mode definitely, tab search maybe? I suppose `{ action: toggleCommandPalette, mode: tabSearch }` doesn't _really_ make sense now does it.

@zadjii-msft - I believe that:

  • toggleCommandPalette(mode=commandline) - should work from everywhere (even if the window is minimized and the PC is hibernated)
  • same for toggleCommandPalette(mode=commandline)
  • while toggleCommandPalette() with no mode specified should rotate through the modes (closed->action->command line).

WDYT?

@Don-Vito commented on GitHub (Nov 18, 2020): > > > I'll be danged, I could have sworn I had already filed a task for this. > > Ideas: > > * I don't really care that toggle with a mode might also close it. Maybe if you're in action mode, and you press the `toggleCommandPalette(mode=commandline)` keybinding, it'll pop you directly into commandline mode? (with #8044) (and vice versa) > > * Action and commandline mode definitely, tab search maybe? I suppose `{ action: toggleCommandPalette, mode: tabSearch }` doesn't _really_ make sense now does it. @zadjii-msft - I believe that: - toggleCommandPalette(mode=commandline) - should work from everywhere (even if the window is minimized and the PC is hibernated) - same for toggleCommandPalette(mode=commandline) - while toggleCommandPalette() with no mode specified should rotate through the modes (closed->action->command line). WDYT?
claunia commented 2026-01-31 02:48:57 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 18, 2020):

I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄

Yep.. that was a bad idea, especially since we already have a tabSeach binding...

@Don-Vito commented on GitHub (Nov 18, 2020): > > > I'd say that the command palette being the backend for tab search is an implementation detail, not something to expose to the users 😄 Yep.. that was a bad idea, especially since we already have a tabSeach binding...
claunia commented 2026-01-31 02:48:58 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

I'll be danged, I could have sworn I had already filed a task for this.

@zadjii-msft - I found it.. in the form of TODO 😆

 void TerminalPage::_HandleToggleCommandPalette(const IInspectable& /*sender*/,
                                                   const ActionEventArgs& args)
    {
        // TODO GH#6677: When we add support for commandline mode, first set the
        // mode that the command palette should be in, before making it visible.
        CommandPalette().EnableCommandPaletteMode();
        CommandPalette().Visibility(CommandPalette().Visibility() == Visibility::Visible ?
                                        Visibility::Collapsed :
                                        Visibility::Visible);
        args.Handled(true);
    }
@Don-Vito commented on GitHub (Nov 23, 2020): > > I'll be danged, I could have sworn I had already filed a task for this. > @zadjii-msft - I found it.. in the form of TODO 😆 ``` void TerminalPage::_HandleToggleCommandPalette(const IInspectable& /*sender*/, const ActionEventArgs& args) { // TODO GH#6677: When we add support for commandline mode, first set the // mode that the command palette should be in, before making it visible. CommandPalette().EnableCommandPaletteMode(); CommandPalette().Visibility(CommandPalette().Visibility() == Visibility::Visible ? Visibility::Collapsed : Visibility::Visible); args.Handled(true); } ```
claunia commented 2026-01-31 02:48:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8382, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8382, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-UserInterface Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11483
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?