starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Preview what actions will be run in commandline mode of the CmdPal #11513

New Issue
Closed
opened 2026-01-31 02:49:48 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 02:49:48 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Nov 20, 2020).

So we've already got an open work item tracking "display the parse error (if any) in commandline mode", #7284. What if, when we determine that the commandline is valid, we then display what commands are about to be executed, instead of the parse error?

So if you type in

nt ssh user@server.com

We'll parse that, and that won't generate an error message, it'll instead successfully turn into a newTab(commandline="ssh user@server.com") action. We'll then take that action, and call GenerateName on it, and we'll get "Open a new tab, commandline: ssh user@server.com". We'll then display that text to the user, as a preview of what they're about to run.

Originally created by @zadjii-msft on GitHub (Nov 20, 2020). So we've already got an open work item tracking "display the parse error (if any) in commandline mode", #7284. What if, when we determine that the commandline is valid, we then display what commands are about to be executed, instead of the parse error? So if you type in ``` nt ssh user@server.com ``` We'll parse that, and that won't generate an error message, it'll instead successfully turn into a `newTab(commandline="ssh user@server.com")` action. We'll then take that action, and call `GenerateName` on it, and we'll get "Open a new tab, commandline: ssh user@server.com". We'll then display _that_ text to the user, as a preview of what they're about to run.
claunia commented 2026-01-31 02:49:49 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 20, 2020):

@zadjii-msft - we need to consider the UX as I already put the history into the palette..

@Don-Vito commented on GitHub (Nov 20, 2020): @zadjii-msft - we need to consider the UX as I already put the history into the palette..
claunia commented 2026-01-31 02:49:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 20, 2020):

Yea, I've been thinking about that. The history is definitely better - but is there a sensible way of having both these things?

This is my terrible mockup:
image

(too lazy to bold results in the mockup)

So in this case, the user is typing a command, and they could select the nt -p Ubuntu ; ... command from the history, but until they do, we'd display the error (or results) after a short delay. I'm not sure how that really feels.

Or I guess when it's successful:
image

@zadjii-msft commented on GitHub (Nov 20, 2020): Yea, I've been thinking about that. The history is definitely better - but is there a sensible way of having both these things? This is my terrible mockup: ![image](https://user-images.githubusercontent.com/18356694/99807240-d5194a00-2b04-11eb-82c9-dbcda6ffd3db.png) (too lazy to bold results in the mockup) So in this case, the user is typing a command, and they _could_ select the `nt -p Ubuntu ; ...` command from the history, but until they do, we'd display the error (or results) after a short delay. I'm not sure how that really feels. Or I guess when it's successful: ![image](https://user-images.githubusercontent.com/18356694/99807678-77393200-2b05-11eb-9631-35ec2843fd0c.png)
claunia commented 2026-01-31 02:49:49 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 20, 2020):

@zadjii-msft - some off-topics

  1. how do you create the mockups - this is really cool!
  2. There is another aspect that I was thinking of is prediction from history.

Here how it goes:

  1. You start typing
  2. Then you go down to the history
  3. Once you navigate through the items there, the text in the search box receives a relevant suffix in a weaker font
  4. If you press tab key it makes the suffix to be a part of the search box

So you can:

  1. Write nt
  2. Go to nt -p Ubuntu; sp --tabColor #ff00ff
  3. Press tab
  4. Continue typing "; sp" to get nt -p Ubuntu; sp --tabColor #ff00ff ; sp
@Don-Vito commented on GitHub (Nov 20, 2020): @zadjii-msft - some off-topics 1. how do you create the mockups - this is really cool! 2. There is another aspect that I was thinking of is prediction from history. Here how it goes: 1. You start typing 2. Then you go down to the history 3. Once you navigate through the items there, the text in the search box receives a relevant suffix in a weaker font 4. If you press tab key it makes the suffix to be a part of the search box So you can: 1. Write nt 2. Go to nt -p Ubuntu; sp --tabColor #ff00ff 3. Press tab 4. Continue typing "; sp" to get nt -p Ubuntu; sp --tabColor #ff00ff ; sp
claunia commented 2026-01-31 02:49:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 20, 2020):

It's an app called XAML Studio, which is an absolute lifesaver.

I certainly like the "tab complete" functionality you've suggested here. I dunno how hard it'd be to actually implement, I'm not sure how hard it would be to have multiple styles of text in a single text box. Maybe there's another type of control that would allow for it, but my XAML-fu is not that strong.

@zadjii-msft commented on GitHub (Nov 20, 2020): It's an app called [XAML Studio](https://www.microsoft.com/en-us/p/xaml-studio/9ntls214tkmq?rtc=1), which is an absolute lifesaver. I certainly like the "tab complete" functionality you've suggested here. I dunno how hard it'd be to actually implement, I'm not sure how hard it would be to have multiple styles of text in a single text box. Maybe there's another type of control that would allow for it, but my XAML-fu is not that strong.
claunia commented 2026-01-31 02:49:50 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 20, 2020):

It's an app called XAML Studio, which is an absolute lifesaver.

I certainly like the "tab complete" functionality you've suggested here. I dunno how hard it'd be to actually implement, I'm not sure how hard it would be to have multiple styles of text in a single text box. Maybe there's another type of control that would allow for it, but my XAML-fu is not that strong.

Thanks! I will try to use it!
I guess we will need to overlay some transparent label or something like this.

@Don-Vito commented on GitHub (Nov 20, 2020): > > > It's an app called [XAML Studio](https://www.microsoft.com/en-us/p/xaml-studio/9ntls214tkmq?rtc=1), which is an absolute lifesaver. > > I certainly like the "tab complete" functionality you've suggested here. I dunno how hard it'd be to actually implement, I'm not sure how hard it would be to have multiple styles of text in a single text box. Maybe there's another type of control that would allow for it, but my XAML-fu is not that strong. Thanks! I will try to use it! I guess we will need to overlay some transparent label or something like this.
claunia commented 2026-01-31 02:49:50 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 7, 2020):

Hey. I played for an hour with this. I will open a PR for some initial step 😊

@Don-Vito commented on GitHub (Dec 7, 2020): Hey. I played for an hour with this. I will open a PR for some initial step :blush:
claunia commented 2026-01-31 02:49:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 7, 2020):

Y A Y

@zadjii-msft commented on GitHub (Dec 7, 2020): Y A Y
claunia commented 2026-01-31 02:49:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 7, 2020):

CmdPalPrediction

@Don-Vito commented on GitHub (Dec 7, 2020): ![CmdPalPrediction](https://user-images.githubusercontent.com/4639110/101365312-51a17c00-38ac-11eb-9a72-de367eb3a0cd.gif)
claunia commented 2026-01-31 02:49:51 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8515, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8515, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11513
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?