starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab title stop changing dynamically after rename textbox is dismissed #11540

New Issue
Closed
opened 2026-01-31 02:50:32 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:50:32 +00:00
Owner
Copy Link

Originally created by @mpela81 on GitHub (Nov 22, 2020).

Originally assigned to: @PankajBhojwani on GitHub.

Environment

Windows Terminal version (if applicable): current main branch

Steps to reproduce

  • Open WSL in a new tab (the tab title reflects the current working dir)
  • Double-click tab header to rename
  • Dismiss the rename text box (e.g. press Esc)
  • Change the current working directory in WSL

Expected behavior

The tab title reflects the new current working directory

Actual behavior

The tab title does not change, as if it was overridden by the rename operation

Maybe related to changes in #8227?

Originally created by @mpela81 on GitHub (Nov 22, 2020). Originally assigned to: @PankajBhojwani on GitHub. # Environment ```none Windows Terminal version (if applicable): current main branch ``` # Steps to reproduce - Open WSL in a new tab (the tab title reflects the current working dir) - Double-click tab header to rename - Dismiss the rename text box (e.g. press Esc) - Change the current working directory in WSL # Expected behavior The tab title reflects the new current working directory # Actual behavior The tab title does not change, as if it was overridden by the rename operation Maybe related to changes in #8227?
claunia commented 2026-01-31 02:50:34 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 22, 2020):

@mpela81 - I believe it is related.

  • Once you click escape you still call _CloseRenameBox
  • _CloseRenameBox calls _TitleChangeRequestedHandlers (although with the original value)
  • That invokes our Terminal Tab registration for TitleChangeRequested (in ctor)
  • This lambda calls TerminalTab::SetTabText that invokes UpdateTitle,
  • UpdateTitle calls SetTabText that sets _runtimeTabText,
  • _runtimeTabText is always preferred relatively to the value that TermControl holds

We definitely should not report update of title if rename was canceled.

@PankajBhojwani -

  • I really liked you change in general
  • Please let me know if you need assistance with this small defect (although this is a one-liner)
  • I've noticed that TabHeaderControl only reports title update, but never updates Title by its own.. so it kinda depends on someone else setting the title. Given it is now a standalone element, wouldn't we expect it to be more self-contained?
@Don-Vito commented on GitHub (Nov 22, 2020): @mpela81 - I believe it is related. * Once you click escape you still call _CloseRenameBox * _CloseRenameBox calls _TitleChangeRequestedHandlers (although with the original value) * That invokes our Terminal Tab registration for TitleChangeRequested (in ctor) * This lambda calls TerminalTab::SetTabText that invokes UpdateTitle, * UpdateTitle calls SetTabText that sets _runtimeTabText, * _runtimeTabText is always preferred relatively to the value that TermControl holds We definitely should not report update of title if rename was canceled. @PankajBhojwani - * I really liked you change in general * Please let me know if you need assistance with this small defect (although this is a one-liner) * I've noticed that TabHeaderControl only reports title update, but never updates Title by its own.. so it kinda depends on someone else setting the title. Given it is now a standalone element, wouldn't we expect it to be more self-contained?
claunia commented 2026-01-31 02:50:34 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 23, 2020):

/cc @PankajBhojwani for TabHeaderControl change 😄

@DHowett commented on GitHub (Nov 23, 2020): /cc @PankajBhojwani for TabHeaderControl change :smile:
claunia commented 2026-01-31 02:50:34 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 23, 2020):

@Don-Vito some discussion here about why it was not given control over the title: https://github.com/microsoft/terminal/pull/8227#discussion_r524407402

The whole comment chain is pretty good.

It seems very similar to TabView's TabCloseRequested: the view is not the datamodel, it should not be allowed to be the datamodel, it should only communicate desired state changes to its keepers. 😄

@DHowett commented on GitHub (Nov 23, 2020): @Don-Vito some discussion here about why it was not given control over the title: https://github.com/microsoft/terminal/pull/8227#discussion_r524407402 The whole comment chain is pretty good. It seems very similar to TabView's TabCloseRequested: the view is not the datamodel, it should not be allowed to be the datamodel, it should only communicate desired state changes to its keepers. :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11540
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?