starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Work with tabs rather than indices in Terminal Page #11553

New Issue
Closed
opened 2026-01-31 02:50:58 +00:00 by claunia · 8 comments
claunia commented 2026-01-31 02:50:58 +00:00
Owner
Copy Link

Originally created by @Don-Vito on GitHub (Nov 23, 2020).

Originally assigned to: @Don-Vito on GitHub.

Description of the new feature/enhancement

The current implementation of tab management in TerminalPage uses indices as a way of communication (we remove tabs by index, we update tabs by index, we drag tabs by index, even switch to tab command stored within tab points to an index).

This creates numerous theoretical races (that materialize from time to time, at least when I am testing).
In addition, I would also expect that we will work only with a single source of truth, rather than managing both _tabs and _tabView.TabItems manually

I guess there might be a reason for the current approach of working with indices rather than tabs and for managing two collections, but I wasn't able to find it in a documentation

Proposed technical implementation details (optional)

  • Bind _tabView.TabItems property to _tabs
  • Don't work with indices, if you must work with index resolve it to the tab as soon as possible
Originally created by @Don-Vito on GitHub (Nov 23, 2020). Originally assigned to: @Don-Vito on GitHub. # Description of the new feature/enhancement The current implementation of tab management in TerminalPage uses indices as a way of communication (we remove tabs by index, we update tabs by index, we drag tabs by index, even switch to tab command stored within tab points to an index). This creates numerous theoretical races (that materialize from time to time, at least when I am testing). In addition, I would also expect that we will work only with a single source of truth, rather than managing both _tabs and _tabView.TabItems manually I guess there might be a reason for the current approach of working with indices rather than tabs and for managing two collections, but I wasn't able to find it in a documentation # Proposed technical implementation details (optional) * Bind _tabView.TabItems property to _tabs * Don't work with indices, if you must work with index resolve it to the tab as soon as possible
claunia commented 2026-01-31 02:51:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 23, 2020):

Oh boy, does @leonMSFT have a story to share with you. He tried doing this earlier this year, but it ended up being a dead end. if I recall correctly, the way we're customizing the tabs prevented us from being able to bind them in XAML directly - something about adding the context menus, coloring, etc? I don't remember the details.

The original thread was over in #3922

@zadjii-msft commented on GitHub (Nov 23, 2020): Oh boy, does @leonMSFT have a story to share with you. He tried doing this earlier this year, but it ended up being a dead end. if I recall correctly, the way we're customizing the tabs prevented us from being able to bind them in XAML directly - something about adding the context menus, coloring, etc? I don't remember the details. The original thread was over in #3922
claunia commented 2026-01-31 02:51:00 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

@zadjii-msft - wow.. I see the threads.

I actually combined two independent questions together:

  1. Can we stop using index?
  2. Can we bind the the _tabs?
  • @leonMSFT - can you please share the story? 😊
  • I understand that we need sometimes to access TabViewItem, but why does it prevent us from binding the collection (OneWay) so we do all collection level modifications (add, remove, reorder) on _tabs.
@Don-Vito commented on GitHub (Nov 23, 2020): @zadjii-msft - wow.. I see the threads. I actually combined two independent questions together: 1. Can we stop using index? 2. Can we bind the the _tabs? * @leonMSFT - can you please share the story? :blush: * I understand that we need sometimes to access TabViewItem, but why does it prevent us from binding the collection (OneWay) so we do all collection level modifications (add, remove, reorder) on _tabs.
claunia commented 2026-01-31 02:51:00 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 23, 2020):

So, we have had issues binding the collection because it puts control of the TabViewItem out of our hands. We wanted to add a context menu (likely doable with binding) and customize some theme resources (likely less doable, but required because of tab color(1)), and the ListView recycling that TabView uses caused tabs to inherit colors from long-dead other tabs.

(1) we have a feature request on them to promote Background or Tint as a first-class offering, but as you might expect it is slow going 😄

@DHowett commented on GitHub (Nov 23, 2020): So, we have had issues binding the collection because it puts control of the TabViewItem out of our hands. We wanted to add a context menu (likely doable with binding) and customize some theme resources (likely less doable, but required because of tab color(1)), and the ListView recycling that TabView uses caused tabs to inherit colors from long-dead other tabs. (1) we have a feature request on them to promote Background or Tint as a first-class offering, but as you might expect it is slow going 😄
claunia commented 2026-01-31 02:51:01 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

So, we have had issues binding the collection because it puts control of the TabViewItem out of our hands. We wanted to add a context menu (likely doable with binding) and customize some theme resources (likely less doable, but required because of tab color(1)), and the ListView recycling that TabView uses caused tabs to inherit colors from long-dead other tabs.

(1) we have a feature request on them to promote Background or Tint as a first-class offering, but as you might expect it is slow going 😄

Yeah.. I see the PR: https://github.com/microsoft/microsoft-ui-xaml/pull/3216 (but it is idle for 2 months already).

What about the indices - I closed a bunch of tabs and dragged the remaining, found myself with 1 more tab than I expected.

@Don-Vito commented on GitHub (Nov 23, 2020): > > > So, we have had issues binding the collection because it puts control of the TabViewItem out of our hands. We wanted to add a context menu (likely doable with binding) and customize some theme resources (likely less doable, but required because of tab color(1)), and the ListView recycling that TabView uses caused tabs to inherit colors from long-dead other tabs. > > (1) we have a feature request on them to promote Background or Tint as a first-class offering, but as you might expect it is slow going 😄 Yeah.. I see the PR: https://github.com/microsoft/microsoft-ui-xaml/pull/3216 (but it is idle for 2 months already). What about the indices - I closed a bunch of tabs and dragged the remaining, found myself with 1 more tab than I expected.
claunia commented 2026-01-31 02:51:01 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 23, 2020):

I very much believe we should get off indices wherever possible, yes. 😄

@DHowett commented on GitHub (Nov 23, 2020): I very much believe we should get off indices wherever possible, yes. :smile:
claunia commented 2026-01-31 02:51:01 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 23, 2020):

Then I will try to take a look at it 😊

@Don-Vito commented on GitHub (Nov 23, 2020): Then I will try to take a look at it 😊
claunia commented 2026-01-31 02:51:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 24, 2020):

Re: your assignment - no pressure of course 😄 We'll all be on holiday soon, so it's going to slow down around here!

@DHowett commented on GitHub (Nov 24, 2020): Re: your assignment - no pressure of course :smile: We'll all be on holiday soon, so it's going to slow down around here!
claunia commented 2026-01-31 02:51:02 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 24, 2020):

Thanks again for finding these things and working to improve our code health/understandability/maintainability/features/pretty much everything!

@DHowett commented on GitHub (Nov 24, 2020): Thanks again for finding these things and working to improve our code health/understandability/maintainability/features/pretty much everything!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Help Wanted Issue-Task Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11553
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?