starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

disableAnimations not disabling all animations #11586

New Issue
Open
opened 2026-01-31 02:51:47 +00:00 by claunia · 10 comments
claunia commented 2026-01-31 02:51:47 +00:00
Owner
Copy Link

Originally created by @jack775544 on GitHub (Nov 26, 2020).

Environment

Windows build number: Microsoft Windows [Version 10.0.19042.630]
Windows Terminal version (if applicable): 1.5.3242.0, 1.4.3141.0

Any other software?
No

Steps to reproduce

Adding "disableAnimations": true, to my profile does not disable command palette animations or the animation that plays when opening the dropdown menu to open a new terminal.

I have found that globally disabling animations in windows will disable these animations.

Expected behavior

Those animations stop playing.

Actual behavior

The animations continue playing.

Originally created by @jack775544 on GitHub (Nov 26, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: Microsoft Windows [Version 10.0.19042.630] Windows Terminal version (if applicable): 1.5.3242.0, 1.4.3141.0 Any other software? No ``` # Steps to reproduce Adding `"disableAnimations": true,` to my profile does not disable command palette animations or the animation that plays when opening the dropdown menu to open a new terminal. I have found that globally disabling animations in windows will disable these animations. # Expected behavior Those animations stop playing. # Actual behavior The animations continue playing.
claunia added the Issue-BugPriority-3Product-TerminalArea-UserInterface labels 2026-01-31 02:51:47 +00:00
claunia commented 2026-01-31 02:51:48 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 26, 2020):

Just to confirm: you are putting disableAnimations into the profile? If so, it will not work there. It must be at the top level of the settings file outside of any profiles.

We released 1.5.3282 with a fix for disableAnimations, as well.

Only version 1.5+ even has animations, so I would be concerned if you are seeing them on 1.4.

@DHowett commented on GitHub (Nov 26, 2020): Just to confirm: you are putting `disableAnimations` into the _profile_? If so, it will not work there. It must be at the top level of the settings file outside of any profiles. We released 1.5.3282 with a fix for `disableAnimations`, as well. Only version 1.5+ even has animations, so I would be concerned if you are seeing them on 1.4.
claunia commented 2026-01-31 02:51:49 +00:00
Author
Owner
Copy Link

@jack775544 commented on GitHub (Nov 26, 2020):

Yep, placing it on the top level of the settings, my apologies on the wording. I am seeing pane animations being correctly disabled when opening a new pane however the command palette still retains them.

wtanimations

In that above gif you can see when I am typing and deleting words the animation plays to remove and add to the list. Disabling windows animations globally will prevent it from occurring however.

@jack775544 commented on GitHub (Nov 26, 2020): Yep, placing it on the top level of the settings, my apologies on the wording. I am seeing pane animations being correctly disabled when opening a new pane however the command palette still retains them. ![wtanimations](https://user-images.githubusercontent.com/8287765/100306592-803b6f00-2fef-11eb-96a4-dac5cdc17a67.gif) In that above gif you can see when I am typing and deleting words the animation plays to remove and add to the list. Disabling windows animations globally will prevent it from occurring however.
claunia commented 2026-01-31 02:51:49 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 26, 2020):

Oh! Wow, I forgot that there were animations in that component. It somewhat makes sense; we aren’t driving those and they are provided by the system. We should still be able to turn them off.
Good catch!

@DHowett commented on GitHub (Nov 26, 2020): Oh! Wow, I forgot that there were animations in that component. It somewhat makes sense; we aren’t driving those and they are provided by the system. We should still be able to turn them off. Good catch!
claunia commented 2026-01-31 02:51:49 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 30, 2020):

I'm not sure that an app is actually able to disable implicit animations on itself... Maybe @mdtauk might know?

@zadjii-msft commented on GitHub (Nov 30, 2020): I'm not sure that an app is actually able to disable implicit animations on itself... Maybe @mdtauk might know?
claunia commented 2026-01-31 02:51:50 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Nov 30, 2020):

As far as I know, the intention of these controls, are to respond to the system level setting to disable animation.

I'm not aware of a WinUI level API which can manage this. And to achieve it may require altering control templates to remove transitions and storyboards which drive these.

You should probably contact the WinUI team, and ask them what the best approach would be.

@mdtauk commented on GitHub (Nov 30, 2020): As far as I know, the intention of these controls, are to respond to the system level setting to disable animation. I'm not aware of a WinUI level API which can manage this. And to achieve it may require altering control templates to remove transitions and storyboards which drive these. You should probably contact the WinUI team, and ask them what the best approach would be.
claunia commented 2026-01-31 02:51:50 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 1, 2020):

That's what I was afraid of. The setting certainly implies that it'll disable all animations within the app, but we can't control all of them, only the ones for the controls we author ourselves.

Something like disablePaneAnimations would I guess make more sense. Let's entertain a hypothetical though, say we added an animation to the opening of the command palette. Then we'd need something like disableCommandPaletteAnimations, but that wouldn't disable all animations in the palette, just the opening one. Hmmmmmm

@zadjii-msft commented on GitHub (Dec 1, 2020): That's what I was afraid of. The setting certainly implies that it'll disable all animations within the app, but we can't control all of them, only the ones for the controls we author ourselves. Something like `disablePaneAnimations` would I guess make more sense. Let's entertain a hypothetical though, say we added an animation to the opening of the command palette. Then we'd need something like `disableCommandPaletteAnimations`, but that wouldn't disable all animations in the palette, just the opening one. Hmmmmmm
claunia commented 2026-01-31 02:51:50 +00:00
Author
Owner
Copy Link

@zakius commented on GitHub (Dec 17, 2020):

You should probably contact the WinUI team, and ask them what the best approach would be.

best approach would be not having animations enabled by default system-wide, but seeing the course they've taken that's unfortunately out of question, second best allowing components to be programmatically configured if they should use system-wide setting or force disable (no way to force enable to prevent annoying apps enforcing animations)

@zakius commented on GitHub (Dec 17, 2020): >You should probably contact the WinUI team, and ask them what the best approach would be. best approach would be not having animations enabled by default system-wide, but seeing the course they've taken that's unfortunately out of question, second best allowing components to be programmatically configured if they should use system-wide setting or force disable (no way to force enable to prevent annoying apps enforcing animations)
claunia commented 2026-01-31 02:51:51 +00:00
Author
Owner
Copy Link

@dmex commented on GitHub (Feb 26, 2021):

@zadjii-msft

we can't control all of them, only the ones for the controls we author ourselves.

You can override the ResourceDictionary property of those controls before adding them to XamlRoot. Specify the same ResourceKey but with values that disable the animations. This is how you were expected to disable animations and style the 'native' builtin controls by adding your own keys into App.Resources and for other cases with OverrideMetadata.

You can also do this globally for the application by QueryInterface for the global ResourceDictionary which exists in XamlIslands but it's not well documented.

@dmex commented on GitHub (Feb 26, 2021): @zadjii-msft > we can't control all of them, only the ones for the controls we author ourselves. You can override the ResourceDictionary property of those controls before adding them to XamlRoot. Specify the same ResourceKey but with values that disable the animations. This is how you were expected to disable animations and style the 'native' builtin controls by adding your own keys into App.Resources and for other cases with OverrideMetadata. You can also do this globally for the application by QueryInterface for the global ResourceDictionary which exists in XamlIslands but it's not well documented.
claunia commented 2026-01-31 02:51:51 +00:00
Author
Owner
Copy Link

@tommdq commented on GitHub (Jul 17, 2023):

I'm having the same problem when using "disableAnimations" in the settings.json file.
image
This is the settings file and i want to get rid of the animation when i open a new tab..

@tommdq commented on GitHub (Jul 17, 2023): I'm having the same problem when using "disableAnimations" in the settings.json file. ![image](https://github.com/microsoft/terminal/assets/80493479/f46b01d1-1003-48dc-8d4c-c19a3af5913a) This is the settings file and i want to get rid of the animation when i open a new tab..
claunia commented 2026-01-31 02:51:51 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Sep 12, 2023):

PowerToys recently merged in a possibly relevant PR: https://github.com/microsoft/PowerToys/pull/28128

We may be able to do what they did.

@carlos-zamora commented on GitHub (Sep 12, 2023): PowerToys recently merged in a possibly relevant PR: https://github.com/microsoft/PowerToys/pull/28128 We may be able to do what they did.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11586
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?