starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Teach CommandPalette to natively support tabs and command lines #11603

New Issue
Open
opened 2026-01-31 02:52:15 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 02:52:15 +00:00
Owner
Copy Link

Originally created by @Don-Vito on GitHub (Nov 27, 2020).

Originally assigned to: @Don-Vito on GitHub.

Description of the new feature/enhancement

Currently command palette has a single set of UIEelements that present different sets of Commands. This approach has a lot of gaps:

  1. To support tabs and command lines we need to convert them into Commands. This leads to extra complexity in maintaining model correctness (e.g., every time we reorder tabs we need to fix the relevant command as well).
  2. The same element reuse for different purposes makes CommandPalette complex (you need to reconfigure the control upon every mode switching). It also causes undesired re-computations.

Proposed technical implementation details (optional)

My plan to achieve it gradually is following:

  • #8420 - Introduce PaletteItem and derive from it to provide a native support for tabs and command lines (ActionPaletteItem / TabPaletteItem, CommandLinePaltteItem)
  • #8427 -Bind CommandPalette to Terminalpage tabs to prevent costly updates
  • Extract FilterablePaletteItemsList control
  • Introduce separate FilterablePaletteItemsList for each kind if palette items
  • Stretch goal: generalize FilterablePaletteItemsList into filterable list control
Originally created by @Don-Vito on GitHub (Nov 27, 2020). Originally assigned to: @Don-Vito on GitHub. # Description of the new feature/enhancement Currently command palette has a single set of UIEelements that present different sets of Commands. This approach has a lot of gaps: 1. To support tabs and command lines we need to convert them into Commands. This leads to extra complexity in maintaining model correctness (e.g., every time we reorder tabs we need to fix the relevant command as well). 2. The same element reuse for different purposes makes CommandPalette complex (you need to reconfigure the control upon every mode switching). It also causes undesired re-computations. # Proposed technical implementation details (optional) My plan to achieve it gradually is following: - [x] #8420 - Introduce `PaletteItem` and derive from it to provide a native support for tabs and command lines (`ActionPaletteItem` / `TabPaletteItem`, `CommandLinePaltteItem`) - [x] #8427 -Bind CommandPalette to Terminalpage tabs to prevent costly updates - [ ] Extract FilterablePaletteItemsList control - [ ] Introduce separate FilterablePaletteItemsList for each kind if palette items - [ ] Stretch goal: generalize FilterablePaletteItemsList into filterable list control
claunia added the Issue-FeatureProduct-TerminalArea-CodeHealthArea-CmdPal labels 2026-01-31 02:52:15 +00:00
claunia commented 2026-01-31 02:52:16 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 27, 2020):

@DHowett - can you please assign this one to me? 😊

@Don-Vito commented on GitHub (Nov 27, 2020): @DHowett - can you please assign this one to me? :blush:
claunia commented 2026-01-31 02:52:16 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Nov 27, 2020):

Happy to 😄 thanks

@DHowett commented on GitHub (Nov 27, 2020): Happy to 😄 thanks
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Area-CodeHealth Issue-Feature Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?