starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Tab close icon is too big #11609

New Issue
Closed
opened 2026-01-31 02:52:26 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 02:52:26 +00:00
Owner
Copy Link

Originally created by @eoussama on GitHub (Nov 27, 2020).

Environment

Windows build number: 10.0.19042.630
Windows Terminal version (if applicable): 1.4.3243.0

Any other software? No

Steps to reproduce

Right-click on an open tab, notice the close option

Expected behavior

The tab close icon should be the same size as the other icons

Actual behavior

The tab close icon is too large and distracting almost.

image

Originally created by @eoussama on GitHub (Nov 27, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.19042.630 Windows Terminal version (if applicable): 1.4.3243.0 Any other software? No ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> Right-click on an open tab, notice the close option # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> The tab close icon should be the same size as the other icons # Actual behavior <!-- What's actually happening? --> The tab close icon is too large and distracting almost. ![image](https://user-images.githubusercontent.com/22644543/100432334-c0572c00-3099-11eb-9aa0-d0670b0fa207.png)
claunia commented 2026-01-31 02:52:27 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 29, 2020):

I guess it does feel a bit bigger, even if it is the same size.

/cc @cinnamon-msft who might have some opinions on the matter

@zadjii-msft commented on GitHub (Nov 29, 2020): I guess it does feel a bit bigger, even if it is the same size. /cc @cinnamon-msft who might have some opinions on the matter
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Nov 29, 2020):

I think that icon is designed for a fontsize of 10 or 12 rather than 16

@mdtauk commented on GitHub (Nov 29, 2020): I think that icon is designed for a fontsize of 10 or 12 rather than 16
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 1, 2020):

I think the size discrepancy may be because that close icon is not typically used in this context, since it's a "chrome" icon. The cancel icon might be a better choice (\xE711), although that's possibly not semantically correct.

And on a similar note, I would have expected the "Rename Tab" menu item to be using the standard rename icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me.

@j4james commented on GitHub (Dec 1, 2020): I think the size discrepancy may be because that _close_ icon is not typically used in this context, since it's a "chrome" icon. The _cancel_ icon might be a better choice (\xE711), although that's possibly not semantically correct. And on a similar note, I would have expected the "Rename Tab" menu item to be using the standard _rename_ icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me.
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 1, 2020):

Also, as a point of comparison, have a look at the icon used on the Exit menu in this example from the Windows UI docs.

https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml/images/keyboard-accelerators.png

That's more in line with what I would have expected for our Close Tab menu.

@j4james commented on GitHub (Dec 1, 2020): Also, as a point of comparison, have a look at the icon used on the _Exit_ menu in this example from the Windows UI docs. https://docs.microsoft.com/en-us/uwp/api/windows.ui.xaml/images/keyboard-accelerators.png That's more in line with what I would have expected for our _Close Tab_ menu.
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 1, 2020):

I would have expected the "Rename Tab" menu item to be using the standard rename icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me.

oh my god there's a rename icon

Yea it should be that one 🤦‍♂️

The cancel icon might be a better choice (\xE711),

Yea that does look like what we should be using. @Hegunumo wanna try that icon instead?

@zadjii-msft commented on GitHub (Dec 1, 2020): > I would have expected the "Rename Tab" menu item to be using the standard _rename_ icon (\xE8AC). Was there a reason for choosing the current icon? It also looks a little out of place to me. oh my god there's a rename icon Yea it should be that one 🤦‍♂️ > The _cancel_ icon might be a better choice (\xE711), Yea that does look like what we should be using. @Hegunumo wanna try that icon instead?
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@cinnamon-msft commented on GitHub (Dec 1, 2020):

Yeah I agree, that close icon is definitely too large. I am curious how the cancel icon will look, and I agree that the rename icon should be used.

@cinnamon-msft commented on GitHub (Dec 1, 2020): Yeah I agree, that close icon is definitely too large. I am curious how the _cancel_ icon will look, and I agree that the _rename_ icon should be used.
claunia commented 2026-01-31 02:52:28 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 1, 2020):

Here's what it looks like with the rename icon updated, as well as the cancel icon for the close menu.

image

And while we're discussing this code, it's also worth mentioning that many of these standard icons can be set using a SymbolIcon rather than a FontIcon. It's a little easier and more readable that way I think. For example:

Controls::SymbolIcon renameTabSymbol;
renameTabSymbol.Symbol(Controls::Symbol::Rename);

instead of

Controls::FontIcon renameTabSymbol;
renameTabSymbol.FontFamily(Media::FontFamily{ L"Segoe MDL2 Assets" });
renameTabSymbol.Glyph(L"\xE932"); // Label
@j4james commented on GitHub (Dec 1, 2020): Here's what it looks like with the _rename_ icon updated, as well as the _cancel_ icon for the close menu. ![image](https://user-images.githubusercontent.com/4181424/100789686-b5402b00-340e-11eb-9eab-d8ee767249e2.png) And while we're discussing this code, it's also worth mentioning that many of these standard icons can be set using a `SymbolIcon` rather than a `FontIcon`. It's a little easier and more readable that way I think. For example: ```cpp Controls::SymbolIcon renameTabSymbol; renameTabSymbol.Symbol(Controls::Symbol::Rename); ``` instead of ```cpp Controls::FontIcon renameTabSymbol; renameTabSymbol.FontFamily(Media::FontFamily{ L"Segoe MDL2 Assets" }); renameTabSymbol.Glyph(L"\xE932"); // Label ```
claunia commented 2026-01-31 02:52:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8424, which has now been successfully released as Windows Terminal v1.5.10271.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8424, which has now been successfully released as `Windows Terminal v1.5.10271.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.5.10271.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:52:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8424, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8424, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
claunia commented 2026-01-31 02:52:29 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 1, 2021):

The Settings context menu still uses the old icon.
closeicon2
Wouldn't it be better to have a single menu for all tabs?

@ghost commented on GitHub (Mar 1, 2021): The Settings context menu still uses the old icon. ![closeicon2](https://user-images.githubusercontent.com/78622729/109518910-63fa1300-7ab3-11eb-9379-58d761410ff2.png) Wouldn't it be better to have a single menu for all tabs?
claunia commented 2026-01-31 02:52:29 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Mar 1, 2021):

@gabrielconl good catch - surprised this was only fixed for Terminal tabs and not the TabBase

@zadjii-msft commented on GitHub (Mar 1, 2021): @gabrielconl good catch - surprised this was only fixed for Terminal tabs and not the TabBase
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11609
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?