starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

After renaming tab with a long string it crashes or a blackscreen occures #11616

New Issue
Closed
opened 2026-01-31 02:52:37 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 02:52:37 +00:00
Owner
Copy Link

Originally created by @ghost on GitHub (Nov 27, 2020).

Windows 10 19042.620
Windows Terminal 1.4.3243.0
Windows Terminal Preview 1.5.3242.0

Steps to reproduce

Rename the Tab. Paste a long string

Expected behavior

No crash
No Blackscreen

Actual behavior

Windows Terminal Preview 1.5.3242.0:
Crash and Blackscreen

Windows Terminal 1.4.3243.0:
Blackscreen

image

Originally created by @ghost on GitHub (Nov 27, 2020). Windows 10 19042.620 Windows Terminal 1.4.3243.0 Windows Terminal Preview 1.5.3242.0 # Steps to reproduce Rename the Tab. Paste a long string # Expected behavior No crash No Blackscreen # Actual behavior Windows Terminal Preview 1.5.3242.0: Crash and Blackscreen Windows Terminal 1.4.3243.0: Blackscreen ![image](https://user-images.githubusercontent.com/67190487/100484612-fb655980-30b1-11eb-9582-a0c34c085fe8.png)
claunia commented 2026-01-31 02:52:39 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 28, 2020):

@retfloww - after pasting the long title and getting to this weird screen, please try to hit Esc (alternatively, click outside of the terminal window so the Terminal window will loose focus, and then switch back to Terminal)

For me this fixes the screen in both in 1.4 in 1.5.
Though if you click the same title again, you will get the weird screen again.

What happens behind the scene is that there is a control for renaming, which is rendered incorrectly with long strings, but when it gets collapsed (via Esc or by loosing its focus) the weird UI is hidden.

@Don-Vito commented on GitHub (Nov 28, 2020): @retfloww - after pasting the long title and getting to this weird screen, please try to hit Esc (alternatively, click outside of the terminal window so the Terminal window will loose focus, and then switch back to Terminal) For me this fixes the screen in both in 1.4 in 1.5. Though if you click the same title again, you will get the weird screen again. What happens behind the scene is that there is a control for renaming, which is rendered incorrectly with long strings, but when it gets collapsed (via Esc or by loosing its focus) the weird UI is hidden.
claunia commented 2026-01-31 02:52:39 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 28, 2020):

Yes this actually works, thank you very much. Will this in any future be fixed?

@ghost commented on GitHub (Nov 28, 2020): Yes this actually works, thank you very much. Will this in any future be fixed?
claunia commented 2026-01-31 02:52:40 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 28, 2020):

@retfloww - I am neither an expert nor from the team, but from what I learned about this community - everything gets solved at some point (unless it is an external dependency) ☺️

I will take a look at this later on to see if something catches my eye.

@Don-Vito commented on GitHub (Nov 28, 2020): @retfloww - I am neither an expert nor from the team, but from what I learned about this community - everything gets solved at some point (unless it is an external dependency) ☺️ I will take a look at this later on to see if something catches my eye.
claunia commented 2026-01-31 02:52:40 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Nov 28, 2020):

@retfloww - BTW, wondering what should be the correct behavior: do we really want to allow such long name, or should we instead truncate it / fail with a message.

Asking this because if truncation is an option, this is a one liner fix

@Don-Vito commented on GitHub (Nov 28, 2020): @retfloww - BTW, wondering what should be the correct behavior: do we really want to allow such long name, or should we instead truncate it / fail with a message. Asking this because if truncation is an option, this is a one liner fix
claunia commented 2026-01-31 02:52:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Nov 28, 2020):

I would go for the second idea, I cannot imagine someone using a long tab name, there should be a cap for max. name lenght.
The Chrome browser handels renaming group tabs very well. I would like to see this same in the terminal.

@ghost commented on GitHub (Nov 28, 2020): I would go for the second idea, I cannot imagine someone using a long tab name, there should be a cap for max. name lenght. The Chrome browser handels renaming group tabs very well. I would like to see this same in the terminal.
claunia commented 2026-01-31 02:52:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 29, 2020):

Good job finding a really bizarre bug, and thanks @Don-Vito for hoping on a fix so quick!

@zadjii-msft commented on GitHub (Nov 29, 2020): Good job finding a really bizarre bug, and thanks @Don-Vito for hoping on a fix so quick!
claunia commented 2026-01-31 02:52:40 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8433, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8433, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11616
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?