starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

More conhost exceptions via SetConsoleScreenBufferSize #11645

New Issue
Closed
opened 2026-01-31 02:53:31 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 02:53:31 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Dec 1, 2020).

Environment

Windows build number: Version 10.0.18363.1198
Windows Terminal version (if applicable): Commit 62131720aa

Steps to reproduce

  1. Start a conhost cmd shell.
  2. Open the properties and make sure Wrap text output on resize is unchecked.
  3. Compile and run the program below.
#include <windows.h>
int main()
{
	HANDLE h = GetStdHandle(STD_OUTPUT_HANDLE);
	COORD coord;
	coord.X = 160;
	coord.Y = 100;
	SetConsoleScreenBufferSize(h, coord);
	SMALL_RECT r = { 80, 75, 159, 99 };
	SetConsoleWindowInfo(h, TRUE, &r);
	SetConsoleCursorPosition(h, { 159, 99 });
	coord.X = 80;
	SetConsoleScreenBufferSize(h, coord);
	return 0;
}

Expected behavior

The conhost instance shouldn't crash and there shouldn't be any exceptions logged in the debug output.

Actual behavior

On my current version of Windows the conhost instance crashes. On the latest version of OpenConsole the exception is caught, so it at least doesn't crash, but you can see the error being logged in the debug output.

This is essentially the same bug as #1976, only the overflow is horizontal rather than vertical. It should have been fixed by PR #8309, but I managed to screw that up. I mistakenly thought the Viewport::EndExclusive method returned the bottom right extent of the viewport, but it's actually returning { Left(), BottomExclusive() }, so the overflow calculation doesn't detect a horizontal overflow. See here:

d09fdd61cb/src/host/getset.cpp (L530-L531)

and here:

ae550e0969/src/types/viewport.cpp (L148-L151)
The fix is easy enough. I'd probably just add something like an ExclusiveExtent method to the Viewport class that returns the range I was actually excepting to get from Viewport::EndExclusive. Does that seem reasonable?

Originally created by @j4james on GitHub (Dec 1, 2020). # Environment Windows build number: Version 10.0.18363.1198 Windows Terminal version (if applicable): Commit 62131720aa7a95df7ed397801c373d4eab0fd3d6 # Steps to reproduce 1. Start a conhost cmd shell. 2. Open the properties and make sure _Wrap text output on resize_ is unchecked. 3. Compile and run the program below. ```c #include <windows.h> int main() { HANDLE h = GetStdHandle(STD_OUTPUT_HANDLE); COORD coord; coord.X = 160; coord.Y = 100; SetConsoleScreenBufferSize(h, coord); SMALL_RECT r = { 80, 75, 159, 99 }; SetConsoleWindowInfo(h, TRUE, &r); SetConsoleCursorPosition(h, { 159, 99 }); coord.X = 80; SetConsoleScreenBufferSize(h, coord); return 0; } ``` # Expected behavior The conhost instance shouldn't crash and there shouldn't be any exceptions logged in the debug output. # Actual behavior On my current version of Windows the conhost instance crashes. On the latest version of OpenConsole the exception is caught, so it at least doesn't crash, but you can see the error being logged in the debug output. This is essentially the same bug as #1976, only the overflow is horizontal rather than vertical. It should have been fixed by PR #8309, but I managed to screw that up. I mistakenly thought the `Viewport::EndExclusive` method returned the bottom right extent of the viewport, but it's actually returning `{ Left(), BottomExclusive() }`, so the overflow calculation doesn't detect a horizontal overflow. See here: https://github.com/microsoft/terminal/blob/d09fdd61cbb11b7ef2ccdd4820349ffe898ad583/src/host/getset.cpp#L530-L531 and here: https://github.com/microsoft/terminal/blob/ae550e0969595f062b15c2ff5cc33d4afe8ebc3f/src/types/viewport.cpp#L148-L151 The fix is easy enough. I'd probably just add something like an `ExclusiveExtent` method to the `Viewport` class that returns the range I was actually excepting to get from `Viewport::EndExclusive`. Does that seem reasonable?
claunia commented 2026-01-31 02:53:32 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 2, 2020):

Yea that seems sensible to me. Thanks for investigating and putting the fix together!

@zadjii-msft commented on GitHub (Dec 2, 2020): Yea that seems sensible to me. Thanks for investigating and putting the fix together!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Server Issue-Bug Product-Conhost Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?