starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Functional-Open dropdown]- User is not able to perform action using shortcuts defined for the dropdown menu items. #11658

New Issue
Closed
opened 2026-01-31 02:53:54 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:53:54 +00:00
Owner
Copy Link

Originally created by @Chandresh1007 on GitHub (Dec 2, 2020).

User Experience:
Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working for the dropdown menu items.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0

Repro Steps:

  1. Open Windows terminal app
  2. Press "Ctrl+shift+Space" key to open the dropdown control.
  3. Navigate to the Menu items.
  4. Now press shortcut key defined for menu item say "Ctrl+," (which is defined for settings menu item).
  5. Observe the issue.

Actual Result:
User is not able to perform action using shortcuts defined for the dropdown menu items.
Pressing shortcut key defined for menu items, nothing is getting activated.

Expected Result:
User should be able to perform action using shortcuts defined for the dropdown menu items.
Pressing shortcut key "Ctrl+," settings should get open.

Functional_dropdown_menu keys not working.zip

Originally created by @Chandresh1007 on GitHub (Dec 2, 2020). **User Experience:** Users who rely on screen reader/Keyboard will not be able to perform action efficiently if shortcuts are not working for the dropdown menu items. **Test Environment:** OS: Win 10 2004 Build (20262.1010) App: Windows Terminal App version: 1.4.3243.0 **Repro Steps:** 1. Open Windows terminal app 2. Press "Ctrl+shift+Space" key to open the dropdown control. 3. Navigate to the Menu items. 4. Now press shortcut key defined for menu item say "Ctrl+," (which is defined for settings menu item). 5. Observe the issue. **Actual Result:** User is not able to perform action using shortcuts defined for the dropdown menu items. Pressing shortcut key defined for menu items, nothing is getting activated. **Expected Result:** User should be able to perform action using shortcuts defined for the dropdown menu items. Pressing shortcut key "Ctrl+," settings should get open. [Functional_dropdown_menu keys not working.zip](https://github.com/microsoft/terminal/files/5629395/Functional_dropdown_menu.keys.not.working.zip)
claunia commented 2026-01-31 02:53:56 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 2, 2020):

Yep, that makes sense. This is a variant of #6679, but with the new tab dropdown, instead of the command palette.

@zadjii-msft commented on GitHub (Dec 2, 2020): Yep, that makes sense. This is a variant of #6679, but with the new tab dropdown, instead of the command palette.
claunia commented 2026-01-31 02:53:56 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Dec 27, 2020):

Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English:

  1. Start Notepad.
  2. Press Ctrl+Shift+S. The "Save As" dialog box opens.
  3. Press Esc. The "Save As" dialog box closes.
  4. Press Alt+F. The "File" menu opens.
  5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open.
  6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open.
@KalleOlaviNiemitalo commented on GitHub (Dec 27, 2020): Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English: 1. Start Notepad. 2. Press Ctrl+Shift+S. The "Save As" dialog box opens. 3. Press Esc. The "Save As" dialog box closes. 4. Press Alt+F. The "File" menu opens. 5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open. 6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open.
claunia commented 2026-01-31 02:53:57 +00:00
Author
Owner
Copy Link

@akashk077 commented on GitHub (Dec 28, 2020):

Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English:

  1. Start Notepad.
  2. Press Ctrl+Shift+S. The "Save As" dialog box opens.
  3. Press Esc. The "Save As" dialog box closes.
  4. Press Alt+F. The "File" menu opens.
  5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open.
  6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open.

@KalleOlaviNiemitalo
I completely agree with your point.
If we are inside the menu and we'll use the shortcut key, it won't work.
@Chandresh1007
If the behaviour is just like @KalleOlaviNiemitalo then it is not an issue.
Else, please describe.

@akashk077 commented on GitHub (Dec 28, 2020): > Do users really expect keyboard shortcuts to work while a menu is open? Compare to Notepad in U.S. English: > > 1. Start Notepad. > 2. Press Ctrl+Shift+S. The "Save As" dialog box opens. > 3. Press Esc. The "Save As" dialog box closes. > 4. Press Alt+F. The "File" menu opens. > 5. Press the Down arrow key four times. The "Save As… Ctrl+Shift+S" menu item becomes highlighted and the menu remains open. > 6. Press Ctrl+Shift+S. The "Save As" dialog box does not open. Instead, there is a sound, and the menu remains open. @KalleOlaviNiemitalo I completely agree with your point. If we are inside the menu and we'll use the shortcut key, it won't work. @Chandresh1007 If the behaviour is just like @KalleOlaviNiemitalo then it is not an issue. Else, please describe.
claunia commented 2026-01-31 02:53:57 +00:00
Author
Owner
Copy Link

@Chandresh1007 commented on GitHub (Dec 28, 2020):

As the shortcut keys are working when the menu is closed. Hence, closing this bug.

@Chandresh1007 commented on GitHub (Dec 28, 2020): As the shortcut keys are working when the menu is closed. Hence, closing this bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-0 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11658
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?