starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Modifying profiles.json causes multiple settings reloads #1167

New Issue
Closed
opened 2026-01-30 22:17:58 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:17:58 +00:00
Owner
Copy Link

Originally created by @d-bingham on GitHub (May 16, 2019).

Originally assigned to: @zadjii-msft on GitHub.

This bug-tracker is monitored by Windows Console development team and other technical types. We like detail!

If you have a feature request, please post to the UserVoice.

Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue.

Please use this form and describe your issue, concisely but precisely, with as much detail as possible

  • Your Windows build number: Microsoft Windows [Version 10.0.18362.86]

  • What you're doing and what's happening: When editing profiles.json, saving a modified version of the file generates multiple app-wide settings refreshes.

  • What's wrong / what should be happening instead: Modifying the settings file should only generate one app-wide settings update

Originally created by @d-bingham on GitHub (May 16, 2019). Originally assigned to: @zadjii-msft on GitHub. This bug-tracker is monitored by Windows Console development team and other technical types. **We like detail!** If you have a feature request, please post to [the UserVoice](https://wpdev.uservoice.com/forums/266908). > **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. Please use this form and describe your issue, concisely but precisely, with as much detail as possible * Your Windows build number: Microsoft Windows [Version 10.0.18362.86] * What you're doing and what's happening: When editing profiles.json, saving a _modified_ version of the file generates multiple app-wide settings refreshes. * What's wrong / what should be happening instead: Modifying the settings file should only generate one app-wide settings update
claunia added the Resolution-Fix-CommittedArea-SettingsIssue-BugProduct-Terminal labels 2026-01-30 22:17:58 +00:00
claunia commented 2026-01-30 22:17:59 +00:00
Author
Owner
Copy Link

@fearthecowboy commented on GitHub (May 16, 2019):

It looks like in TerminalApp::CascadiaSettings it has

  static std::unique_ptr<CascadiaSettings> LoadAll(const bool saveOnLoad = true);

saveOnLoad is true and it's only ever called with the default value.

I'd think that this should not save by default - if it loaded, it should be fine to load later, there's little gained by saving it (which also reformats the json. GRRRRR 😠 ).

@fearthecowboy commented on GitHub (May 16, 2019): It looks like in `TerminalApp::CascadiaSettings` it has ``` c++ static std::unique_ptr<CascadiaSettings> LoadAll(const bool saveOnLoad = true); ``` `saveOnLoad` is `true` and it's only ever called with the default value. I'd think that this should not save by default - if it loaded, it should be fine to load later, there's little gained by saving it (which also reformats the json. GRRRRR 😠 ).
claunia commented 2026-01-30 22:17:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 16, 2019):

Yea I think I actually have a fix for this in #748 here

@zadjii-msft commented on GitHub (May 16, 2019): Yea I think I actually have a fix for this in #748 [here](https://github.com/microsoft/terminal/pull/748/files#diff-a011f61f234a66ac8dd94efe8e488244R408)
claunia commented 2026-01-30 22:17:59 +00:00
Author
Owner
Copy Link

@d-bingham commented on GitHub (May 16, 2019):

Yeah, the fix in #748 fixes the problem.

@d-bingham commented on GitHub (May 16, 2019): Yeah, the fix in #748 fixes the problem.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings Issue-Bug Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1167
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?