starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Screen Reader - Open and close New Tab]: Screen reader does not announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. #11671

New Issue
Closed
opened 2026-01-31 02:54:13 +00:00 by claunia · 11 comments
claunia commented 2026-01-31 02:54:13 +00:00
Owner
Copy Link

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020).

Originally assigned to: @carlos-zamora on GitHub.

User Experience:
If the correct information and relationships are not provided, it would be difficult for people with different disabilities as the information and relationships that are implied by visual or auditory formatting will not be preserved when the presentation format changes.
Having these structures and these relationships programmatically determined or available in text ensures that information important for comprehension will be perceivable to all.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0

Repro Steps:

  1. Open Windows terminal app.
  2. Launch Narrator.
  3. Press "Ctrl+Shift+T" to open multiple tabs.
  4. Now press "Ctrl+Tab" or "Ctrl+Shift+Tab" key to navigate between tabs.
  5. Observe the issue.

Actual Result:
Screen reader does not announce position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key.

Expected Result:
Screen reader should announce the position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key.
For e.g. If total 5 tabs are present and currently the focus is at 3rd tab then narrator should announce it as "3of 5".

Note: Same issue repro with NVDA.

Observation: In scan mode narrator announces position number.

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4%7D&cid=a7f80d30-34d6-4e03-af19-fa3c97a5bf31

MAS1.3.1_Position no does not get announced for tabs.zip

Tab item_code snippet

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020). Originally assigned to: @carlos-zamora on GitHub. **User Experience:** If the correct information and relationships are not provided, it would be difficult for people with different disabilities as the information and relationships that are implied by visual or auditory formatting will not be preserved when the presentation format changes. Having these structures and these relationships programmatically determined or available in text ensures that information important for comprehension will be perceivable to all. **Test Environment:** OS: Win 10 2004 Build (20262.1010) App: Windows Terminal App version: 1.4.3243.0 **Repro Steps:** 1. Open Windows terminal app. 2. Launch Narrator. 3. Press "Ctrl+Shift+T" to open multiple tabs. 4. Now press "Ctrl+Tab" or "Ctrl+Shift+Tab" key to navigate between tabs. 5. Observe the issue. **Actual Result:** Screen reader **does not announce position number for the tabs** navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. **Expected Result:** Screen reader should announce the position number for the tabs navigating via "Ctrl+Tab" or "Ctrl+Shift+Tab" key. For e.g. **If total 5 tabs are present and currently the focus is at 3rd tab then narrator should announce it as "3of 5".** **Note:** Same issue repro with NVDA. **Observation:** In scan mode narrator announces position number. **MAS Reference:** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4%7D&cid=a7f80d30-34d6-4e03-af19-fa3c97a5bf31 [MAS1.3.1_Position no does not get announced for tabs.zip](https://github.com/microsoft/terminal/files/5635199/MAS1.3.1_Position.no.does.not.get.announced.for.tabs.zip) ![Tab item_code snippet](https://user-images.githubusercontent.com/53220700/100993542-8b584700-357b-11eb-8904-555315469b07.png)
claunia commented 2026-01-31 02:54:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

I'm guessing that this is the same thing as #8464, where we provide a little bit of metadata in the message. /cc @carlos-zamora

@zadjii-msft commented on GitHub (Dec 3, 2020): I'm guessing that this is the same thing as #8464, where we provide a little bit of metadata in the message. /cc @carlos-zamora
claunia commented 2026-01-31 02:54:16 +00:00
Author
Owner
Copy Link

@akash07k commented on GitHub (Feb 23, 2021):

@zadjii-msft
Any update on this issue?

@akash07k commented on GitHub (Feb 23, 2021): @zadjii-msft Any update on this issue?
claunia commented 2026-01-31 02:54:16 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 23, 2021):

@akash07k @carlos-zamora is the one who's currently working on our accessibility bugs.

Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464

@zadjii-msft commented on GitHub (Feb 23, 2021): @akash07k @carlos-zamora is the one who's currently working on our accessibility bugs. Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464
claunia commented 2026-01-31 02:54:16 +00:00
Author
Owner
Copy Link

@akash07k commented on GitHub (Feb 23, 2021):

Thanks @zadjii-msft
@carlos-zamora I'd love to know the progress on this issue if possible. :-)

@akash07k @carlos-zamora is the one who's currently working on our accessibility bugs.

Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464

Ya, if WinUI team implements it then it will be fixed for many more apps too and it would be win-win for all.
I'd be investigating this issue in more detail tonight.

@akash07k commented on GitHub (Feb 23, 2021): Thanks @zadjii-msft @carlos-zamora I'd love to know the progress on this issue if possible. :-) > @akash07k @carlos-zamora is the one who's currently working on our accessibility bugs. > > Carlos, do browsers do this? If so, then I'm betting this is also something that the WinUI team should implement themselves, like #8464 Ya, if WinUI team implements it then it will be fixed for many more apps too and it would be win-win for all. I'd be investigating this issue in more detail tonight.
claunia commented 2026-01-31 02:54:17 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 23, 2021):

I have good news and bad news.
Good news:

  • tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI)

Bad news:

  • seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.
@carlos-zamora commented on GitHub (Feb 23, 2021): I have good news and bad news. Good news: - tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI) Bad news: - seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.
claunia commented 2026-01-31 02:54:17 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 23, 2021):

@Chandresh1007 since this is fixed now, could you close the bug? Thanks.

@carlos-zamora commented on GitHub (Feb 23, 2021): @Chandresh1007 since this is fixed now, could you close the bug? Thanks.
claunia commented 2026-01-31 02:54:17 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 23, 2021):

Er, I tried this in 1.7 and didn’t hear an announcement for the tab index. Maybe the tab switcher interferes?

@DHowett commented on GitHub (Feb 23, 2021): Er, I tried this in 1.7 and didn’t hear an announcement for the tab index. Maybe the tab switcher interferes?
claunia commented 2026-01-31 02:54:17 +00:00
Author
Owner
Copy Link

@akash07k commented on GitHub (Feb 24, 2021):

@carlos-zamora
Thanks for confirming,
Can you please let me know that where can I find that selfhosted build? is it publicly available or not?
And, please give the issue link for "tab names not being read" Would love to track it's progress.

I have good news and bad news.
Good news:

  • tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI)

Bad news:

  • seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.
@akash07k commented on GitHub (Feb 24, 2021): @carlos-zamora Thanks for confirming, Can you please let me know that where can I find that selfhosted build? is it publicly available or not? And, please give the issue link for "tab names not being read" Would love to track it's progress. > I have good news and bad news. > Good news: > > * tested this on v1.7.501.0 (preview selfhost) and v1.5.10411.0 (stable public release). It got fixed (probably by WinUI) > > Bad news: > > * seeing a regression on v1.7.501.0. Tab names are not being read out by the screen reader. Submitting a separate issue for that.
claunia commented 2026-01-31 02:54:17 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 24, 2021):

Apologies. I was in the process of writing a comment then got distracted with something else. The tab switcher actually "fixes" this functionality. However, when the tab switcher is not enabled, this bug occurs. So it's still valid, I think?

The default functionality setting includes the tab switcher though. That's the only reason I can think of disqualifying it, but that's not a good enough reason, I think.

@carlos-zamora commented on GitHub (Feb 24, 2021): Apologies. I was in the process of writing a comment then got distracted with something else. The tab switcher actually "fixes" this functionality. However, when the tab switcher is not enabled, this bug occurs. So it's still valid, I think? The default functionality setting includes the tab switcher though. That's the only reason I can think of disqualifying it, but that's not a good enough reason, I think.
claunia commented 2026-01-31 02:54:18 +00:00
Author
Owner
Copy Link

@Chandresh1007 commented on GitHub (Feb 25, 2021):

Issue is fixed. Now the screen reader is announcing the position number along with its name and state. Verified on following Test Environment:
OS: Win 10 2004 Build (21301.1010)
App: Windows Terminal
App version: 1.5.10411.0
Hence, closing the bug.

@Chandresh1007 commented on GitHub (Feb 25, 2021): Issue is fixed. Now the screen reader is announcing the position number along with its name and state. Verified on following Test Environment: OS: Win 10 2004 Build (21301.1010) App: Windows Terminal App version: 1.5.10411.0 Hence, closing the bug.
claunia commented 2026-01-31 02:54:18 +00:00
Author
Owner
Copy Link

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024):

Closing the bug as issue has been fixed.

@Priyanka-Chauhan123 commented on GitHub (Jan 9, 2024): Closing the bug as issue has been fixed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yTTValidated A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11671
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?