starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Screen Reader - Open and close New Tab]: Same name as "Close Tab" is defined for all the close button present at each tab. #11677

New Issue
Closed
opened 2026-01-31 02:54:25 +00:00 by claunia · 3 comments
claunia commented 2026-01-31 02:54:25 +00:00
Owner
Copy Link

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020).

Originally assigned to: @carlos-zamora on GitHub.

User Experience:
Users who rely on screen reader would be impacted and not able to get on which tab close button focus is present as same name "Close Tab" is defined for all the tabs close button.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0
Tool: Accessibility Insights for Windows

Repro Steps:

  1. Open Windows terminal app.
  2. Press "Ctrl+Shift+T" to open multiple tabs.
  3. Now check the name defined for close button of each tab using accessibility insight tool.
  4. Observe the issue.

Actual Result:
Same name as "Close Tab" is defined for all the close button present at each tab. So when screen reader focus navigates to any tab close button then narrator announces it as "Close tab button".

Expected Result:
Descriptive and unique name should be defined for each tab close button like "Close Tab 1".

MAS Reference:
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B248054a6-5e68-4771-9e1e-242fb5025730%7D&cid=e71aec14-4173-423e-aecb-2472bbc751e8

MAS4.1.2_Close tab button name should be descriptive.zip

MAS4 1 2_Close tab_AI code snippet

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020). Originally assigned to: @carlos-zamora on GitHub. **User Experience:** Users who rely on screen reader would be impacted and not able to get on which tab close button focus is present as same name "Close Tab" is defined for all the tabs close button. **Test Environment:** OS: Win 10 2004 Build (20262.1010) App: Windows Terminal App version: 1.4.3243.0 Tool: Accessibility Insights for Windows **Repro Steps:** 1. Open Windows terminal app. 2. Press "Ctrl+Shift+T" to open multiple tabs. 3. Now check the name defined for close button of each tab using accessibility insight tool. 4. Observe the issue. **Actual Result:** **Same name as "Close Tab" is defined for all the close button present at each tab**. So when screen reader focus navigates to any tab close button then narrator announces it as "Close tab button". **Expected Result:** **Descriptive and unique name** should be defined for each tab close button like **"Close Tab 1"**. **MAS Reference:** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7B248054a6-5e68-4771-9e1e-242fb5025730%7D&cid=e71aec14-4173-423e-aecb-2472bbc751e8 [MAS4.1.2_Close tab button name should be descriptive.zip](https://github.com/microsoft/terminal/files/5635316/MAS4.1.2_Close.tab.button.name.should.be.descriptive.zip) ![MAS4 1 2_Close tab_AI code snippet](https://user-images.githubusercontent.com/53220700/100995527-e9862980-357d-11eb-9d76-9488ba96afcd.png)
claunia commented 2026-01-31 02:54:28 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

Huh, can we even set the automation name of that button at runtime? IIRC it's defined in XAML. That one might actually be defined in the TabViewItem itself, I'm not sure we're customizing that at all. This might need to be filed upstream.

@zadjii-msft commented on GitHub (Dec 3, 2020): Huh, can we even set the automation name of that button at runtime? IIRC it's defined in XAML. That one might actually be defined in the `TabViewItem` itself, I'm not sure we're customizing that at all. This might need to be filed upstream.
claunia commented 2026-01-31 02:54:28 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 3, 2020):

image

This is true of Chromium as well. Why should Terminal be any different?

@DHowett commented on GitHub (Dec 3, 2020): ![image](https://user-images.githubusercontent.com/189190/101078272-cd24c580-355a-11eb-879e-8cc52dae5a80.png) This is true of Chromium as well. Why should Terminal be any different?
claunia commented 2026-01-31 02:54:28 +00:00
Author
Owner
Copy Link

@Chandresh1007 commented on GitHub (Feb 23, 2021):

Feature team disagrees. WinUI2 team disagrees.
The WinUI team thinks that this would be audible clutter. Because you can only get to the Close button using “Items” navigation, it will read the contents of the tab header (“Windows PowerShell”) before you get to “Close Tab”. Therefore, it would say “Windows powershell. Close Tab Windows Powershell”.

Hence, Closing the bug.

@Chandresh1007 commented on GitHub (Feb 23, 2021): Feature team disagrees. WinUI2 team disagrees. The WinUI team thinks that this would be audible clutter. Because you can only get to the Close button using “Items” navigation, it will read the contents of the tab header (“Windows PowerShell”) before you get to “Close Tab”. Therefore, it would say “Windows powershell. Close Tab Windows Powershell”. Hence, Closing the bug.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev3 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11677
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?