starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Underline hyperlink on hover, even if not focused #11678

New Issue
Closed
opened 2026-01-31 02:54:29 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 02:54:29 +00:00
Owner
Copy Link

Originally created by @KalleOlaviNiemitalo on GitHub (Dec 3, 2020).

Description of the new feature/enhancement

I'd like Windows Terminal to underline the hyperlink on which I hover the mouse pointer, even if the pane and the Windows Terminal window do not have the focus. This would feel more consistent because a single Ctrl+click already suffices to open the hyperlink regardless of where the focus is.

I suppose it should then show the tool tip as well.

Originally created by @KalleOlaviNiemitalo on GitHub (Dec 3, 2020). # Description of the new feature/enhancement I'd like Windows Terminal to underline the hyperlink on which I hover the mouse pointer, even if the pane and the Windows Terminal window do not have the focus. This would feel more consistent because a single Ctrl+click already suffices to open the hyperlink regardless of where the focus is. I suppose it should then show the tool tip as well.
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

Huh, I don't think we're doing any special logic if the control is focused or not. WE might not get mouse events at all if the control isn't focused 😕

There might be a way to tell XAML to give us the events though, we'll need to investigate.

@zadjii-msft commented on GitHub (Dec 3, 2020): Huh, I don't think we're doing any special logic if the control is focused or not. WE might not get mouse events _at all_ if the control isn't focused 😕 There might be a way to tell XAML to give us the events though, we'll need to investigate.
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 3, 2020):

@zadjii-msft - not sure if it is related, but:

 void TermControl::_PointerMovedHandler(Windows::Foundation::IInspectable const& /*sender*/,
                                           Input::PointerRoutedEventArgs const& args)
{
...
        if (!_focused)
        {
            args.Handled(true);
            return;
        }
...
}

I can take a look if it helps

@Don-Vito commented on GitHub (Dec 3, 2020): @zadjii-msft - not sure if it is related, but: ``` void TermControl::_PointerMovedHandler(Windows::Foundation::IInspectable const& /*sender*/, Input::PointerRoutedEventArgs const& args) { ... if (!_focused) { args.Handled(true); return; } ... } ``` I can take a look if it helps
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

🤦‍♂️

Well that's on me for triaging at 4:30am without coffee. Thanks!

@zadjii-msft commented on GitHub (Dec 3, 2020): 🤦‍♂️ Well that's on me for triaging at 4:30am without coffee. Thanks!
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@PhMajerus commented on GitHub (Dec 13, 2020):

Related, if a hyperlink is highlighted because of a mouse hover, and user alt-tab to activate another app, the hyperlink will stay in that state regardless of mouse position until Terminal receives the focus again.

I agree with @KalleOlaviNiemitalo that hyperlinks should still react to mouse hover when Terminal doesn't have the focus as it would be consistent with the hover behavior of all GDI common controls since Windows 98, but if the current behavior is to be kept for performance reasons or something, all hyperlinks should return to non-highlighted state when Terminal loses the focus.

@PhMajerus commented on GitHub (Dec 13, 2020): Related, if a hyperlink is highlighted because of a mouse hover, and user alt-tab to activate another app, the hyperlink will stay in that state regardless of mouse position until Terminal receives the focus again. I agree with @KalleOlaviNiemitalo that hyperlinks should still react to mouse hover when Terminal doesn't have the focus as it would be consistent with the hover behavior of all GDI common controls since Windows 98, but if the current behavior is to be kept for performance reasons or something, all hyperlinks should return to non-highlighted state when Terminal loses the focus.
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@KalleOlaviNiemitalo commented on GitHub (Dec 14, 2020):

If I start selecting text with the mouse in Windows Terminal, and Alt+Tab to a different window while keeping the mouse button down, then the selection no longer reacts to the position of the mouse cursor; but if I Alt+Tab back to Windows Terminal without having released the mouse button, then the selection starts reacting again. I presume this is a consequence of the previously quoted source code.

@KalleOlaviNiemitalo commented on GitHub (Dec 14, 2020): If I start selecting text with the mouse in Windows Terminal, and Alt+Tab to a different window while keeping the mouse button down, then the selection no longer reacts to the position of the mouse cursor; but if I Alt+Tab back to Windows Terminal without having released the mouse button, then the selection starts reacting again. I presume this is a consequence of the previously quoted source code.
claunia commented 2026-01-31 02:54:31 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 28, 2021):

:tada:This issue was addressed in #8615, which has now been successfully released as Windows Terminal Preview v1.6.10272.0.🎉

Handy links:

@ghost commented on GitHub (Jan 28, 2021): :tada:This issue was addressed in #8615, which has now been successfully released as `Windows Terminal Preview v1.6.10272.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10272.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl Help Wanted Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11678
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?