starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal crashes on startup when initial rows on screen (initialRows setting) is set too high #1168

New Issue
Closed
opened 2026-01-30 22:17:58 +00:00 by claunia · 9 comments
claunia commented 2026-01-30 22:17:58 +00:00
Owner
Copy Link

Originally created by @metathinker on GitHub (May 16, 2019).

Using this commit: e3764b2081

  1. Make sure there is no existing Terminal settings file at: %LocalAppData%\Packages\WindowsTerminalDev_8wekyb3d8bbwe\RoamingState\profiles.json
  2. Build Terminal with tools\razzle.cmd & bcz.
  3. Open the OpenConsole.sln in Visual Studio, select debug/release and CPU architecture to match your build, and hit F5 to deploy and run the Terminal .appx package.
  4. Open the newly created Terminal settings file, and change the initialRows setting from 30 to 1637.
  5. Close and restart Terminal.

Observe that Terminal does not start at all. If you start Terminal under a debugger, you'll see that the release build crashes with an unhandled C++ exception. (I haven't tried the debug build.)

Setting initialRows to 1636 or less does not cause the problem, but setting it to 1637 (as above) or greater does cause it.

Originally posted by @metathinker in https://github.com/microsoft/terminal/pull/843#discussion_r284818080 - that PR does not fix or otherwise affect this bug.

Originally created by @metathinker on GitHub (May 16, 2019). Using this commit: e3764b2081b74c67fb901b2c133380c5bd3787af 1. Make sure there is no existing Terminal settings file at: `%LocalAppData%\Packages\WindowsTerminalDev_8wekyb3d8bbwe\RoamingState\profiles.json` 2. Build Terminal with `tools\razzle.cmd & bcz`. 3. Open the OpenConsole.sln in Visual Studio, select debug/release and CPU architecture to match your build, and hit F5 to deploy and run the Terminal .appx package. 4. Open the newly created Terminal settings file, and change the `initialRows` setting from 30 to 1637. 5. Close and restart Terminal. Observe that Terminal does not start at all. If you start Terminal under a debugger, you'll see that the release build crashes with an unhandled C++ exception. (I haven't tried the debug build.) Setting `initialRows` to 1636 or less does not cause the problem, but setting it to 1637 (as above) or greater does cause it. _Originally posted by @metathinker in https://github.com/microsoft/terminal/pull/843#discussion_r284818080_ - that PR does not fix or otherwise affect this bug.
claunia commented 2026-01-30 22:18:00 +00:00
Author
Owner
Copy Link

@mKay00 commented on GitHub (May 16, 2019):

For me it crashes >= 820

@mKay00 commented on GitHub (May 16, 2019): For me it crashes >= 820
claunia commented 2026-01-30 22:18:00 +00:00
Author
Owner
Copy Link

@dkter commented on GitHub (May 19, 2019):

For me it crashes >= 1559 at 100% scaling. Changing my primary display resolution doesn't change the result but changing the scaling does (my primary display is 1920x1080, I have two other displays but they don't seem to be relevant):

Scaling Max value of initialRows
100% 1558
125% 1246
150% 1038
175% 889
@dkter commented on GitHub (May 19, 2019): For me it crashes >= 1559 at 100% scaling. Changing my primary display resolution doesn't change the result but changing the scaling does (my primary display is 1920x1080, I have two other displays but they don't seem to be relevant): | Scaling | Max value of `initialRows` | | -------- | ----------- | | 100% | 1558 | | 125% | 1246 | | 150% | 1038 | | 175% | 889 |
claunia commented 2026-01-30 22:18:00 +00:00
Author
Owner
Copy Link

@dkter commented on GitHub (May 20, 2019):

This definitely looks like an integer overflow issue. From https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L1119 it looks like the program crashes when height > 32728.0.

Edit: At https://github.com/microsoft/terminal/blob/master/src/cascadia/WindowsTerminal/AppHost.cpp#L135 and https://github.com/microsoft/terminal/blob/master/src/cascadia/WindowsTerminal/AppHost.cpp#L176 the height is being gsl::narrowed to a short, which will cause a crash at either of those two places.

@dkter commented on GitHub (May 20, 2019): This definitely looks like an integer overflow issue. From https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalControl/TermControl.cpp#L1119 it looks like the program crashes when `height` > 32728.0. Edit: At https://github.com/microsoft/terminal/blob/master/src/cascadia/WindowsTerminal/AppHost.cpp#L135 and https://github.com/microsoft/terminal/blob/master/src/cascadia/WindowsTerminal/AppHost.cpp#L176 the height is being `gsl::narrow`ed to a short, which will cause a crash at either of those two places.
claunia commented 2026-01-30 22:18:00 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 20, 2019):

Great work finding that @dkter. Seems like a simple enough fix for someone to submit a PR for :)

@zadjii-msft commented on GitHub (May 20, 2019): Great work finding that @dkter. Seems like a simple enough fix for someone to submit a PR for :)
claunia commented 2026-01-30 22:18:00 +00:00
Author
Owner
Copy Link

@dkter commented on GitHub (May 21, 2019):

For consistency it might be helpful to use the existing _ClampToShortMax helper from #843, but it seems to be in Terminal.cpp -- is there a better place to put it?

@dkter commented on GitHub (May 21, 2019): For consistency it might be helpful to use the existing `_ClampToShortMax` helper from #843, but it seems to be in `Terminal.cpp` -- is there a better place to put it?
claunia commented 2026-01-30 22:18:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 21, 2019):

@dkter usually for things like that, we'll throw them in src/types/utils.cpp (and src/types/inc/utils.hpp). That's kinda our dependency-free helper lib that's used by a ton of things.

@zadjii-msft commented on GitHub (May 21, 2019): @dkter usually for things like that, we'll throw them in `src/types/utils.cpp` (and `src/types/inc/utils.hpp`). That's kinda our dependency-free helper lib that's used by a ton of things.
claunia commented 2026-01-30 22:18:01 +00:00
Author
Owner
Copy Link

@dkter commented on GitHub (Jun 2, 2019):

I wanted to add unit tests, but I wasn't sure where to put them for the WindowsTerminal project?

@dkter commented on GitHub (Jun 2, 2019): I wanted to add unit tests, but I wasn't sure where to put them for the `WindowsTerminal` project?
claunia commented 2026-01-30 22:18:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jun 3, 2019):

Right now the only tests we have are in src\cascadia\unittests_terminalcore, and they only really test the "TerminalCore" project. I'm working on adding a test framework for the rest of the projects, but that's proving to be a bit harder that we hoped (see #1042 for way more detail)

@zadjii-msft commented on GitHub (Jun 3, 2019): Right now the only tests we have are in `src\cascadia\unittests_terminalcore`, and they only really test the "TerminalCore" project. I'm working on adding a test framework for the rest of the projects, but that's proving to be a bit harder that we hoped (see #1042 for _way_ more detail)
claunia commented 2026-01-30 22:18:01 +00:00
Author
Owner
Copy Link

@Reelix commented on GitHub (Oct 24, 2019):

Even though this bug is closed, it still exists in the newly released Version 0.6.2951.0

@Reelix commented on GitHub (Oct 24, 2019): Even though this bug is closed, it still exists in the newly released Version 0.6.2951.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?