starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Screen Reader - Open and close New Tab]: Not able to open or close any tab using 'Ctrl+Shift+T' or 'Ctrl+Shift+W' when narrator focus is not present in the edit area. #11682

New Issue
Closed
opened 2026-01-31 02:54:36 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 02:54:36 +00:00
Owner
Copy Link

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020).

Originally assigned to: @zadjii-msft on GitHub.

User Experience:
If any application does not allow assistive technology to programmatically execute available actions on objects it would be difficult for the platforms that provide Accessibility APIs, and would in turn affect the screen reader dependent users to determine the programmatically executable actions on objects.

Test Environment:
OS: Win 10 2004 Build (20262.1010)
App: Windows Terminal
App version: 1.4.3243.0

Repro Steps:

  1. Open Windows terminal app.
  2. Launch Narrator.
  3. Turn on the scan mode using 'Caps+Space'.
  4. Navigate the narrator focus out of edit area.
  5. Now press 'Ctrl+Shift+T' or 'Ctrl+Shift+W' to open or close any tab.
  6. Observe the issue.

Actual Result:
Not able to open or close any tab using 'Ctrl+Shift+T' or 'Ctrl+Shift+W' when narrator focus is not present in the edit area in the scan mode of the narrator.

Expected Result:
User should be able to open or close any tab using 'Ctrl+Shift+T' or 'Ctrl+Shift+W' even when narrator focus is not present in the edit area.

Note: NVDA browse mode not working.

MAS Reference:
MAS4.2.9
https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7Baa4c94fe-60fa-4003-8a52-7abca179bde2%7D&cid=f00419a4-9d8d-4a89-a0e0-d39e9cb77c27

MAS4.2.9_Not able to open or close any tab when focus is not in edit area.zip

Originally created by @Chandresh1007 on GitHub (Dec 3, 2020). Originally assigned to: @zadjii-msft on GitHub. **User Experience:** If any application does not allow assistive technology to programmatically execute available actions on objects it would be difficult for the platforms that provide Accessibility APIs, and would in turn affect the screen reader dependent users to determine the programmatically executable actions on objects. **Test Environment:** OS: Win 10 2004 Build (20262.1010) App: Windows Terminal App version: 1.4.3243.0 **Repro Steps:** 1. Open Windows terminal app. 2. Launch Narrator. 3. Turn on the scan mode using 'Caps+Space'. 4. Navigate the narrator focus out of edit area. 5. Now press 'Ctrl+Shift+T' or 'Ctrl+Shift+W' to open or close any tab. 6. Observe the issue. **Actual Result:** **Not able to open or close any tab using 'Ctrl+Shift+T' or 'Ctrl+Shift+W' when narrator focus is not present in the edit area** in the scan mode of the narrator. **Expected Result:** User **should be able to open or close any tab using 'Ctrl+Shift+T' or 'Ctrl+Shift+W'** even when narrator focus is not present in the edit area. **Note:** NVDA browse mode not working. **MAS Reference:** **MAS4.2.9** https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc=%7Baa4c94fe-60fa-4003-8a52-7abca179bde2%7D&cid=f00419a4-9d8d-4a89-a0e0-d39e9cb77c27 [MAS4.2.9_Not able to open or close any tab when focus is not in edit area.zip](https://github.com/microsoft/terminal/files/5636124/MAS4.2.9_Not.able.to.open.or.close.any.tab.when.focus.is.not.in.edit.area.zip)
claunia commented 2026-01-31 02:54:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

Yea, this is probably more fundamental than just #8462 or #6679 - our keybindings are only bound within the context of Terminal Controls. They aren't bound anywhere else in the app, mostly because the entire app is just Terminal Controls.

I know @DHowett has had a mind to change this in the past, but changing this is not a minor bugfix - it would be a pretty fundamental refactoring of our key handling.

@zadjii-msft commented on GitHub (Dec 3, 2020): Yea, this is probably more fundamental than just #8462 or #6679 - our keybindings are only bound within the context of Terminal Controls. They aren't bound anywhere else in the app, mostly because the entire app is just Terminal Controls. I know @DHowett has had a mind to change this in the past, but changing this is not a minor bugfix - it would be a pretty fundamental refactoring of our key handling.
claunia commented 2026-01-31 02:54:40 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Nov 2, 2021):

stashed my prototype in dev/migrie/b/8480-keybindings-in-tabs,
which I then rebased to dev/migrie/b/8480-rebase

@zadjii-msft commented on GitHub (Nov 2, 2021): stashed my prototype in `dev/migrie/b/8480-keybindings-in-tabs`, which I then rebased to [`dev/migrie/b/8480-rebase`](https://github.com/microsoft/terminal/compare/dev/migrie/b/8480-rebase)
claunia commented 2026-01-31 02:54:40 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 3, 2022):

@Chandresh1007 This is now fixed in v1.12.10334.0. Can you please confirm?

@carlos-zamora commented on GitHub (Feb 3, 2022): @Chandresh1007 This is now fixed in v1.12.10334.0. Can you please confirm?
claunia commented 2026-01-31 02:54:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 4, 2022):

@v-rpundir This one too 😉

@zadjii-msft commented on GitHub (Feb 4, 2022): @v-rpundir This one too 😉
claunia commented 2026-01-31 02:54:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 4, 2022):

Closing as fixed on Windows Terminal Preview Version: 1.13.10336.0

@ghost commented on GitHub (Feb 4, 2022): Closing as fixed on Windows Terminal Preview Version: 1.13.10336.0
claunia commented 2026-01-31 02:54:41 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 4, 2022):

@v-rpundir Thanks! There are a couple others that should be fixed in this release as well: https://github.com/microsoft/terminal/issues?q=is%3Aopen+label%3AResolution-Fix-Committed+label%3AA11yWCAG

Not sure what the cleanest way to ping you about these all is 😅

@zadjii-msft commented on GitHub (Feb 4, 2022): @v-rpundir Thanks! There are a couple others that should be fixed in this release as well: https://github.com/microsoft/terminal/issues?q=is%3Aopen+label%3AResolution-Fix-Committed+label%3AA11yWCAG Not sure what the cleanest way to ping you about these all is 😅
claunia commented 2026-01-31 02:54:41 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 7, 2022):

Hi @zadjii-msft Just simply mention me in individual bug or in one bug with other bugs query with below details:

  1. Fix Terminal Version
  2. Fix Terminal build download link

Thanks :):

@ghost commented on GitHub (Feb 7, 2022): Hi @zadjii-msft Just simply mention me in individual bug or in one bug with other bugs query with below details: 1. Fix Terminal Version 2. Fix Terminal build download link Thanks :):
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label A11yCO A11ySev2 A11yWCAG Area-Accessibility HCL-E+D HCL-WindowsTerminal Issue-Feature Priority-2 Product-Terminal Resolution-Fix-Committed WindowsTerminal_Win32
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11682
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?