starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Some test scripts don't work correctly #11692

New Issue
Closed
opened 2026-01-31 02:54:55 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 02:54:55 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Dec 3, 2020).

Environment

Windows build number: Version 10.0.18363.1198
Windows Terminal version (if applicable): Commit 62131720aa

Steps to reproduce

  1. In a cmd shell, change to the tools directory.
  2. Setup the build environment by running razzle.cmd
  3. Produce a release build by running bz.cmd rel
  4. Attempt to run the feature tests: runft.cmd
  5. Attempt to run the Terminal Core unit tests: runut /name:TerminalCore*

Expected behavior

The tests should run.

Actual behavior

The feature tests fail with the following errors:

Warning: TAEF: The test file "C:\terminal\bin\x64\Debug\ConHost.Feature.Tests.dll" does not exist.
Error: TAEF: None of the specified test files were found.

The unit tests fail with the following errors:

Warning: TAEF: The test file "C:\terminal\bin\x64\Release\Terminal.Core.Unit.Tests.dll" does not exist.
Error: TAEF: The selection criteria did not match any tests.
Error: TAEF: No test cases were executed.

The runft error is simply a result of the script being hardcoded to test a Debug build.
ae550e0969/tools/runft.cmd (L7)

We just need to change that Debug to %_LAST_BUILD_CONF% to make it work with both debug and release builds.

The runut error is the result of the path of Terminal.Core.Unit.Tests.dll being incorrect.
ae550e0969/tools/runut.cmd (L19)

That can be fixed by changing that line to:

%OPENCON%\bin\%PLATFORM%\%_LAST_BUILD_CONF%\UnitTests_TerminalCore\Terminal.Core.Unit.Tests.dll ^

That said, I'm note positive that's the right solution, because it used to work with the current path. I can't remember when exactly it first broke, but I'm assuming it was the result of a change in the project structure. If that change wasn't intentional then maybe it's the project that needs correcting instead of updating the test script.

Originally created by @j4james on GitHub (Dec 3, 2020). # Environment Windows build number: Version 10.0.18363.1198 Windows Terminal version (if applicable): Commit 62131720aa7a95df7ed397801c373d4eab0fd3d6 # Steps to reproduce 1. In a cmd shell, change to the tools directory. 2. Setup the build environment by running `razzle.cmd` 3. Produce a release build by running `bz.cmd rel` 4. Attempt to run the feature tests: `runft.cmd` 5. Attempt to run the Terminal Core unit tests: `runut /name:TerminalCore*` # Expected behavior The tests should run. # Actual behavior The feature tests fail with the following errors: ``` Warning: TAEF: The test file "C:\terminal\bin\x64\Debug\ConHost.Feature.Tests.dll" does not exist. Error: TAEF: None of the specified test files were found. ``` The unit tests fail with the following errors: ``` Warning: TAEF: The test file "C:\terminal\bin\x64\Release\Terminal.Core.Unit.Tests.dll" does not exist. Error: TAEF: The selection criteria did not match any tests. Error: TAEF: No test cases were executed. ``` The `runft` error is simply a result of the script being hardcoded to test a `Debug` build. https://github.com/microsoft/terminal/blob/ae550e0969595f062b15c2ff5cc33d4afe8ebc3f/tools/runft.cmd#L7 We just need to change that `Debug` to `%_LAST_BUILD_CONF%` to make it work with both debug and release builds. The `runut` error is the result of the path of `Terminal.Core.Unit.Tests.dll` being incorrect. https://github.com/microsoft/terminal/blob/ae550e0969595f062b15c2ff5cc33d4afe8ebc3f/tools/runut.cmd#L19 That can be fixed by changing that line to: ``` %OPENCON%\bin\%PLATFORM%\%_LAST_BUILD_CONF%\UnitTests_TerminalCore\Terminal.Core.Unit.Tests.dll ^ ``` That said, I'm note positive that's the right solution, because it used to work with the current path. I can't remember when exactly it first broke, but I'm assuming it was the result of a change in the project structure. If that change wasn't intentional then maybe it's the project that needs correcting instead of updating the test script.
claunia commented 2026-01-31 02:54:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Dec 3, 2020):

No, you're definitely right about the unit tests thing. We pretty recently unified our project structures, so things get binplaced in more sensible locations, but clearly didn't update all our tooling. @DHowett did it recently, but I'm too lazy to dig out which PR exactly.

As far as feature tests go, I think it's pretty clear we don't run those locally enough. We can barely get the to pass in CI 😝

@zadjii-msft commented on GitHub (Dec 3, 2020): No, you're definitely right about the unit tests thing. We pretty recently unified our project structures, so things get binplaced in more sensible locations, but clearly didn't update _all_ our tooling. @DHowett did it recently, but I'm too lazy to dig out which PR exactly. As far as feature tests go, I think it's pretty clear we don't run those locally enough. We can barely get the to pass in CI 😝
claunia commented 2026-01-31 02:54:57 +00:00
Author
Owner
Copy Link

@j4james commented on GitHub (Dec 3, 2020):

The tests do actually work reasonably well when run locally. I'm used to the fact that some of them are always bound to be broken, but they're still useful to me as a way to confirm that I haven't introduced new breaks before submitting a PR. It was just becoming a bit of pain always having to patch the batch files when I wanted to test.

@j4james commented on GitHub (Dec 3, 2020): The tests do actually work reasonably well when run locally. I'm used to the fact that some of them are always bound to be broken, but they're still useful to me as a way to confirm that I haven't introduced new breaks before submitting a PR. It was just becoming a bit of pain always having to patch the batch files when I wanted to test.
claunia commented 2026-01-31 02:54:57 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 3, 2020):

Actually the tests work much better locally than in CI 😄
I always run them before PR as well.. but the paths are screwed lately.. so not to patch the batch files I have another batch that copies the dlls to the expected locations 😊

@Don-Vito commented on GitHub (Dec 3, 2020): Actually the tests work much better locally than in CI :smile: I always run them before PR as well.. but the paths are screwed lately.. so not to patch the batch files I have another batch that copies the dlls to the expected locations :blush:
claunia commented 2026-01-31 02:54:57 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Dec 3, 2020):

Gah, sorry I moved all the files around and didn’t update the test scripts. Shows you how well I know our own tools 😄

@DHowett commented on GitHub (Dec 3, 2020): Gah, sorry I moved all the files around and didn’t update the test scripts. Shows you how well I know our own tools :smile:
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Issue-Bug Needs-Triage Product-Meta Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11692
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?