improve the default settings #1182

Closed
opened 2026-01-30 22:18:17 +00:00 by claunia · 7 comments
Owner

Originally created by @DHowett-MSFT on GitHub (May 17, 2019).

Originally assigned to: @DHowett-MSFT on GitHub.

Followup to #430. Here's what I'm thinking.

  • alwaysShowTabs -> true
  • experimental_showTabsInTitlebar -> true
  • always include Windows Powershell (background: #012456)
  • include PowerShell Core separately (background: unset)
  • drop Courier New for powershell
Originally created by @DHowett-MSFT on GitHub (May 17, 2019). Originally assigned to: @DHowett-MSFT on GitHub. Followup to #430. Here's what I'm thinking. * [ ] `alwaysShowTabs` -> `true` * [ ] `experimental_showTabsInTitlebar` -> `true` * [ ] always include Windows Powershell (`background`: `#012456`) * [ ] include PowerShell Core separately (`background`: unset) * [ ] drop `Courier New` for powershell
Author
Owner

@zadjii-msft commented on GitHub (May 17, 2019):

We're automatically making powershell (core) the default now. If core is installed, should that be the default? or Windows powershell always?

Also, if we're making show tabs in titlebar the default, then we should probably pull experimental_ off of it.

@zadjii-msft commented on GitHub (May 17, 2019): We're automatically making powershell (core) the default now. If core is installed, should that be the default? or Windows powershell always? Also, if we're making show tabs in titlebar the default, then we should probably pull `experimental_` off of it.
Author
Owner

@mdtauk commented on GitHub (May 17, 2019):

We're automatically making powershell (core) the default now. If core is installed, should that be the default? or Windows powershell always?

Also, if we're making show tabs in titlebar the default, then we should probably pull experimental_ off of it.

I would suggest you read the registry setting to see if the user has changed the setting to use Command instead of Powershell.

image

HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\DontUsePowerShellOnWinX

@mdtauk commented on GitHub (May 17, 2019): > We're automatically making powershell (core) the default now. If core is installed, should that be the default? or Windows powershell always? > > Also, if we're making show tabs in titlebar the default, then we should probably pull `experimental_` off of it. I would suggest you read the registry setting to see if the user has changed the setting to use Command instead of Powershell. ![image](https://user-images.githubusercontent.com/7389110/57929342-f3b4da00-78aa-11e9-9012-246e0aa1dcf5.png) ### HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\Advanced\DontUsePowerShellOnWinX
Author
Owner

@fearthecowboy commented on GitHub (May 17, 2019):

What's your detection mechanism for seeing if pwsh is installed?

@fearthecowboy commented on GitHub (May 17, 2019): What's your detection mechanism for seeing if pwsh is installed?
Author
Owner

@DHowett-MSFT commented on GitHub (May 17, 2019):

Today, it’s “crawl through Program Files to find telltale signs of it.” Tomorrow, however, maybe it’ll be “look into the installer database (using supported APIs) to see where the user really put it.”

@DHowett-MSFT commented on GitHub (May 17, 2019): Today, it’s “crawl through Program Files to find telltale signs of it.” Tomorrow, however, maybe it’ll be “look into the installer database (using supported APIs) to see where the user really put it.”
Author
Owner

@DHowett-MSFT commented on GitHub (May 17, 2019):

I would suggest you read the registry setting to see if the user has changed the setting to use Command instead of Powershell.

We've debated about this for a while internally. It's a good idea, and we should do it, but the registry is not a contract, and we are not supposed to go groveling about in other peoples' registry keys. It's the same fundamental issue as was brought up in #695.

What we should be doing is driving API dependencies, as we are with WSL, so that we can detect how the user's configured their machine.

@DHowett-MSFT commented on GitHub (May 17, 2019): > I would suggest you read the registry setting to see if the user has changed the setting to use Command instead of Powershell. We've debated about this for a while internally. It's a good idea, and we should do it, but _the registry is not a contract, and we are not supposed to go groveling about in other peoples' registry keys._ It's the same fundamental issue as was brought up in #695. What we should be doing is driving API dependencies, as we are with WSL, so that we can detect how the user's configured their machine.
Author
Owner

@mdtauk commented on GitHub (May 17, 2019):

I agree this should be a default app type and WinRT should provide a read only API to receive a friendly package name, and entry point path for all default apps that are installed.

I personally always switch my default to CMD, and avoid powershell (unless I need to trouble shoot some store apps)

@mdtauk commented on GitHub (May 17, 2019): I agree this should be a default app type and WinRT should provide a read only API to receive a friendly package name, and entry point path for all ~~default~~ apps that are installed. I personally always switch my default to CMD, and avoid powershell (unless I need to trouble shoot some store apps)
Author
Owner

@zadjii-msft commented on GitHub (May 20, 2019):

I propose also changing the default font size, as caught in #903. The default font size of 12 was originally 12px, but since then we changed the DX renderer such that 12 meant 12 point. 12 point is definitely bigger than 12px tall

@zadjii-msft commented on GitHub (May 20, 2019): I propose also changing the default font size, as caught in #903. The default font size of `12` was originally 12px, but since then we changed the DX renderer such that 12 meant 12 point. 12 point is definitely bigger than 12px tall
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1182