starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

[Feature request] Highlight all found results #11882

New Issue
Closed
opened 2026-01-31 03:00:05 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 03:00:05 +00:00
Owner
Copy Link

Originally created by @SiqingYu on GitHub (Dec 26, 2020).

Description of the new feature/enhancement

Related to the Find tool: Ctrl+Shift+F

Currently, Windows Terminal only highlights one in found result:

Screenshot 2020-12-26 172604

Users need to input Enter key to iterate all the results.

What I propose is to highlight all results at once, like what Konsole and iTerm do:

Screenshot 2020-12-26 172500

image
(Credit)

This feature can be useful in many ways:

  • Developers would like to monitor keywords like ERROR, FATAL in real-time output. A Find tool that highlights the keywords as they appear would be helpful.
  • Developers can see all highlights at a glance without hitting Enter many times.
  • Grep can't replace this feature because grep removes lines that don't contain the keywords but are informational and should be shown.
Originally created by @SiqingYu on GitHub (Dec 26, 2020). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> Related to the Find tool: Ctrl+Shift+F Currently, Windows Terminal only highlights one in found result: ![Screenshot 2020-12-26 172604](https://user-images.githubusercontent.com/22290018/103148918-d4c53c00-479f-11eb-9ba8-d271721a1945.png) Users need to input Enter key to iterate all the results. What I propose is to highlight all results at once, like what Konsole and iTerm do: ![Screenshot 2020-12-26 172500](https://user-images.githubusercontent.com/22290018/103148953-1524ba00-47a0-11eb-9bb0-3a9df76adfdc.png) ![image](https://user-images.githubusercontent.com/22290018/103149030-d3484380-47a0-11eb-9ac3-556250d13ce4.png) ([Credit](https://apple.stackexchange.com/questions/162315/iterm2-how-to-change-the-color-used-to-highlight-search-results)) This feature can be useful in many ways: - Developers would like to monitor keywords like ERROR, FATAL in **real-time** output. A Find tool that highlights the keywords as they appear would be helpful. - Developers can see all highlights at a glance without hitting Enter many times. - `Grep` can't replace this feature because `grep` removes lines that don't contain the keywords but are informational and should be shown.
claunia added the Issue-FeatureNeeds-TriageNeeds-Tag-Fix labels 2026-01-31 03:00:06 +00:00
claunia commented 2026-01-31 03:00:07 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Dec 26, 2020):

@SiqingYu - please review if #7561 satisfies your needs

@Don-Vito commented on GitHub (Dec 26, 2020): @SiqingYu - please review if #7561 satisfies your needs
claunia commented 2026-01-31 03:00:07 +00:00
Author
Owner
Copy Link

@SiqingYu commented on GitHub (Dec 26, 2020):

@Don-Vito Yes. This issue duplicates #7561

@SiqingYu commented on GitHub (Dec 26, 2020): @Don-Vito Yes. This issue duplicates #7561
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11882
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?