starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Assignment operators in til::spsc don't return anything #11940

New Issue
Open
opened 2026-01-31 03:01:43 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 03:01:43 +00:00
Owner
Copy Link

Originally created by @j4james on GitHub (Jan 3, 2021).

Originally assigned to: @lhecker on GitHub.

Environment

Windows build number: Version 10.0.18363.1198
Windows Terminal version (if applicable):

Steps to reproduce

I was trying to use the til::spsc class to do something like this:

auto channel = til::spsc::channel<QueueItem>(100);
auto producer = std::move(channel.first);
channel.first = std::move(producer);

Expected behavior

The code should compile.

Actual behavior

It fails with the error:

C:\terminal\src\inc\til\spsc.h(429): error C4716: 'til::spsc::producer<QueueItem>::operator=': must return a value

I believe the problem is that the assignment operators in the producer and consumer classes don't actually return anything.

See here:
ae550e0969/src/inc/til/spsc.h (L424-L428)

and here:
ae550e0969/src/inc/til/spsc.h (L542-L546)

I'm assuming they should have a return *this; or something along those lines.

Originally created by @j4james on GitHub (Jan 3, 2021). Originally assigned to: @lhecker on GitHub. # Environment Windows build number: Version 10.0.18363.1198 Windows Terminal version (if applicable): # Steps to reproduce I was trying to use the `til::spsc` class to do something like this: ``` auto channel = til::spsc::channel<QueueItem>(100); auto producer = std::move(channel.first); channel.first = std::move(producer); ``` # Expected behavior The code should compile. # Actual behavior It fails with the error: ``` C:\terminal\src\inc\til\spsc.h(429): error C4716: 'til::spsc::producer<QueueItem>::operator=': must return a value ``` I believe the problem is that the assignment operators in the `producer` and `consumer` classes don't actually return anything. See here: https://github.com/microsoft/terminal/blob/ae550e0969595f062b15c2ff5cc33d4afe8ebc3f/src/inc/til/spsc.h#L424-L428 and here: https://github.com/microsoft/terminal/blob/ae550e0969595f062b15c2ff5cc33d4afe8ebc3f/src/inc/til/spsc.h#L542-L546 I'm assuming they should have a `return *this;` or something along those lines.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Bug Product-Conhost Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11940
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?