starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-07-08 18:16:28 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Bad default selection background color with light schemes #11974

New Issue
Closed
opened 2026-01-31 03:02:55 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 03:02:55 +00:00
Owner
Copy Link

Originally created by @austin-beer on GitHub (Jan 6, 2021).

Environment

Windows build number: 10.0.18363.0
Windows Terminal version: 1.4.3243.0

Steps to reproduce

  1. Update settings.json to use the One Half Light, Solarized Light, or Tango Light color schemes.
  2. Use the mouse to highlight some text.

Expected behavior

It's easy to see which text was selected.

Actual behavior

It's hard to see which text was selected because the default selectionBackground value is white, and that doesn't work well with light color schemes.

Proposed solution

Add selectionBackground values to all of the color schemes in defaults.json (or at least the light color schemes).

Related to

This issue is related to #3326, #3561, and #3580.

Originally created by @austin-beer on GitHub (Jan 6, 2021). # Environment ```none Windows build number: 10.0.18363.0 Windows Terminal version: 1.4.3243.0 ``` # Steps to reproduce 1. Update settings.json to use the `One Half Light`, `Solarized Light`, or `Tango Light` color schemes. 1. Use the mouse to highlight some text. # Expected behavior It's easy to see which text was selected. # Actual behavior It's hard to see which text was selected because the default selectionBackground value is white, and that doesn't work well with light color schemes. # Proposed solution Add selectionBackground values to all of the color schemes in defaults.json (or at least the light color schemes). # Related to This issue is related to #3326, #3561, and #3580.
claunia commented 2026-01-31 03:02:57 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 8, 2021):

Okay, you're not wrong here. Part of the trick with these schemes is that they don't canonically include a selection color. Usually, they're just defined as a set of (foreground, background, 16-color table). The selection color is almost always just set by the terminal emulator. So if we were to add selection BG colors to these schemes, that would be some other customization that we're making to these schemes other than their usual definitions.

Though, I think I agree - until #3561 lands, the experience with these themes is just bad. I wonder if we could just use the "bright black" color for each of these schemes and have it work good enough.

Note

Walkthrough

Go through each of the "light" color schemes in defaults.json, and add a selectionBackground property which is set to the scheme's brightBlack.

This will probably end up in a team discussion, but it'll be helpful to have a concrete example to drive that discussion.

@zadjii-msft commented on GitHub (Jan 8, 2021): Okay, you're not wrong here. Part of the trick with these schemes is that they don't canonically include a selection color. Usually, they're just defined as a set of (foreground, background, 16-color table). The selection color is almost always just set by the terminal emulator. So if we were to add selection BG colors to these schemes, that would be some other customization that we're making to these schemes other than their usual definitions. Though, I think I agree - until #3561 lands, the experience with these themes is just _bad_. I wonder if we could just use the "bright black" color for each of these schemes and have it work _good enough_. > **Note** > ## Walkthrough Go through each of the "light" color schemes in `defaults.json`, and add a `selectionBackground` property which is set to the scheme's `brightBlack`. This will probably end up in a team discussion, but it'll be helpful to have a concrete example to drive that discussion.
claunia commented 2026-01-31 03:02:58 +00:00
Author
Owner
Copy Link

@henryduong26 commented on GitHub (Jun 24, 2021):

  1. Select One Half Light, Solarized Light, or Tango Light color schemes
  2. Input number
    ==> can't see the number inputed

image

@henryduong26 commented on GitHub (Jun 24, 2021): 1. Select One Half Light, Solarized Light, or Tango Light color schemes 2. Input number ==> can't see the number inputed ![image](https://user-images.githubusercontent.com/26895558/123279232-dfd00d80-d531-11eb-9cd0-e78afad5471f.png)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Settings good first issue Help Wanted In-PR Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#11974
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?