starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Abstract AttrRow as til::rle<T> #12017

New Issue
Closed
opened 2026-01-31 03:04:05 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 03:04:05 +00:00
Owner
Copy Link

Originally created by @DHowett on GitHub (Jan 11, 2021).

Originally assigned to: @miniksa on GitHub.

The new buffer implementation will use RLE packed column counts.

Feature Requests

  • til::rle<T, S> where S is the size type
    • OPTIONAL: When inserting an item that doesn't fit in the size type, break it up into multiple runs. For example, a til::rle<..., uint8_t> could support a length-257 run by emitting two runs of length 255 and 2
  • substr(), which returns a subset rle. Based on this implementation.
  • iterator: i need begin, end, cbegin, cend.
  • iterator: i want to be able to + any number, not just ++ by one.
  • iterator: i need to be able to subtract two iterators to get a distance.
  • maybe a way to iterate over compressed units, for quick estimation and summing (!)
Originally created by @DHowett on GitHub (Jan 11, 2021). Originally assigned to: @miniksa on GitHub. The new buffer implementation will use RLE packed column counts. ## Feature Requests * [x] `til::rle<T, S>` where `S` is the size type * [ ] **OPTIONAL**: When inserting an item that doesn't fit in the size type, break it up into multiple runs. For example, a `til::rle<..., uint8_t>` could support a length-257 run by emitting two runs of length `255` and `2` * [ ] `substr()`, which returns a subset rle. Based on [this implementation](https://github.com/microsoft/terminal/pull/8689/files#diff-14ac35e89899118030db9cba51bc52545edfa4392a8628f4f752e3ec47be1d7dR587-R601). * [x] iterator: i need `begin`, `end`, `cbegin`, `cend`. * [x] iterator: i want to be able to `+` any number, not just `++` by one. * [x] iterator: i need to be able to subtract two iterators to get a distance. * [ ] maybe a way to iterate over compressed units, for quick estimation and summing (!)
claunia commented 2026-01-31 03:04:07 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (May 25, 2021):

:tada:This issue was addressed in #10099, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.🎉

Handy links:

@ghost commented on GitHub (May 25, 2021): :tada:This issue was addressed in #10099, which has now been successfully released as `Windows Terminal Preview v1.9.1445.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.9.1445.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Area-Output Issue-Task Product-Conhost Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12017
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?