starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Polish Settings UI: Color Scheme page #12049

New Issue
Closed
opened 2026-01-31 03:04:58 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 03:04:58 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 12, 2021).

  • Edit a color scheme -> Hit 'apply' -> the selected color scheme resets to the first color scheme in the list (instead of the one just edited)
  • The buttons turn gray on rollover covering up what color I'm looking at (I have dark mode)
  • Activate scheme renamer… then commit with enter key or dismiss with esc key and it will do the needful then go highlight the Discard Changes button at the bottom. That's a bit weird.
  • Rename/add new buttons are misaligned with combobox
    • misaligned buttons
  • Reorganize Color Scheme Entries
    • There should be 3 tables: non-bright colors, bright colors, and miscellaneous.
    • Currently, everything is bound to one color table. It would be nice to find a way to fix that.
  • Redesign color buttons
    • remove text for each color button (to prevent cropping when text is localized)
    • instead, add a tooltip (and automation property) that includes the label
  • "add new" button may be cropped when localized (needs verification after #8777)
Originally created by @carlos-zamora on GitHub (Jan 12, 2021). - [x] Edit a color scheme -> Hit 'apply' -> the selected color scheme resets to the first color scheme in the list (instead of the one just edited) - [x] The buttons turn gray on rollover covering up what color I'm looking at (I have dark mode) - [ ] Activate scheme renamer… then commit with enter key or dismiss with esc key and it will do the needful then go highlight the Discard Changes button at the bottom. That's a bit weird. - [x] Rename/add new buttons are misaligned with combobox - ![misaligned buttons](https://user-images.githubusercontent.com/11050425/104356356-b5791f00-54c0-11eb-948d-747b513e1ae3.png) - [ ] **Reorganize Color Scheme Entries** - There should be 3 tables: non-bright colors, bright colors, and miscellaneous. - Currently, everything is bound to one color table. It would be nice to find a way to fix that. - [ ] **Redesign color buttons** - remove text for each color button (to prevent cropping when text is localized) - instead, add a tooltip (and automation property) that includes the label - [ ] "add new" button may be cropped when localized (needs verification after #8777)
claunia commented 2026-01-31 03:04:59 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 13, 2021):

What have we learned? (Jan 13)

  • When you navigate to a new item in the NavigationView, we ctor a new version of that Page. That explains why adding the schemes to the list each time just worked - each navigation is starting fresh.
  • Same deal happens when we save the settings. We end up re-navigating, which causes the page to get reconstructed, which makes it impossible to store state in the page across navigations.

Let's try sticking that state in ColorSchemesPageNavigationState, and not make a new one every time we Navigate. If the MainPage just hangs onto a single copy of ColorSchemesPageNavigationState, then we can stick some data in there to be able to reconstruct the state. I'm assuming that's what it's for.

@zadjii-msft commented on GitHub (Jan 13, 2021): #### What have we learned? (Jan 13) * When you navigate to a new item in the NavigationView, _we ctor a new version of that `Page`_. That explains why adding the schemes to the list each time just worked - each navigation is starting fresh. * Same deal happens when we save the settings. We end up re-navigating, which causes the page to get reconstructed, which makes it impossible to store state _in the page_ across navigations. Let's try sticking that state in `ColorSchemesPageNavigationState`, and _not_ `make` a new one every time we Navigate. If the MainPage just hangs onto a single copy of `ColorSchemesPageNavigationState`, then we can stick some data in there to be able to reconstruct the state. I'm assuming that's what it's for.
claunia commented 2026-01-31 03:04:59 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 1, 2021):

:tada:This issue was addressed in #9196, which has now been successfully released as Windows Terminal Preview v1.7.572.0.🎉

Handy links:

@ghost commented on GitHub (Mar 1, 2021): :tada:This issue was addressed in #9196, which has now been successfully released as `Windows Terminal Preview v1.7.572.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.572.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12049
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?