starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Polish Settings UI: Keyboard navigation (w/ tab key) #12055

New Issue
Closed
opened 2026-01-31 03:05:07 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:05:07 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 12, 2021).

This is a list of issues we've found when trying to navigate the Settings UI using only the keyboard:

  • On Color Schemes edit page (with a custom scheme open so it's editable) use the tab key to navigate between controls. Press Tab from +AddNew and it will go select nothingness. One more tab will select the Black box. It should probably never select nothingness.
    • It also selects nothingness between Bright White and Foreground. Bright White (Tab) Nothingness (Tab) Foreground.
  • On all pages, it appears that once you tab all the way to Apply in the bottom right corner… you get stuck. I think tab navigation is supposed to be fully circular (going back to the first thing or the most Shift+Tabby thing) and around again.
  • Open SUI. Switch to a TerminalTab. Invoke "open Settings UI" kbd again. Hamburger menu focused.
    • Expected: highlight last highlighted setting

Potentially upstream issues:

Originally created by @carlos-zamora on GitHub (Jan 12, 2021). This is a list of issues we've found when trying to navigate the Settings UI using _only_ the keyboard: - [ ] On Color Schemes edit page (with a custom scheme open so it's editable) use the tab key to navigate between controls. Press Tab from +AddNew and it will go select nothingness. One more tab will select the Black box. It should probably never select nothingness. - It also selects nothingness between Bright White and Foreground. Bright White (Tab) Nothingness (Tab) Foreground. - [x] On all pages, it appears that once you tab all the way to Apply in the bottom right corner… you get stuck. I think tab navigation is supposed to be fully circular (going back to the first thing or the most Shift+Tabby thing) and around again. - [x] Open SUI. Switch to a TerminalTab. Invoke "open Settings UI" kbd again. Hamburger menu focused. - Expected: highlight last highlighted setting Potentially upstream issues: - [ ] tab navigation when in left bar... - <space> updates header, but not frame - [ ] individual radio buttons cannot be selected via keyboard (See https://github.com/microsoft/microsoft-ui-xaml/issues/3156) - [ ] pressing letter key in a combobox does not navigate to first combobox starting with that letter
claunia commented 2026-01-31 03:05:09 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 12, 2021):

Ok. I've done a bit of research on this issue. Here's some notes:

  • color schemes page
    • will be fixed as a part of the color schemes redesign
  • focus doesn't cycle on save button
  • highlight last highlighted setting
    • Tried using the FocusManager to store the last focused item (in SettingsTab and MainPage). Neither worked. This will require a more complex solution.
    • I'll be pulling this out into its own issue and labelling it as help wanted. I feel that it doesn't have that high of a priority (at least compared to other things).
  • tab navigation in left bar
    • this one now feels like it's by design. Closing.
  • radio buttons
    • already tagged
  • combobox
    • This one's tough. ComboBox has an IsTextSearchEnabled property that enabled this functionality. However, it only works if the list of items are "strings". Since we're defining an item template to add an icon or directly bind to the settings model, we can't explicitly use this feature and have icons at the same time.
    • I'm going to file a feature request on XAML for this one.
@carlos-zamora commented on GitHub (Feb 12, 2021): Ok. I've done a bit of research on this issue. Here's some notes: - color schemes page - will be fixed as a part of the color schemes redesign - focus doesn't cycle on save button - #9126 - not that bad - highlight last highlighted setting - Tried using the `FocusManager` to store the last focused item (in `SettingsTab` and `MainPage`). Neither worked. This will require a more complex solution. - I'll be pulling this out into its own issue and labelling it as help wanted. I feel that it doesn't have that high of a priority (at least compared to other things). - tab navigation in left bar - this one now feels like it's by design. Closing. - radio buttons - already tagged - combobox - This one's tough. `ComboBox` has an `IsTextSearchEnabled` property that enabled this functionality. However, it only works if the list of items are "strings". Since we're defining an item template to add an icon or directly bind to the settings model, we can't explicitly use this feature _and_ have icons at the same time. - I'm going to file a feature request on XAML for this one.
claunia commented 2026-01-31 03:05:09 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 18, 2021):

The ComboBox feature request is being tracked in https://github.com/microsoft/microsoft-ui-xaml/issues/4182

@carlos-zamora commented on GitHub (Feb 18, 2021): The ComboBox feature request is being tracked in https://github.com/microsoft/microsoft-ui-xaml/issues/4182
claunia commented 2026-01-31 03:05:09 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 18, 2021):

Did you try StMoy's suggestion?

@DHowett commented on GitHub (Feb 18, 2021): Did you try StMoy's suggestion?
claunia commented 2026-01-31 03:05:10 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 18, 2021):

Did you try StMoy's suggestion?

Not yet. I've been working on the color schemes page redesign.

@carlos-zamora commented on GitHub (Feb 18, 2021): > Did you try StMoy's suggestion? Not yet. I've been working on the color schemes page redesign.
claunia commented 2026-01-31 03:05:10 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Mar 1, 2021):

:tada:This issue was addressed in #9196, which has now been successfully released as Windows Terminal Preview v1.7.572.0.🎉

Handy links:

@ghost commented on GitHub (Mar 1, 2021): :tada:This issue was addressed in #9196, which has now been successfully released as `Windows Terminal Preview v1.7.572.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.7.572.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12055
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?