starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Polish Settings UI: Very annoying functionality #12062

New Issue
Closed
opened 2026-01-31 03:05:18 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:05:18 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 12, 2021).

  • Go to any profile -> Go to Appearance or Advanced tab -> Hit 'Apply': SUI automatically switches to the General tab (can be annoying if the user just wants to check out what a setting does)
  • Appearance -> Open 'Color scheme' dropdown -> Cannot dismiss the dropdown by clicking somewhere else
  • tooltips on radio buttons currently describe entire set of options. Need descriptions on each individual setting options.
    • Case in point: What does "uniform to fill" mean? On Profiles/Appearance. It's impossible to know what these enum values really mean.
    • we got rid of these
Originally created by @carlos-zamora on GitHub (Jan 12, 2021). - [x] Go to any profile -> Go to Appearance or Advanced tab -> Hit 'Apply': SUI automatically switches to the General tab (can be annoying if the user just wants to check out what a setting does) - [x] Appearance -> Open 'Color scheme' dropdown -> Cannot dismiss the dropdown by clicking somewhere else - Moved to Light-dismiss doesn't work on ComboBox in XAML Islands https://github.com/microsoft/microsoft-ui-xaml/issues/3961 - [ ] tooltips on radio buttons currently describe entire set of options. Need descriptions on each individual setting options. - [ ] Case in point: What does "uniform to fill" mean? On Profiles/Appearance. It's impossible to know what these enum values really mean. - [x] we got rid of these
claunia added the Issue-BugNeeds-Tag-FixProduct-TerminalPriority-2Area-SettingsUI labels 2026-01-31 03:05:19 +00:00
claunia commented 2026-01-31 03:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 13, 2021):

RE: the Profile pivot resetting

In a5a46af73, I'm doing something similar to how we want to fix this. We need to stash internal navigation state in the {page}NavigationState, and keep a singleton instance of each page's state in the MainPage. That way, we can have the Profiles page update the selected pivot within the NavigationState, and the next instance of Profiles will be able to look up that state.

@zadjii-msft commented on GitHub (Jan 13, 2021): RE: the Profile pivot resetting In a5a46af73, I'm doing something similar to how we want to fix this. We need to stash internal navigation state in the `{page}NavigationState`, and keep a singleton instance of each page's state in the `MainPage`. That way, we can have the `Profiles` page update the selected pivot within the NavigationState, and the _next_ instance of `Profiles` will be able to look up that state.
claunia commented 2026-01-31 03:05:20 +00:00
Author
Owner
Copy Link

@carlos-zamora commented on GitHub (Feb 12, 2021):

  • tooltips on radio buttons currently describe entire set of options. Need descriptions on each individual setting options.
    - [ ] Case in point: What does "uniform to fill" mean? On Profiles/Appearance. It's impossible to know what these enum values really mean.

So, this is a tough one. It looks like we can either do a single tooltip on the entire RadioButtons (note the plural) control, or on each individual RadioButton. Not both.

In general, we should make the choices and header as descriptive as possible to get around this issue. But that's not always possible, unfortunately.

I think we should go with the individual RadioButton descriptions and that way we can attach tooltips and automation properties to them. That's probably the cleanest way around this issue.

@carlos-zamora commented on GitHub (Feb 12, 2021): > - [ ] tooltips on radio buttons currently describe entire set of options. Need descriptions on each individual setting options. - [ ] Case in point: What does "uniform to fill" mean? On Profiles/Appearance. It's impossible to know what these enum values really mean. So, this is a tough one. It looks like we can either do a single tooltip on the entire `RadioButtons` (note the plural) control, or on each individual `RadioButton`. Not both. In general, we should make the choices and header as descriptive as possible to get around this issue. But that's not always possible, unfortunately. I think we should go with the individual `RadioButton` descriptions and that way we can attach tooltips and automation properties to them. That's probably the cleanest way around this issue.
claunia commented 2026-01-31 03:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Apr 11, 2022):

RE: tooltips on radio buttons: The RadioButtons were removed in 1.13, so now we need to add the tooltips to the entries in the dropdown.

@zadjii-msft commented on GitHub (Apr 11, 2022): RE: tooltips on radio buttons: The RadioButtons were removed in 1.13, so now we need to add the tooltips to the entries in the dropdown.
claunia commented 2026-01-31 03:05:20 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Aug 12, 2022):

Cannot dismiss the dropdown by clicking somewhere else

We got rid of almost all of these with Controlsv2. Except the default profile one...? (#13731)

@zadjii-msft commented on GitHub (Aug 12, 2022): > Cannot dismiss the dropdown by clicking somewhere else We got rid of almost all of these with Controlsv2. Except the default profile one...? (#13731)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Needs-Tag-Fix Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12062
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?