starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

WM_NCHITTEST returns HTCAPTION for client area and tabs #12071

New Issue
Open
opened 2026-01-31 03:05:38 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:05:38 +00:00
Owner
Copy Link

Originally created by @chaohershi on GitHub (Jan 15, 2021).

Description of the new feature/enhancement

Please consider placing the tabs into the client area instead of the title bar. Right now the tabs are in the correct place only with setting "showTabsInTitlebar": false,. This will cause problems with softwares that utilize the title bars.

Snipaste_2021-01-14_22-36-17
Default settings

Snipaste_2021-01-14_22-32-35
"showTabsInTitlebar": false,

Proposed technical implementation details (optional)

Take a look at Edge browser. Edge used to place everything in the title bar as well, but now it has been fixed.

Snipaste_2021-01-14_22-39-10

Originally created by @chaohershi on GitHub (Jan 15, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement Please consider placing the tabs into the client area instead of the title bar. Right now the tabs are in the correct place only with setting `"showTabsInTitlebar": false,`. This will cause problems with softwares that utilize the title bars. ![Snipaste_2021-01-14_22-36-17](https://user-images.githubusercontent.com/22566267/104679562-f25d3580-56bb-11eb-9901-41be78851300.png) Default settings ![Snipaste_2021-01-14_22-32-35](https://user-images.githubusercontent.com/22566267/104679573-f7ba8000-56bb-11eb-9fe5-9e96149a8d3f.png) `"showTabsInTitlebar": false,` <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) Take a look at Edge browser. Edge used to place everything in the title bar as well, but now it has been fixed. ![Snipaste_2021-01-14_22-39-10](https://user-images.githubusercontent.com/22566267/104679588-fee18e00-56bb-11eb-9e4d-5f5a4bf787c0.png) <!-- A clear and concise description of what you want to happen. -->
claunia commented 2026-01-31 03:05:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 15, 2021):

Well, that's certainly an interesting one. Thanks for finding this!

@zadjii-msft commented on GitHub (Jan 15, 2021): Well, that's certainly an interesting one. Thanks for finding this!
claunia commented 2026-01-31 03:05:39 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 17, 2021):

I've updated the title to more accurately represent what is happening.

Offending code is in NonClientIslandWindow.cpp, NonClientIslandWindow::_OnNcHitTest.

@DHowett commented on GitHub (Jan 17, 2021): I've updated the title to more accurately represent what is happening. Offending code is in `NonClientIslandWindow.cpp`, `NonClientIslandWindow::_OnNcHitTest`.
claunia commented 2026-01-31 03:05:39 +00:00
Author
Owner
Copy Link

@RamonUnch commented on GitHub (Feb 14, 2021):

I did encounter this problem while developping the AltDrag software.
It could be nice if it could be fixed. It forces me to treat Windows Terminal as a spetial case
I will infiorm my users that setting the "showTabsInTitlebar": false, fixes the problem.

@RamonUnch commented on GitHub (Feb 14, 2021): I did encounter this [problem ](https://github.com/RamonUnch/AltDrag/issues/11) while developping the [AltDrag](https://github.com/RamonUnch/AltDrag) software. It could be nice if it could be fixed. It forces me to treat Windows Terminal as a spetial case I will infiorm my users that setting the "showTabsInTitlebar": false, fixes the problem.
claunia commented 2026-01-31 03:05:39 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Sep 1, 2021):

Notes from a mail thread

What they're doing is not really supported (or at least not expected by any of this newer input magic code), and I think you only get the proper behavior if you're actual input rather than some random process calling WindowFromPoint + SendMessage(WM_NCHITTEST). I agree though you could probably make your implementation return "the right thing" even though the OS would never ask you for those regions.

So I'll probably need to roll a scratch test app to be able to investigate this fully.

@zadjii-msft commented on GitHub (Sep 1, 2021): Notes from a mail thread > What they're doing is not really supported (or at least not expected by any of this newer input magic code), and I think you only get the proper behavior if you're actual input rather than some random process calling `WindowFromPoint` + `SendMessage(WM_NCHITTEST)`. I agree though you could probably make your implementation return "the right thing" even though the OS would never ask you for those regions. So I'll probably need to roll a scratch test app to be able to investigate this fully.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Help Wanted Issue-Bug Priority-2 Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12071
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?