starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add startupActions to Settings UI #12078

New Issue
Open
opened 2026-01-31 03:05:50 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:05:50 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Jan 15, 2021).

Similar to #8755. These are settings that were added to v1.6 that need to be added to the Settings UI (or include reasoning for why not add them):

Setting Required? Notes
startupActions ✔ #8770

This may not be a comprehensive list. @cinnamon-msft is verifying if any are missing and will update this issue accordingly.
EDIT: verified that startupActions is the only one. Updating the issue title appropriately.

Resources:

Originally created by @carlos-zamora on GitHub (Jan 15, 2021). Similar to #8755. These are settings that were added to v1.6 that need to be added to the Settings UI (or include reasoning for why not add them): | Setting | Required? | Notes | |--|--|--| | `startupActions` | ✔ | #8770 | ~This may not be a comprehensive list. @cinnamon-msft is verifying if any are missing and will update this issue accordingly.~ EDIT: verified that `startupActions` is the only one. Updating the issue title appropriately. Resources: - [Documentation for adding a setting](https://github.com/microsoft/terminal/blob/main/doc/cascadia/AddASetting.md)
claunia added the Issue-TaskIn-PRProduct-TerminalArea-SettingsUI labels 2026-01-31 03:05:50 +00:00
claunia commented 2026-01-31 03:05:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 16, 2021):

This seems a little more advanced, and a late bring-in to get into the settings UI. For it to work properly, we would need to fully parse the commandline string inside the SUI just to make sure it's valid before we let the user commit it. I don't know if we should try to push to get this into 1.6.

@DHowett commented on GitHub (Jan 16, 2021): This seems a little more advanced, and a late bring-in to get into the settings UI. For it to work properly, we would need to fully parse the commandline string inside the SUI just to make sure it's valid before we let the user commit it. I don't know if we should try to push to get this into 1.6.
claunia commented 2026-01-31 03:05:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 16, 2021):

image

image

We would probably want the same behavior in the SUI as well, right? That's not 1.6 territory given how close we are to the snap date.

@DHowett commented on GitHub (Jan 16, 2021): ![image](https://user-images.githubusercontent.com/189190/104823217-7ec34180-57fd-11eb-9cc0-a576624df923.png) ![image](https://user-images.githubusercontent.com/189190/104823227-8a166d00-57fd-11eb-884b-1bb5ab20a640.png) We would probably want the same behavior in the SUI as well, right? That's _not_ 1.6 territory given how close we are to the snap date.
claunia commented 2026-01-31 03:05:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 16, 2021):

image

image

We would probably want the same behavior in the SUI as well, right? That's not 1.6 territory given how close we are to the snap date.

Yes. This is exactly what I was planning to do here 😄

@Don-Vito commented on GitHub (Jan 16, 2021): > > > ![image](https://user-images.githubusercontent.com/189190/104823217-7ec34180-57fd-11eb-9cc0-a576624df923.png) > > ![image](https://user-images.githubusercontent.com/189190/104823227-8a166d00-57fd-11eb-884b-1bb5ab20a640.png) > > We would probably want the same behavior in the SUI as well, right? That's _not_ 1.6 territory given how close we are to the snap date. Yes. This is exactly what I was planning to do here :smile:
claunia commented 2026-01-31 03:05:52 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 17, 2021):

@DHowett - I added the setting itself to UI, however there is an issue adding the parsed command line, as the parsing logic is a part of AppCommandlineArgs, which are is a part of TerminalApp, and thus Settings.Editor is not familiar with it.

Probably we should extract the AppCommandlineArgs into a separate lib and make Editor depend on it? WDYT?

@Don-Vito commented on GitHub (Jan 17, 2021): @DHowett - I added the setting itself to UI, however there is an issue adding the parsed command line, as the parsing logic is a part of AppCommandlineArgs, which are is a part of TerminalApp, and thus Settings.Editor is not familiar with it. Probably we should extract the AppCommandlineArgs into a separate lib and make Editor depend on it? WDYT?
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI In-PR Issue-Task Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12078
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?