Cannot find renamed profile #12188

Open
opened 2026-01-31 03:08:24 +00:00 by claunia · 0 comments
Owner

Originally created by @carlos-zamora on GitHub (Jan 25, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Environment

In a world where #8844 and #8837 are both merged.

Steps to reproduce

  1. Open Settings UI
  2. Navigate to a custom profile
  3. Rename the profile
  4. Invoke "discard changes" button

Expected behavior

After the changes are discarded, the same profile should still be selected. (If after #8844, the correct pivot should be selected too).

Actual behavior

The profile is not found, and "Startup" page is selected instead.

Additional Comments

Unless a guid is explicitly set for a profile (i.e. in-box profiles), the guid is automatically generated as a function of the profile name and source. Thus, renaming a profile results in changing the guid. Since we use the guid as a unique identifier to find the profile, we can no longer find that profile.

Originally created by @carlos-zamora on GitHub (Jan 25, 2021). Originally assigned to: @carlos-zamora on GitHub. # Environment In a world where #8844 and #8837 are both merged. # Steps to reproduce 1. Open Settings UI 2. Navigate to a custom profile 3. Rename the profile 4. Invoke "discard changes" button # Expected behavior After the changes are discarded, the same profile should still be selected. (If after #8844, the correct pivot should be selected too). # Actual behavior The profile is not found, and "Startup" page is selected instead. # Additional Comments Unless a guid is explicitly set for a profile (i.e. in-box profiles), the guid is automatically generated as a function of the profile name and source. Thus, renaming a profile results in changing the guid. Since we use the guid as a unique identifier to find the profile, we can no longer find that profile.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12188