starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Terminal 1.6 bites the dust in High Contrast mode #12190

New Issue
Open
opened 2026-01-31 03:08:27 +00:00 by claunia · 0 comments
claunia commented 2026-01-31 03:08:27 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Jan 25, 2021).

The original report had us dying immediately on launch. That stack looked like we'd die trying to initialize the command palette.

When I switched into HC mode, I got the following stack:

0:000> k
 # Child-SP          RetAddr               Call Site
00 000000d5`bd9cd380 00007ffe`5934b6b8     Microsoft_UI_Xaml!winrt::impl::consume_Microsoft_UI_Xaml_Controls_IRatingItemFontInfo<winrt::Microsoft::UI::Xaml::Controls::IRatingItemFontInfo>::Glyph+0x2b [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Microsoft.UI.Xaml.Controls.h @ 4990] 
01 000000d5`bd9cd3c0 00007ffe`590ef76b     Microsoft_UI_Xaml!ProgressRing::OnForegroundColorPropertyChanged+0x28 [C:\a\1\s\dev\ProgressRing\ProgressRing.cpp @ 82] 
02 (Inline Function) --------`--------     Microsoft_UI_Xaml!winrt::Windows::Foundation::TypedEventHandler<winrt::Windows::UI::Xaml::Controls::Control,winrt::Windows::UI::Xaml::Controls::FocusDisengagedEventArgs>::<lambda_85f2c4e39b149240244baf797ee82c3b>::operator()+0x1a [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Windows.Foundation.h @ 2510] 
03 000000d5`bd9cd400 00007ffe`cb88e7e7     Microsoft_UI_Xaml!winrt::impl::delegate<winrt::Windows::Foundation::TypedEventHandler<winrt::Windows::UI::Xaml::Controls::Control,winrt::Windows::UI::Xaml::Controls::FocusDisengagedEventArgs>,<lambda_85f2c4e39b149240244baf797ee82c3b> >::Invoke+0x3b [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Windows.Foundation.h @ 893] 
04 000000d5`bd9cd450 00007ffe`cb6f9e18     Windows_UI_Xaml!DirectUI::CEventSourceBase<DirectUI::IUntypedEventSource,Windows::UI::Xaml::IDependencyPropertyChangedCallback,Windows::UI::Xaml::IDependencyObject,Windows::UI::Xaml::IDependencyProperty>::Raise+0x14f [onecoreuap\windows\dxaml\xcp\dxaml\lib\JoltClasses.h @ 307] 
05 000000d5`bd9cd4c0 00007ffe`cb727972     Windows_UI_Xaml!DirectUI::DependencyObject::NotifyPropertyChanged+0x328 [onecoreuap\windows\dxaml\xcp\dxaml\lib\dependencyobject.cpp @ 2372] 
06 (Inline Function) --------`--------     Windows_UI_Xaml!DirectUI::DependencyObject::NotifyPropertyChanged+0x91 [onecoreuap\windows\dxaml\xcp\dxaml\lib\dependencyobject.cpp @ 2763] 
07 (Inline Function) --------`--------     Windows_UI_Xaml!CFxCallbacks::DependencyObject_NotifyPropertyChanged+0x91 [onecoreuap\windows\dxaml\xcp\dxaml\lib\fxcallbacks.cpp @ 698] 
08 (Inline Function) --------`--------     Windows_UI_Xaml!CDependencyObject::NotifyPropertyChanged+0xd1 [onecoreuap\windows\dxaml\xcp\core\core\elements\depends.cpp @ 2833] 
09 000000d5`bd9cd550 00007ffe`cb7280df     Windows_UI_Xaml!CDependencyObject::SetEffectiveValue+0x432 [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1698] 
0a 000000d5`bd9cd6a0 00007ffe`cb72461b     Windows_UI_Xaml!CDependencyObject::UpdateEffectiveValue+0xdf [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1979] 
0b 000000d5`bd9cd7c0 00007ffe`cb68047b     Windows_UI_Xaml!CDependencyObject::SetValue+0xab [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1740] 
0c 000000d5`bd9cd840 00007ffe`cb693d53     Windows_UI_Xaml!CDependencyObject::SetThemeResourceBinding+0x14b [onecoreuap\windows\dxaml\xcp\components\dependencyobject\theming.cpp @ 379]

Which looks like a crash in the Progress Ring. Yikes.

Originally created by @zadjii-msft on GitHub (Jan 25, 2021). The original report had us dying immediately on launch. That stack looked like we'd die trying to initialize the command palette. When I switched _into_ HC mode, I got the following stack: ``` 0:000> k # Child-SP RetAddr Call Site 00 000000d5`bd9cd380 00007ffe`5934b6b8 Microsoft_UI_Xaml!winrt::impl::consume_Microsoft_UI_Xaml_Controls_IRatingItemFontInfo<winrt::Microsoft::UI::Xaml::Controls::IRatingItemFontInfo>::Glyph+0x2b [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Microsoft.UI.Xaml.Controls.h @ 4990] 01 000000d5`bd9cd3c0 00007ffe`590ef76b Microsoft_UI_Xaml!ProgressRing::OnForegroundColorPropertyChanged+0x28 [C:\a\1\s\dev\ProgressRing\ProgressRing.cpp @ 82] 02 (Inline Function) --------`-------- Microsoft_UI_Xaml!winrt::Windows::Foundation::TypedEventHandler<winrt::Windows::UI::Xaml::Controls::Control,winrt::Windows::UI::Xaml::Controls::FocusDisengagedEventArgs>::<lambda_85f2c4e39b149240244baf797ee82c3b>::operator()+0x1a [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Windows.Foundation.h @ 2510] 03 000000d5`bd9cd400 00007ffe`cb88e7e7 Microsoft_UI_Xaml!winrt::impl::delegate<winrt::Windows::Foundation::TypedEventHandler<winrt::Windows::UI::Xaml::Controls::Control,winrt::Windows::UI::Xaml::Controls::FocusDisengagedEventArgs>,<lambda_85f2c4e39b149240244baf797ee82c3b> >::Invoke+0x3b [C:\a\1\s\BuildOutput\Intermediates\x64\Microsoft.UI.Xaml\obj\Generated Files\winrt\Windows.Foundation.h @ 893] 04 000000d5`bd9cd450 00007ffe`cb6f9e18 Windows_UI_Xaml!DirectUI::CEventSourceBase<DirectUI::IUntypedEventSource,Windows::UI::Xaml::IDependencyPropertyChangedCallback,Windows::UI::Xaml::IDependencyObject,Windows::UI::Xaml::IDependencyProperty>::Raise+0x14f [onecoreuap\windows\dxaml\xcp\dxaml\lib\JoltClasses.h @ 307] 05 000000d5`bd9cd4c0 00007ffe`cb727972 Windows_UI_Xaml!DirectUI::DependencyObject::NotifyPropertyChanged+0x328 [onecoreuap\windows\dxaml\xcp\dxaml\lib\dependencyobject.cpp @ 2372] 06 (Inline Function) --------`-------- Windows_UI_Xaml!DirectUI::DependencyObject::NotifyPropertyChanged+0x91 [onecoreuap\windows\dxaml\xcp\dxaml\lib\dependencyobject.cpp @ 2763] 07 (Inline Function) --------`-------- Windows_UI_Xaml!CFxCallbacks::DependencyObject_NotifyPropertyChanged+0x91 [onecoreuap\windows\dxaml\xcp\dxaml\lib\fxcallbacks.cpp @ 698] 08 (Inline Function) --------`-------- Windows_UI_Xaml!CDependencyObject::NotifyPropertyChanged+0xd1 [onecoreuap\windows\dxaml\xcp\core\core\elements\depends.cpp @ 2833] 09 000000d5`bd9cd550 00007ffe`cb7280df Windows_UI_Xaml!CDependencyObject::SetEffectiveValue+0x432 [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1698] 0a 000000d5`bd9cd6a0 00007ffe`cb72461b Windows_UI_Xaml!CDependencyObject::UpdateEffectiveValue+0xdf [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1979] 0b 000000d5`bd9cd7c0 00007ffe`cb68047b Windows_UI_Xaml!CDependencyObject::SetValue+0xab [onecoreuap\windows\dxaml\xcp\components\dependencyobject\propertysystem.cpp @ 1740] 0c 000000d5`bd9cd840 00007ffe`cb693d53 Windows_UI_Xaml!CDependencyObject::SetThemeResourceBinding+0x14b [onecoreuap\windows\dxaml\xcp\components\dependencyobject\theming.cpp @ 379] ``` Which looks like a crash in the Progress Ring. Yikes.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Needs-Triage Priority-0 Product-Terminal Resolution-Fix-Committed Severity-Blocking Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12190
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?