starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Can't exit new SUI with Focus mode enabled #12213

New Issue
Closed
opened 2026-01-31 03:09:13 +00:00 by claunia · 9 comments
claunia commented 2026-01-31 03:09:13 +00:00
Owner
Copy Link

Originally created by @33b5e5 on GitHub (Jan 26, 2021).

Environment

Win32NT 10.0.19042.0 Microsoft Windows NT 10.0.19042.0
Windows Terminal Dev from main at b50df20

Steps to reproduce

  1. Build Windows Terminal Dev from main. Head was at b50df20 when I built. Notably this includes the new Settings UI (SUI), as well as #8882 and #8885.

  2. Enable Focus mode on launch. I used "launchMode": "focus" in settings.json to do this.

  3. Launch Windows Terminal Dev. My config loads an Ubuntu WSL2 session in Focus mode by default.

  4. Open the new SUI with CTRL+SHIFT+S.

Expected behavior

There should be an easy way to exit SUI and return to your other pane(s).

Actual behavior

There's no way to exit SUI with the mouse. In Focus mode, the X to close the tab is hidden.

Most of the keybindings I tried to use here also don't work. Specifically, I tried these first in an attempt to exit SUI:

CTRL+SHIFT+P (for the switcher)
CTRL+SHIFT+W (close pane)
ALT+F4 (close window)

After a while, I figured out I could use CTRL+TAB to switch tabs. Then I can use CTRL+SHIFT+P to open the switcher, Toggle Focus Mode, and finally I can close SUI with the mouse.

After some discussion with @cinnamon_msft she suggested I file a bug here. See: https://twitter.com/33b5e5/status/1353929089137041408

Originally created by @33b5e5 on GitHub (Jan 26, 2021). # Environment ```text Win32NT 10.0.19042.0 Microsoft Windows NT 10.0.19042.0 Windows Terminal Dev from main at b50df20 ``` # Steps to reproduce 1) Build Windows Terminal Dev from main. Head was at b50df20 when I built. Notably this includes the new Settings UI (SUI), as well as #8882 and #8885. 2) Enable Focus mode on launch. I used `"launchMode": "focus"` in settings.json to do this. 3) Launch Windows Terminal Dev. My config loads an Ubuntu WSL2 session in Focus mode by default. 4) Open the new SUI with CTRL+SHIFT+S. # Expected behavior There should be an easy way to exit SUI and return to your other pane(s). # Actual behavior There's no way to exit SUI with the mouse. In Focus mode, the X to close the tab is hidden. Most of the keybindings I tried to use here also don't work. Specifically, I tried these first in an attempt to exit SUI: CTRL+SHIFT+P (for the switcher) CTRL+SHIFT+W (close pane) ALT+F4 (close window) After a while, I figured out I could use CTRL+TAB to switch tabs. Then I can use CTRL+SHIFT+P to open the switcher, Toggle Focus Mode, and finally I can close SUI with the mouse. After some discussion with @cinnamon_msft she suggested I file a bug here. See: https://twitter.com/33b5e5/status/1353929089137041408
claunia added the Resolution-Duplicate label 2026-01-31 03:09:13 +00:00
claunia commented 2026-01-31 03:09:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 26, 2021):

This is fixed as of #8903

@DHowett commented on GitHub (Jan 26, 2021): This is fixed as of #8903
claunia commented 2026-01-31 03:09:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 26, 2021):

/dup #8903 😄 thanks for filing!

@DHowett commented on GitHub (Jan 26, 2021): /dup #8903 :smile: thanks for filing!
claunia commented 2026-01-31 03:09:14 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Jan 26, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Jan 26, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 03:09:15 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 26, 2021):

@DHowett - ctrl+w should work as well. Quite sure I tested it.

@Don-Vito commented on GitHub (Jan 26, 2021): @DHowett - ctrl+w should work as well. Quite sure I tested it.
claunia commented 2026-01-31 03:09:15 +00:00
Author
Owner
Copy Link

@33b5e5 commented on GitHub (Jan 26, 2021):

For what it's worth, CTRL+W does not close the SUI for me (from b50df20). I will pull in the latest and try again.

@33b5e5 commented on GitHub (Jan 26, 2021): For what it's worth, CTRL+W does not close the SUI for me (from b50df20). I will pull in the latest and try again.
claunia commented 2026-01-31 03:09:15 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jan 26, 2021):

@don-vito Ages upon ages ago (version 0.3), we changed the default bindings from ctrl+t->newTab and ctrl+w->closeTab to ctrl+shift+t->newTab and ctrl+shift+w->close*Pane*. Have you really been carrying around settings from 0.2? 😄

@DHowett commented on GitHub (Jan 26, 2021): @don-vito Ages upon ages ago (version 0.3), we changed the default bindings from `ctrl+t->newTab` and `ctrl+w->closeTab` to `ctrl+shift+t->newTab` and `ctrl+shift+w->close*Pane*`. Have you really been carrying around settings from 0.2? :smile:
claunia commented 2026-01-31 03:09:16 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 26, 2021):

@DHowett - hmm... I don't remember configuring this.. but I think I started using terminal around 0.4..

@Don-Vito commented on GitHub (Jan 26, 2021): @DHowett - hmm... I don't remember configuring this.. but I think I started using terminal around 0.4..
claunia commented 2026-01-31 03:09:16 +00:00
Author
Owner
Copy Link

@33b5e5 commented on GitHub (Jan 26, 2021):

Okay, after pulling in the latest, CTRL+SHIFT+W does work to close the SUI. CTRL+W does not work. I would love to see CTRL+SHIFT+P work here as well, because that would allow you to close the pane OR disable Focus mode (or switch panes, or whatever). Thanks for listening.

@33b5e5 commented on GitHub (Jan 26, 2021): Okay, after pulling in the latest, CTRL+SHIFT+W does work to close the SUI. CTRL+W does not work. I would love to see CTRL+SHIFT+P work here as well, because that would allow you to close the pane OR disable Focus mode (or switch panes, or whatever). Thanks for listening.
claunia commented 2026-01-31 03:09:17 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 26, 2021):

@33b5e5 - yeah CTRL+W works only for me, because it is a binding to a closeTab which appears to be not bound by default.

Regarding Command Palette, I am worried what happens if the user clicks on action like "Find" which is not supported in the settings UI.

@Don-Vito commented on GitHub (Jan 26, 2021): @33b5e5 - yeah CTRL+W works only for me, because it is a binding to a `closeTab` which appears to be not bound by default. Regarding Command Palette, I am worried what happens if the user clicks on action like "Find" which is not supported in the settings UI.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?