starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-24 16:05:21 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

De-underline hyperlink on hover-out, even if not focused #12239

New Issue
Closed
opened 2026-01-31 03:09:59 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 03:09:59 +00:00
Owner
Copy Link

Originally created by @PhMajerus on GitHub (Jan 28, 2021).

Testing WT Preview 1.6.10272.0.

Ok, now that we got the underline hyperlink on hover, even when not focused (#8475, #8615)... can we have them always de-underline on mouseout as well? You know, for consistency? 😉

Right now, the underline gets removed only when another hyperlink gets underlined, not when the mouse moves away from it.

Originally created by @PhMajerus on GitHub (Jan 28, 2021). Testing WT Preview 1.6.10272.0. Ok, now that we got the underline hyperlink on hover, even when not focused (#8475, #8615)... can we have them always de-underline on mouseout as well? You know, for consistency? 😉 Right now, the underline gets removed only when another hyperlink gets underlined, not when the mouse moves away from it.
claunia commented 2026-01-31 03:10:01 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Jan 29, 2021):

YUP we should do that, good catch.

@zadjii-msft commented on GitHub (Jan 29, 2021): YUP we should do that, good catch.
claunia commented 2026-01-31 03:10:02 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Jan 30, 2021):

@zadjii-msft - I am wondering why we chose to implement #8475 rather than #6459. Won't it make the behavior more consistent and prevent issues like this one?

And it is also a one liner 😄

@Don-Vito commented on GitHub (Jan 30, 2021): @zadjii-msft - I am wondering why we chose to implement #8475 rather than #6459. Won't it make the behavior more consistent and prevent issues like this one? And it is also a one liner :smile:
claunia commented 2026-01-31 03:10:03 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 4, 2021):

@don-vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined when the whole window is out of focus?

FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. 😄

@DHowett commented on GitHub (Feb 4, 2021): @don-vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined _when the whole window is out of focus?_ FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. :smile:
claunia commented 2026-01-31 03:10:03 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 4, 2021):

@don-vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined when the whole window is out of focus?

FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. 😄

@DHowett - what you mention regarding the entire window losing focus is another aspect that requires a fix, but it is not related directly to this report. The problem here is due to a gap in the implementation of mouse hover over unfocused pane. And the fix here will be different from the fix that will be required for window losing focus.

My suggestion for FFM is replacing the code that introduced this gap. I was not aware though that FFM is so controversial 😊

@Don-Vito commented on GitHub (Feb 4, 2021): > @don-vito curious though -- would implementing focus-follows-mouse fix the issue where hyperlinks get underlined and never get un-underlined _when the whole window is out of focus?_ > > FFM is very controversial. I don't think it's the solution to any problems except the problem some users perceive where we do not have FFM. :smile: @DHowett - what you mention regarding the entire window losing focus is another aspect that requires a fix, but it is not related directly to this report. The problem here is due to a gap in the implementation of mouse hover over unfocused pane. And the fix here will be different from the fix that will be required for window losing focus. My suggestion for FFM is replacing the code that introduced this gap. I was not aware though that FFM is so controversial :blush:
claunia commented 2026-01-31 03:10:03 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 4, 2021):

I am handing this separately from FFM.

@Don-Vito commented on GitHub (Feb 4, 2021): I am handing this separately from FFM.
claunia commented 2026-01-31 03:10:04 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 11, 2021):

:tada:This issue was addressed in #9039, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.🎉

Handy links:

@ghost commented on GitHub (Feb 11, 2021): :tada:This issue was addressed in #9039, which has now been successfully released as `Windows Terminal Preview v1.6.10412.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10412.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-TerminalControl good first issue Help Wanted Issue-Bug Needs-Tag-Fix Priority-3 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12239
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?