starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Crash when closing a tab with multiple splits from the tab context menu #12386

New Issue
Closed
opened 2026-01-31 03:14:18 +00:00 by claunia · 1 comment
claunia commented 2026-01-31 03:14:18 +00:00
Owner
Copy Link

Originally created by @zadjii-msft on GitHub (Feb 3, 2021).

Originally assigned to: @PankajBhojwani on GitHub.

  1. open two tabs
  2. in the first, make two panes
  3. try to close the tab from the right-click "Close Tab" option.
  4. Experience exception:
    TerminalApp.dll!std::_Throw_bad_optional_access() Line 54   C++
    TerminalApp.dll!std::optional<unsigned short>::value() Line 379 C++
    TerminalApp.dll!Pane::Id() Line 1558    C++
>   TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable$_ResumeCoro$1 const &,winrt::Windows::Foundation::IInspectable$_ResumeCoro$1 const &>() Line 699 C++
    TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable$_InitCoro$2 const &,winrt::Windows::Foundation::IInspectable$_InitCoro$2 const &>() Line 685 C++
    TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable const &,winrt::Windows::Foundation::IInspectable const &>(const winrt::Windows::Foundation::IInspectable &) Line 707 C++
    TerminalApp.dll!winrt::impl::delegate<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>,<lambda_1a1e553ee07ffde1f0ed98f661a0b933>>::Invoke(void * sender, void * args) Line 883    C++
    TerminalApp.dll!winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>::operator()(const winrt::Windows::Foundation::IInspectable & sender, const winrt::Windows::Foundation::IInspectable & args) Line 2500    C++
    TerminalApp.dll!winrt::impl::invoke<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>,std::nullptr_t,std::nullptr_t>(const winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable> & delegate, void * const & <args_0>, void * const & <args_1>) Line 5567  C++
    TerminalApp.dll!winrt::event<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>>::operator()<std::nullptr_t,std::nullptr_t>(void * const & <args_0>, void * const & <args_1>) Line 5702 C++
    TerminalApp.dll!Pane::Close() Line 424  C++
    TerminalApp.dll!<lambda_4e44f426db787ef722ec55bc42fe1f5e>::operator()<winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::RoutedEventArgs const &>(const winrt::Windows::Foundation::IInspectable & __formal, const winrt::Windows::UI::Xaml::RoutedEventArgs & __formal) Line 754   C++
    TerminalApp.dll!winrt::impl::delegate<winrt::Windows::UI::Xaml::RoutedEventHandler,<lambda_4e44f426db787ef722ec55bc42fe1f5e>>::Invoke(void * sender, void * e) Line 4671    C++
    Windows.UI.Xaml.dll!DirectUI::CRoutedEventSourceBase<DirectUI::IUntypedEventSource,Windows::UI::Xaml::IRoutedEventHandler,IInspectable,Windows::UI::Xaml::IRoutedEventArgs>::Raise(IInspectable * pSource, Windows::UI::Xaml::IRoutedEventArgs * pArgs) Line 1041   C++
    Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::Invoke() Line 208 C++
    Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::PerformPointerUpAction() Line 186 C++
    Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::OnPointerReleased(Windows::UI::Xaml::Input::IPointerRoutedEventArgs * pArgs) Line 146 C++
    Windows.UI.Xaml.dll!DirectUI::ControlGenerated::OnPointerReleasedProtected(Windows::UI::Xaml::Input::IPointerRoutedEventArgs * pE) Line 1518    C++
    Windows.UI.Xaml.dll!DirectUI::Control::FireEvent(KnownEventIndex nDelegate, DirectUI::DependencyObject * pSender, IInspectable * pArgs) Line 259    C++

Which has a root cause here:

        pane->Closed([weakThis, weakPane](auto&& /*s*/, auto && /*e*/) -> winrt::fire_and_forget {
        ...
                        if (*i == pane->Id()) // <---------------- This line right here, throws. The pane's ID might be nullopt!!
                        {
                            tab->_mruPanes.erase(i);
                            break;
                        }

Turn out, the pane's ID was nullopt. So when we tried to compare the mru pane ID to the pane's ID, it tried to compare against the value of the optional, which threw.

WEIRDLY, if you add a closeTab action, and try doing this from the command palette, it doesn't repro. It also doesn't repro if you just close the tab by middle clicking it.

This is not the same bug as the "menu flyout crash" - I was very sure to not hover over the nested menu entry when doing this.

Originally created by @zadjii-msft on GitHub (Feb 3, 2021). Originally assigned to: @PankajBhojwani on GitHub. 1. open two tabs 2. in the first, make two panes 3. try to close the tab from the right-click "Close Tab" option. 4. Experience exception: ``` TerminalApp.dll!std::_Throw_bad_optional_access() Line 54 C++ TerminalApp.dll!std::optional<unsigned short>::value() Line 379 C++ TerminalApp.dll!Pane::Id() Line 1558 C++ > TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable$_ResumeCoro$1 const &,winrt::Windows::Foundation::IInspectable$_ResumeCoro$1 const &>() Line 699 C++ TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable$_InitCoro$2 const &,winrt::Windows::Foundation::IInspectable$_InitCoro$2 const &>() Line 685 C++ TerminalApp.dll!<lambda_1a1e553ee07ffde1f0ed98f661a0b933>::operator()<winrt::Windows::Foundation::IInspectable const &,winrt::Windows::Foundation::IInspectable const &>(const winrt::Windows::Foundation::IInspectable &) Line 707 C++ TerminalApp.dll!winrt::impl::delegate<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>,<lambda_1a1e553ee07ffde1f0ed98f661a0b933>>::Invoke(void * sender, void * args) Line 883 C++ TerminalApp.dll!winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>::operator()(const winrt::Windows::Foundation::IInspectable & sender, const winrt::Windows::Foundation::IInspectable & args) Line 2500 C++ TerminalApp.dll!winrt::impl::invoke<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>,std::nullptr_t,std::nullptr_t>(const winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable> & delegate, void * const & <args_0>, void * const & <args_1>) Line 5567 C++ TerminalApp.dll!winrt::event<winrt::Windows::Foundation::EventHandler<winrt::Windows::Foundation::IInspectable>>::operator()<std::nullptr_t,std::nullptr_t>(void * const & <args_0>, void * const & <args_1>) Line 5702 C++ TerminalApp.dll!Pane::Close() Line 424 C++ TerminalApp.dll!<lambda_4e44f426db787ef722ec55bc42fe1f5e>::operator()<winrt::Windows::Foundation::IInspectable const &,winrt::Windows::UI::Xaml::RoutedEventArgs const &>(const winrt::Windows::Foundation::IInspectable & __formal, const winrt::Windows::UI::Xaml::RoutedEventArgs & __formal) Line 754 C++ TerminalApp.dll!winrt::impl::delegate<winrt::Windows::UI::Xaml::RoutedEventHandler,<lambda_4e44f426db787ef722ec55bc42fe1f5e>>::Invoke(void * sender, void * e) Line 4671 C++ Windows.UI.Xaml.dll!DirectUI::CRoutedEventSourceBase<DirectUI::IUntypedEventSource,Windows::UI::Xaml::IRoutedEventHandler,IInspectable,Windows::UI::Xaml::IRoutedEventArgs>::Raise(IInspectable * pSource, Windows::UI::Xaml::IRoutedEventArgs * pArgs) Line 1041 C++ Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::Invoke() Line 208 C++ Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::PerformPointerUpAction() Line 186 C++ Windows.UI.Xaml.dll!DirectUI::MenuFlyoutItem::OnPointerReleased(Windows::UI::Xaml::Input::IPointerRoutedEventArgs * pArgs) Line 146 C++ Windows.UI.Xaml.dll!DirectUI::ControlGenerated::OnPointerReleasedProtected(Windows::UI::Xaml::Input::IPointerRoutedEventArgs * pE) Line 1518 C++ Windows.UI.Xaml.dll!DirectUI::Control::FireEvent(KnownEventIndex nDelegate, DirectUI::DependencyObject * pSender, IInspectable * pArgs) Line 259 C++ ``` Which has a root cause here: ```c++ pane->Closed([weakThis, weakPane](auto&& /*s*/, auto && /*e*/) -> winrt::fire_and_forget { ... if (*i == pane->Id()) // <---------------- This line right here, throws. The pane's ID might be nullopt!! { tab->_mruPanes.erase(i); break; } ``` Turn out, the pane's ID was `nullopt`. So when we tried to compare the mru pane ID to the pane's ID, it tried to compare against the value of the optional, which threw. WEIRDLY, if you add a `closeTab` action, and try doing this from the command palette, it _doesn't_ repro. It also doesn't repro if you just close the tab by middle clicking it. This is _not_ the same bug as the "menu flyout crash" - I was very sure to not hover over the nested menu entry when doing this.
claunia commented 2026-01-31 03:14:19 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 11, 2021):

:tada:This issue was addressed in #9028, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.🎉

Handy links:

@ghost commented on GitHub (Feb 11, 2021): :tada:This issue was addressed in #9028, which has now been successfully released as `Windows Terminal Preview v1.6.10412.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10412.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-UserInterface Issue-Bug Priority-1 Product-Terminal Resolution-Fix-Committed Severity-Crash
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12386
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?