starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Adjust the link line for all exe/dlls to prefer onecore_apiset #1240

New Issue
Closed
opened 2026-01-30 22:19:59 +00:00 by claunia · 2 comments
claunia commented 2026-01-30 22:19:59 +00:00
Owner
Copy Link

Originally created by @DHowett-MSFT on GitHub (May 21, 2019).

dwmapi, winmm, shlwapi are all in different forms on OneCore editions than on desktop, so linking those libs explicitly (instead of via umbrella) is probably not good.

pathcch isn't there at all... so maybe the API we're using through that is available in a different way?

Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/913

Originally created by @DHowett-MSFT on GitHub (May 21, 2019). dwmapi, winmm, shlwapi are all in different forms on OneCore editions than on desktop, so linking those libs explicitly (instead of via umbrella) is probably not good. pathcch isn't there at all... so maybe the API we're using through that is available in a different way? _Originally posted by @miniksa in https://github.com/microsoft/terminal/pull/913_
claunia commented 2026-01-30 22:20:00 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 22, 2019):

Problem description: common.build.exe.or.dll.props specifies the link line, but it is included before common.build.post.props. common.build.post.props includes the toplevel C++ compilation rules which prepend the default libraries to the link line.

It is necessary to do a few things:

  • move all PropertyGroups into .props files
  • move all ItemDefinitionGroups into .targets files
  • rename ...post.props to ...post.targets, as it is a targets file that includes targets files.
  • move all .targets files that define ItemDefinitionGroups that change compilation or linking behavior to after ...post.props

I think it will benefit us to get rid of common.build.exe.props and common.build.dll.props and actually just rely on PropertyGroup.ConfigurationType being Application or DynamicLibrary to include additional rules in post.targets. They're not different enough to warrant saving one property definition that belongs in the project.

A typical project would then become:

Import common.build.props
All ClCompile Entries
All ClInclude Entries
Properties: Name, GUID, Keyword, *ProjectType*
Import common.build.targets
@DHowett-MSFT commented on GitHub (May 22, 2019): Problem description: `common.build.exe.or.dll.props` specifies the link line, but it is included before `common.build.post.props`. `common.build.post.props` includes the toplevel C++ compilation rules which _prepend_ the default libraries to the link line. It is necessary to do a few things: * move all `PropertyGroup`s into `.props` files * move all `ItemDefinitionGroup`s into `.targets` files * rename `...post.props` to `...post.targets`, as it is a targets file that includes targets files. * move all `.targets` files that define `ItemDefinitionGroup`s that change compilation or linking behavior to after `...post.props` I think it will benefit us to get rid of `common.build.exe.props` and `common.build.dll.props` and _actually just rely on `PropertyGroup.ConfigurationType` being `Application` or `DynamicLibrary`_ to include additional rules in `post.targets`. They're not different enough to warrant saving one property definition that belongs in the project. A typical project would then become: ``` Import common.build.props All ClCompile Entries All ClInclude Entries Properties: Name, GUID, Keyword, *ProjectType* Import common.build.targets ```
claunia commented 2026-01-30 22:20:00 +00:00
Author
Owner
Copy Link

@miniksa commented on GitHub (May 22, 2019):

I am OK with this.

@miniksa commented on GitHub (May 22, 2019): I am OK with this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CodeHealth Issue-Task Needs-Tag-Fix Product-Conhost Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?