starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 16:34:42 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

SettingsUI removes "disabledProfileSources" #12403

New Issue
Closed
opened 2026-01-31 03:14:46 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:14:46 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (Feb 4, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Using the SettingsUI removes my "disabledProfileSources" customization. I wish it didn't do that. Perhaps it clobbers other customizations too.

Originally created by @vefatica on GitHub (Feb 4, 2021). Originally assigned to: @carlos-zamora on GitHub. Using the SettingsUI removes my "disabledProfileSources" customization. I wish it didn't do that. Perhaps it clobbers other customizations too.
claunia commented 2026-01-31 03:14:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 4, 2021):

Huh. That's no good.

@zadjii-msft commented on GitHub (Feb 4, 2021): Huh. That's no good.
claunia commented 2026-01-31 03:14:48 +00:00
Author
Owner
Copy Link

@WSLUser commented on GitHub (Feb 4, 2021):

Perhaps it clobbers other customizations too

It absolutely does. It's all part of https://github.com/microsoft/terminal/issues/8991. It might be easier to prevent removals than to have parity though.

@WSLUser commented on GitHub (Feb 4, 2021): > Perhaps it clobbers other customizations too It absolutely does. It's all part of https://github.com/microsoft/terminal/issues/8991. It might be easier to prevent removals than to have parity though.
claunia commented 2026-01-31 03:14:48 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 4, 2021):

Woah now - removes a setting != reformats the file. In general, the file will be reformatted, yes. It should NOT, in any circumstances, be removing settings that are otherwise set. Unless the user modifies a setting, it should remain untouched (or in the case of floats, equivalent).

If the setting is getting lost, then there's a good chance that it's being bound incorrectly. That's my theory at least.

@zadjii-msft commented on GitHub (Feb 4, 2021): Woah now - removes a setting != reformats the file. In general, the file will be reformatted, yes. It should NOT, in any circumstances, be removing settings that are otherwise set. Unless the user modifies a setting, it should remain untouched (or in the case of floats, equivalent). If the setting is getting lost, then there's a good chance that it's being bound incorrectly. That's my theory at least.
claunia commented 2026-01-31 03:14:48 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Feb 4, 2021):

I read #8991 when it was new but didn't appreciate what @WSLUser was saying until this issue arose. The new format is shocking at first but completely rational and consistent across the whole file. I'll have no problem getting used to it. I miss the comments that gave hints about the use of the file's major sections; "keybindings" is the only section that still has such/any comments. Hopefully, someday soon, I won't have to look at the file at all.

@vefatica commented on GitHub (Feb 4, 2021): I read #8991 when it was new but didn't appreciate what @WSLUser was saying until this issue arose. The new format is shocking at first but completely rational and consistent across the whole file. I'll have no problem getting used to it. I miss the comments that gave hints about the use of the file's major sections; "keybindings" is the only section that still has such/any comments. Hopefully, someday soon, I won't have to look at the file at all.
claunia commented 2026-01-31 03:14:49 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 11, 2021):

:tada:This issue was addressed in #9038, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.🎉

Handy links:

@ghost commented on GitHub (Feb 11, 2021): :tada:This issue was addressed in #9038, which has now been successfully released as `Windows Terminal Preview v1.6.10412.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10412.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Bug Needs-Triage Priority-1 Product-Terminal Resolution-Fix-Committed Severity-DataLoss
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12403
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?