starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-09-25 00:15:10 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Hitting ALT-F4 in the settings UI doesn't close WT #12406

New Issue
Closed
opened 2026-01-31 03:14:49 +00:00 by claunia · 7 comments
claunia commented 2026-01-31 03:14:49 +00:00
Owner
Copy Link

Originally created by @sylveon on GitHub (Feb 5, 2021).

Environment

Windows build number: 10.0.19042.0
Windows Terminal version: 1.6.10272.0

Steps to reproduce

  1. Open the settings UI
  2. Hit ALT-F4

Expected behavior

The window closes, prompting the user to close all tabs if there are more than 1

Actual behavior

Nothing happens

More details

This is seemingly because the current method to catch ALT-F4 uses a keyboard accelerator on the Terminal control itself (which doesn't have keyboard focus when the settings are opened, this is indeed reproducible when other XAML elements have the keyboard focus in a terminal tab).

A more reliable method would be to use code like the following before calling the XAML island's PreTranslateMessage:

// prevent XAML islands from capturing ALT-F4 because of
// https://github.com/microsoft/microsoft-ui-xaml/issues/2408
if (msg.message == WM_SYSKEYDOWN && msg.wParam == VK_F4)
{
	SendMessage(GetAncestor(msg.hwnd, GA_ROOT), msg.message, msg.wParam, msg.lParam);
	return FALSE;
}

and then in the hosting window, handle WM_CLOSE normally, transmitting the close request to the XAML code.

I can make a PR for this, provided that always binding ALT-F4 to close window is the desired path (because the code above will prevent assignment of a custom keybinding to ALT-F4)

Originally created by @sylveon on GitHub (Feb 5, 2021). # Environment ```none Windows build number: 10.0.19042.0 Windows Terminal version: 1.6.10272.0 ``` # Steps to reproduce 1. Open the settings UI 2. Hit ALT-F4 # Expected behavior The window closes, prompting the user to close all tabs if there are more than 1 # Actual behavior Nothing happens # More details This is seemingly because the current method to catch ALT-F4 uses a keyboard accelerator on the Terminal control itself (which doesn't have keyboard focus when the settings are opened, this is indeed reproducible when other XAML elements have the keyboard focus in a terminal tab). A more reliable method would be to use code like the following before calling the XAML island's `PreTranslateMessage`: ```cpp // prevent XAML islands from capturing ALT-F4 because of // https://github.com/microsoft/microsoft-ui-xaml/issues/2408 if (msg.message == WM_SYSKEYDOWN && msg.wParam == VK_F4) { SendMessage(GetAncestor(msg.hwnd, GA_ROOT), msg.message, msg.wParam, msg.lParam); return FALSE; } ``` and then in the hosting window, handle WM_CLOSE normally, transmitting the close request to the XAML code. I can make a PR for this, provided that always binding ALT-F4 to close window is the desired path (because the code above will prevent assignment of a custom keybinding to ALT-F4)
claunia added the Resolution-Duplicate label 2026-01-31 03:14:49 +00:00
claunia commented 2026-01-31 03:14:50 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 7, 2021):

@sylveon - the current mechanism of allowing actions in settings UI is implemented in TerminalPage::_SUIPreviewKeyDownHandler where we decide what actions to dispatch:

if (actionAndArgs && (actionAndArgs.Action() == ShortcutAction::CloseTab || actionAndArgs.Action() == ShortcutAction::NextTab || actionAndArgs.Action() == ShortcutAction::PrevTab || actionAndArgs.Action() == ShortcutAction::ClosePane))
{
    _actionDispatch->DoAction(actionAndArgs);
    e.Handled(true);
}

The immediate workaround is to add ShortcutAction::CloseWindow to the list of the conditions.

The discussion about better solution is here: https://github.com/microsoft/terminal/issues/8767
Consider moving the discussion there.

@Don-Vito commented on GitHub (Feb 7, 2021): @sylveon - the current mechanism of allowing actions in settings UI is implemented in `TerminalPage::_SUIPreviewKeyDownHandler` where we decide what actions to dispatch: ``` if (actionAndArgs && (actionAndArgs.Action() == ShortcutAction::CloseTab || actionAndArgs.Action() == ShortcutAction::NextTab || actionAndArgs.Action() == ShortcutAction::PrevTab || actionAndArgs.Action() == ShortcutAction::ClosePane)) { _actionDispatch->DoAction(actionAndArgs); e.Handled(true); } ``` The immediate workaround is to add `ShortcutAction::CloseWindow` to the list of the conditions. The discussion about better solution is here: https://github.com/microsoft/terminal/issues/8767 Consider moving the discussion there.
claunia commented 2026-01-31 03:14:50 +00:00
Author
Owner
Copy Link

@sylveon commented on GitHub (Feb 7, 2021):

There are cases where ALT-F4 isn't triggered besides the settings UI - for example if you click on the current active tab, the terminal loses focus (as shown by the cursor not flashing anymore) and ALT-F4 stops working too.

@sylveon commented on GitHub (Feb 7, 2021): There are cases where ALT-F4 isn't triggered besides the settings UI - for example if you click on the current active tab, the terminal loses focus (as shown by the cursor not flashing anymore) and ALT-F4 stops working too.
claunia commented 2026-01-31 03:14:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 7, 2021):

There are cases where ALT-F4 isn't triggered besides the settings UI - for example if you click on the current active tab, the terminal loses focus (as shown by the cursor not flashing anymore) and ALT-F4 stops working too.

You are correct. This happens because the TabView is getting focus on click, introducing tons of bugs other than keybinding not working: e.g., you cannot type and you have no clue why 😄. We can potentially solve the keybindings on TabView by adding KeyHandler to the TabView as well.

I am not against finding a more robust way of doing it on the process level, but not sure if it worth it without preserving custom bindings. Of course this is just my humble opinion 😊

@Don-Vito commented on GitHub (Feb 7, 2021): > > > There are cases where ALT-F4 isn't triggered besides the settings UI - for example if you click on the current active tab, the terminal loses focus (as shown by the cursor not flashing anymore) and ALT-F4 stops working too. You are correct. This happens because the TabView is getting focus on click, introducing tons of bugs other than keybinding not working: e.g., you cannot type and you have no clue why :smile:. We can potentially solve the keybindings on TabView by adding KeyHandler to the TabView as well. I am not against finding a more robust way of doing it on the process level, but not sure if it worth it without preserving custom bindings. Of course this is just my humble opinion :blush:
claunia commented 2026-01-31 03:14:51 +00:00
Author
Owner
Copy Link

@sylveon commented on GitHub (Feb 7, 2021):

In my opinion ALT-F4 shouldn't be something custom, it's a shortcut that's practically system-wide so I would be okay with hardcoding it - the code I've put in the original comment works reliably for me.

@sylveon commented on GitHub (Feb 7, 2021): In my opinion ALT-F4 shouldn't be something custom, it's a shortcut that's practically system-wide so I would be okay with hardcoding it - the code I've put in the original comment works reliably for me.
claunia commented 2026-01-31 03:14:51 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 7, 2021):

In my opinion ALT-F4 shouldn't be something custom, it's a shortcut that's practically system-wide so I would be okay with hardcoding it - the code I've put in the original comment works reliably for me.

I do not disagree - I like your idea 😊

Just raising some concerns, because currently CloseWindow command is handled as regular command. Which means it can be bound to keys, and its keys theoretically should be unboundable.

@Don-Vito commented on GitHub (Feb 7, 2021): > > > In my opinion ALT-F4 shouldn't be something custom, it's a shortcut that's practically system-wide so I would be okay with hardcoding it - the code I've put in the original comment works reliably for me. I do not disagree - I like your idea :blush: Just raising some concerns, because currently CloseWindow command is handled as regular command. Which means it can be bound to keys, and its keys theoretically should be unboundable.
claunia commented 2026-01-31 03:14:51 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 11, 2021):

You know, I think at the end of the day this is just #8767. closeWindow is another one of those actions that's viable in the settings UI. Moving the focus into the tab itself isn't something that really should be possible at all, but that's a lot trickier. For that you're looking at #6680, #3609.

/dup #8767

Thanks!

@zadjii-msft commented on GitHub (Feb 11, 2021): You know, I think at the end of the day this is just #8767. `closeWindow` is another one of those actions that's viable in the settings UI. Moving the focus into the tab itself isn't something that really should be possible at all, but that's a lot trickier. For that you're looking at #6680, #3609. /dup #8767 Thanks!
claunia commented 2026-01-31 03:14:51 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 11, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 11, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12406
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?