starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Binding enter to copy breaks Command Palette #12414

New Issue
Closed
opened 2026-01-31 03:15:07 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:15:07 +00:00
Owner
Copy Link

Originally created by @LuanVSO on GitHub (Feb 5, 2021).

Originally assigned to: @Don-Vito on GitHub.

Environment

Windows build number: 10.0.19042.789
Windows Terminal version (if applicable):1.6.10272.0
Any other software?

Steps to reproduce

  1. put this in actions:
{"command": {"action": "copy","singleLine": false},"keys": "enter"}
  1. try to use cmdpallet

Expected behavior

when enter is pressed in cmdpall the highlighted action is executed

Actual behavior

nothing is executed

Observations

regression from 1.5

Originally created by @LuanVSO on GitHub (Feb 5, 2021). Originally assigned to: @Don-Vito on GitHub. <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to secure@microsoft.com, referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```none Windows build number: 10.0.19042.789 Windows Terminal version (if applicable):1.6.10272.0 Any other software? ``` # Steps to reproduce <!-- A description of how to trigger this bug. --> 1. put this in actions: ```json {"command": {"action": "copy","singleLine": false},"keys": "enter"} ``` 2. try to use cmdpallet # Expected behavior <!-- A description of what you're expecting, possibly containing screenshots or reference material. --> when enter is pressed in cmdpall the highlighted action is executed # Actual behavior nothing is executed # Observations regression from 1.5
claunia commented 2026-01-31 03:15:08 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 5, 2021):

@LuanVSO - this is absolutely a regression.

@zadjii-msft - I think I found why key -binding are not working in settings UI

For some reason the KeyDownHandler of terminal page is bound to PreviewKeyDown of CommandPaletter rather than KeyDown of the terminal page. Fixing this, fixed the SUI binding as well.

Please assign to me 😊

@Don-Vito commented on GitHub (Feb 5, 2021): @LuanVSO - this is absolutely a regression. @zadjii-msft - I think I found why key -binding are not working in settings UI For some reason the KeyDownHandler of terminal page is bound to PreviewKeyDown of CommandPaletter rather than KeyDown of the terminal page. Fixing this, fixed the SUI binding as well. Please assign to me :blush:
claunia commented 2026-01-31 03:15:08 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 5, 2021):

@Don-Vito you're the man. I'll throw you on the Assigned-to line, since I had a feeling you had a beat on this one 😄

@zadjii-msft commented on GitHub (Feb 5, 2021): @Don-Vito you're the man. I'll throw you on the Assigned-to line, since I had a feeling you had a beat on this one 😄
claunia commented 2026-01-31 03:15:09 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 5, 2021):

@zadjii-msft - the scope of the issue is wider: copy and paste interact with terminal rather than the search box. I guess it is a good candidate for servicing.

@Don-Vito commented on GitHub (Feb 5, 2021): @zadjii-msft - the scope of the issue is wider: copy and paste interact with terminal rather than the search box. I guess it is a good candidate for servicing.
claunia commented 2026-01-31 03:15:09 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 11, 2021):

:tada:This issue was addressed in #9056, which has now been successfully released as Windows Terminal Preview v1.6.10412.0.🎉

Handy links:

@ghost commented on GitHub (Feb 11, 2021): :tada:This issue was addressed in #9056, which has now been successfully released as `Windows Terminal Preview v1.6.10412.0`.:tada: Handy links: * [Release Notes](https://github.com/microsoft/terminal/releases/tag/v1.6.10412.0) * [Store Download](https://www.microsoft.com/store/apps/9n8g5rfz9xk3?cid=storebadge&ocid=badge)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-CmdPal Issue-Bug Needs-Tag-Fix Needs-Triage Priority-2 Product-Terminal Resolution-Fix-Committed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12414
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?