starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

PowerShell Build Instructions/build module seem incomplete #1246

New Issue
Closed
opened 2026-01-30 22:20:08 +00:00 by claunia · 5 comments
claunia commented 2026-01-30 22:20:08 +00:00
Owner
Copy Link

Originally created by @nlowe on GitHub (May 22, 2019).

I just installed 1903 so I wanted to take another pass at building this again. After getting the latest master (git pull origin master && git submodule update --init --recursive) I tried following the powershell build steps in the README.

I can import ./tools/OpenConsole.psm1 just fine:

C:\Users\Nathan\projects\Terminal [master ≡]
λ  Import-Module .\tools\OpenConsole.psm1 -Verbose
VERBOSE: Importing function 'Debug-OpenConsole'.
VERBOSE: Importing function 'Invoke-OpenConsoleBuild'.
VERBOSE: Importing function 'Invoke-OpenConsoleTests'.
VERBOSE: Importing function 'Set-MsbuildDevEnvironment'.
VERBOSE: Importing function 'Start-OpenConsole'.

However, Set-MsbuildDevEnvironment seems broken or assumes some specific folder structure:

C:\Users\Nathan\projects\Terminal [master ≡]
λ  Set-MsbuildDevEnvironment
pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'.
At C:\Users\Nathan\projects\Terminal\tools\OpenConsole.psm1:11 char:5
+     pushd $path
+     ~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Push-Location], PSArgumentException
    + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCom
   mand

pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'.
At C:\Users\Nathan\projects\Terminal\tools\OpenConsole.psm1:11 char:5
+     pushd $path
+     ~~~~~~~~~~~
    + CategoryInfo          : InvalidArgument: (:) [Push-Location], PSArgumentException
    + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCom
   mand

'vcvarsall.bat' is not recognized as an internal or external command,
operable program or batch file.
Dev environment variables set

However, Invoke-OpenConsoleBuild seems to pass just fine (after forcing the platform to x64). Can these warnings be ignored? Is this a bug with the tool module?

Originally created by @nlowe on GitHub (May 22, 2019). I just installed 1903 so I wanted to take another pass at building this again. After getting the latest `master` (`git pull origin master && git submodule update --init --recursive`) I tried following the powershell build steps in the README. I can import `./tools/OpenConsole.psm1` just fine: ```powershell C:\Users\Nathan\projects\Terminal [master ≡] λ Import-Module .\tools\OpenConsole.psm1 -Verbose VERBOSE: Importing function 'Debug-OpenConsole'. VERBOSE: Importing function 'Invoke-OpenConsoleBuild'. VERBOSE: Importing function 'Invoke-OpenConsoleTests'. VERBOSE: Importing function 'Set-MsbuildDevEnvironment'. VERBOSE: Importing function 'Start-OpenConsole'. ``` However, `Set-MsbuildDevEnvironment` seems broken or assumes some specific folder structure: ```powershell C:\Users\Nathan\projects\Terminal [master ≡] λ Set-MsbuildDevEnvironment pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'. At C:\Users\Nathan\projects\Terminal\tools\OpenConsole.psm1:11 char:5 + pushd $path + ~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Push-Location], PSArgumentException + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCom mand pushd : The path 'C:\..\..' referred to an item that was outside the base 'C:'. At C:\Users\Nathan\projects\Terminal\tools\OpenConsole.psm1:11 char:5 + pushd $path + ~~~~~~~~~~~ + CategoryInfo : InvalidArgument: (:) [Push-Location], PSArgumentException + FullyQualifiedErrorId : System.Management.Automation.PSArgumentException,Microsoft.PowerShell.Commands.PushLocationCom mand 'vcvarsall.bat' is not recognized as an internal or external command, operable program or batch file. Dev environment variables set ``` However, `Invoke-OpenConsoleBuild` seems to pass just fine (after forcing the platform to `x64`). Can these warnings be ignored? Is this a bug with the tool module?
claunia added the Help WantedIssue-DocsProduct-MetaArea-Build labels 2026-01-30 22:20:08 +00:00
claunia commented 2026-01-30 22:20:09 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 22, 2019):

Summoning @adiviness who wrote these

@zadjii-msft commented on GitHub (May 22, 2019): Summoning @adiviness who wrote these
claunia commented 2026-01-30 22:20:10 +00:00
Author
Owner
Copy Link

@adiviness commented on GitHub (May 22, 2019):

Yeah, setting the dev environment in the powershell module is a bit hacky. I have a branch somewhere that improves it by searching more directories but I've been told about a tool that does all that for you. I think it was called vswhere?

@adiviness commented on GitHub (May 22, 2019): Yeah, setting the dev environment in the powershell module is a bit hacky. I have a branch somewhere that improves it by searching more directories but I've been told about a tool that does all that for you. I think it was called vswhere?
claunia commented 2026-01-30 22:20:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 30, 2019):

This is now the meta-issue tracking making OpenConsole.psm1 better. Congrats!

@DHowett-MSFT commented on GitHub (May 30, 2019): This is now the meta-issue tracking making `OpenConsole.psm1` better. Congrats!
claunia commented 2026-01-30 22:20:10 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 30, 2019):

Also: use vswhere. :P

@DHowett-MSFT commented on GitHub (May 30, 2019): Also: use vswhere. :P
claunia commented 2026-01-30 22:20:10 +00:00
Author
Owner
Copy Link

@strega-nil commented on GitHub (May 30, 2019):

It's a pretty easy thing to fix, I'll see if I can do something for it later today.

@strega-nil commented on GitHub (May 30, 2019): It's a pretty easy thing to fix, I'll see if I can do something for it later today.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Build Help Wanted Issue-Docs Product-Meta
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1246
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?