starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Windows-Terminal with vim keeping UTF chars when open/close #12479

New Issue
Closed
opened 2026-01-31 03:16:49 +00:00 by claunia · 6 comments
claunia commented 2026-01-31 03:16:49 +00:00
Owner
Copy Link

Originally created by @iguyking on GitHub (Feb 9, 2021).

Environment

Windows build number: 10.0.19042.0
Windows Terminal version (if applicable):  1.5.210127001-release1.5
Starship:  0.50.0
Powershell Core: 7.1.1

Any other software?

Steps to reproduce

  1. Setup Windows Powershell with a valid Powerline capable font and run the starship.rs prompt where it loads terraform or other special modules showing UTF characters in the prompt.
  2. Launch Windows Terminal with a Powershell Session
  3. change into a directory that triggers this complex UTF character to show up on the prompt
  4. Launch vim, close vim
  5. The previous prompts above no longer show the proper characters and the layout is confused. Example: 💠 character.

Red shows the previous - re-rendered incorrectly after exiting vim
Yellow shows a new line.

image

Expected behavior

When leaving vim I would expect to see the same layout as I left.

Actual behavior

The layout is adjusted oddly after leaving vim that were previously displayed properly.

Originally created by @iguyking on GitHub (Feb 9, 2021). # Environment ```none Windows build number: 10.0.19042.0 Windows Terminal version (if applicable): 1.5.210127001-release1.5 Starship: 0.50.0 Powershell Core: 7.1.1 Any other software? ``` # Steps to reproduce 1. Setup Windows Powershell with a valid Powerline capable font and run the starship.rs prompt where it loads terraform or other special modules showing UTF characters in the prompt. 2. Launch Windows Terminal with a Powershell Session 3. change into a directory that triggers this complex UTF character to show up on the prompt 4. Launch vim, close vim 5. The previous prompts above no longer show the proper characters and the layout is confused. Example: 💠 character. Red shows the previous - re-rendered incorrectly after exiting vim Yellow shows a new line. ![image](https://user-images.githubusercontent.com/5004028/107407930-e7859d00-6acf-11eb-8d9e-d41578412a3e.png) # Expected behavior When leaving vim I would expect to see the same layout as I left. # Actual behavior The layout is adjusted oddly after leaving vim that were previously displayed properly.
claunia commented 2026-01-31 03:16:50 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 9, 2021):

Red: Do you have vim configured to change the side of the terminal/console window using set lines or set columns?

Yellow: yup, sorry, this is just how it works. Vim for Windows takes a full copy of the entire screen and then when it exits, dumps it back out to the screen. In so doing, it corrupts all characters that do not fit in a single UCS-2 code unit. Vim for Windows could have been using an "alternate screen" (which we have supported for 26 years) instead of doing this, but they are not.

@DHowett commented on GitHub (Feb 9, 2021): Red: Do you have vim configured to change the side of the terminal/console window using `set lines` or `set columns`? Yellow: yup, sorry, this is just how it works. Vim for Windows _takes a full copy of the entire screen_ and then when it exits, dumps it back out to the screen. In so doing, it corrupts all characters that do not fit in a single UCS-2 code unit. Vim for Windows could have been using an "alternate screen" (which we have supported for 26 years) instead of doing this, but they are not.
claunia commented 2026-01-31 03:16:50 +00:00
Author
Owner
Copy Link

@iguyking commented on GitHub (Feb 9, 2021):

@DHowett Nope.. The Red is part that shows up AFTER you leave vim. That explains it.

Your answer to Yellow explains that. I have something to bring back to the vim team now in the ticket I have open with them.

@iguyking commented on GitHub (Feb 9, 2021): @DHowett Nope.. The Red is part that shows up AFTER you leave vim. That explains it. Your answer to Yellow explains that. I have something to bring back to the vim team now in the ticket I have open with them.
claunia commented 2026-01-31 03:16:51 +00:00
Author
Owner
Copy Link

@iguyking commented on GitHub (Feb 9, 2021):

This is what it looks like normally when I'm using Windows Terminal.

image

The screen shot in the opening ticket is what it looks like when I exit vim for windows.

@iguyking commented on GitHub (Feb 9, 2021): This is what it looks like normally when I'm using Windows Terminal. ![image](https://user-images.githubusercontent.com/5004028/107434845-eca71400-6af0-11eb-843a-a35c0af77300.png) The screen shot in the opening ticket is what it looks like when I exit vim for windows.
claunia commented 2026-01-31 03:16:51 +00:00
Author
Owner
Copy Link

@k-takata commented on GitHub (Feb 10, 2021):

Vim for Windows could have been using an "alternate screen" (which we have supported for 26 years) instead of doing this, but they are not.

Vim had tried to use CreateConsoleScreenBuffer/SetConsoleActiveScreenBuffer in 7.4.851 and also on Vim6.
But there were some issues with 3rd party terminals:
https://groups.google.com/g/vim_dev/c/ZSklyGjhUAw/m/1_Nqe_fUAAAJ
So, it was reverted.

@k-takata commented on GitHub (Feb 10, 2021): > Vim for Windows could have been using an "alternate screen" (which we have supported for 26 years) instead of doing this, but they are not. Vim had tried to use CreateConsoleScreenBuffer/SetConsoleActiveScreenBuffer in 7.4.851 and also on Vim6. But there were some issues with 3rd party terminals: https://groups.google.com/g/vim_dev/c/ZSklyGjhUAw/m/1_Nqe_fUAAAJ So, it was reverted.
claunia commented 2026-01-31 03:16:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 10, 2021):

@k-takata ah, thanks for the information! I wasn't aware that ConsoleZ didn't handle this correctly.

Versions of Telnet that ship with newer versions of Windows handle this more correctly, as does sshd (the version that comes with windows.) We have much better support for the xterm alternate buffer as well -- perhaps that would be a reasonable thing to use on newer versions of Windows? I'd gladly attempt to implement that myself. 😄

@DHowett commented on GitHub (Feb 10, 2021): @k-takata ah, thanks for the information! I wasn't aware that ConsoleZ didn't handle this correctly. Versions of Telnet that ship with newer versions of Windows handle this more correctly, as does sshd (the version that comes with windows.) We have much better support for the xterm alternate buffer as well -- perhaps that would be a reasonable thing to use on newer versions of Windows? I'd gladly attempt to implement that myself. :smile:
claunia commented 2026-01-31 03:16:51 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 12, 2021):

Closing this one out as external. Sorry all!

@DHowett commented on GitHub (Feb 12, 2021): Closing this one out as external. Sorry all!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Bug Needs-Attention Needs-Tag-Fix Needs-Triage Resolution-External
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12479
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?