starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

TermControl._InitializeTerminal() gives Renderer an uninitialized RenderThread then calls into Renderer. Cleanup needed? #1249

New Issue
Closed
opened 2026-01-30 22:20:11 +00:00 by claunia · 3 comments
claunia commented 2026-01-30 22:20:11 +00:00
Owner
Copy Link

Originally created by @metathinker on GitHub (May 22, 2019).

Not really sure if there's any significance to this or what if any real bugs it's hiding, but AppVerifier is great for finding hidden bugs in my experience, so with apologies I'd suggest this is worth looking into.

Environment and reproduction steps:
Windows 10 ver. 1903 (Version 10.0.18362.116)
WinTerm built from sources @ 6c7dfd2ce4 (master as of May 21, 2019, end of business day)
Application Verifier from Windows SDK for Windows 10 ver. 1903 (SDK 10.0.18362.0)

  1. Build Windows Terminal if needed, using the release build, and deploy it using Visual Studio.
  2. Set up AppVerifier with "Basics" settings for WindowsTerminal.exe
  3. Start Windows Terminal under a debugger.

Results:
Before Windows Terminal fully starts up, observe 2 AppVerifier breaks. Both of these are in code paths wherein TermControl::_InitializeTerminal() calls into Renderer.

From my debugging, it appears that the cause is that TermControl is trying to make calls into Renderer after giving it a RenderThread but before actually initializing that RenderThread. It's not clear to me why TermControl does so much before getting around to initializing the RenderThread, but I'm not familiar with the code as is.

Fuller details here:
https://gist.github.com/metathinker/33d8cf0f191e92176f4f9852927f7e54

Originally created by @metathinker on GitHub (May 22, 2019). Not really sure if there's any significance to this or what if any real bugs it's hiding, but AppVerifier is great for finding hidden bugs in my experience, so with apologies I'd suggest this is worth looking into. **Environment and reproduction steps:** Windows 10 ver. 1903 (`Version 10.0.18362.116`) WinTerm built from sources @ 6c7dfd2ce45841d32f3990147506de2f7903485d (master as of May 21, 2019, end of business day) [Application Verifier](https://docs.microsoft.com/windows-hardware/drivers/debugger/application-verifier) from Windows SDK for Windows 10 ver. 1903 (SDK 10.0.18362.0) 1. Build Windows Terminal if needed, using the release build, and deploy it using Visual Studio. 2. Set up AppVerifier with "Basics" settings for `WindowsTerminal.exe` 3. Start Windows Terminal under a debugger. **Results:** Before Windows Terminal fully starts up, observe 2 AppVerifier breaks. Both of these are in code paths wherein `TermControl::_InitializeTerminal()` calls into `Renderer`. From my debugging, it appears that the cause is that `TermControl` is trying to make calls into `Renderer` after giving it a `RenderThread` but before actually initializing that `RenderThread`. It's not clear to me why `TermControl` does so much before getting around to initializing the `RenderThread`, but I'm not familiar with the code as is. Fuller details here: https://gist.github.com/metathinker/33d8cf0f191e92176f4f9852927f7e54
claunia commented 2026-01-30 22:20:12 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (May 22, 2019):

Huh. I don't see any commentary on why THROW_IF_FAILED(localPointerToThread->Initialize(_renderer.get())); is called so much later, so there probably isn't a reason TBH. That could probably be moved without too much trouble.

@zadjii-msft commented on GitHub (May 22, 2019): Huh. I don't see any commentary on why `THROW_IF_FAILED(localPointerToThread->Initialize(_renderer.get()));` is called so much later, so there probably isn't a reason TBH. That could probably be moved without too much trouble.
claunia commented 2026-01-30 22:20:12 +00:00
Author
Owner
Copy Link

@metathinker commented on GitHub (May 22, 2019):

It seems especially strange to me that the TermControl is giving its Renderer an uninitialized RenderThread anyway - no object should give another object an uninitialized anything. I'd need to study what initialization tasks the RenderThread does to know more.

@metathinker commented on GitHub (May 22, 2019): It seems especially strange to me that the TermControl is giving its Renderer an uninitialized RenderThread anyway - no object should give another object an uninitialized anything. I'd need to study what initialization tasks the RenderThread does to know more.
claunia commented 2026-01-30 22:20:12 +00:00
Author
Owner
Copy Link

@DHowett-MSFT commented on GitHub (May 23, 2019):

I'm marking this triaged as it's a legit bug. Thanks for the report!

@DHowett-MSFT commented on GitHub (May 23, 2019): I'm marking this triaged as it's a legit bug. Thanks for the report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-Rendering Area-TerminalControl Help Wanted Issue-Bug Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#1249
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?