starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add Padding to the backgroundImage suite of configuration settings #12559

New Issue
Closed
opened 2026-01-31 03:18:45 +00:00 by claunia · 2 comments
claunia commented 2026-01-31 03:18:45 +00:00
Owner
Copy Link

Originally created by @JimF42 on GitHub (Feb 13, 2021).

Description of the new feature/enhancement

I use the backgroundImage and backgroundImage... set of configuration settings, but I would also like to see a setting like backgroundImagePadding... (or Margin, or some such).

Yes, this is purely an aesthetic request as the point of the Padding would be to keep the icon off the edges the the screen

Proposed technical implementation details (optional)

I don't have a single implementation in mind, but I can see it going two different ways. A set of four new fields like:

"backgroundImagePaddingLeft" : nnn,
"backgroundImagePaddingTop" : nnn,
"backgroundImagePaddingRight" : nnn,
"backgroundImagePaddingBottom" : nnn

Or, it could be implemented like this

"backgroundImagePadding" : {
    "Left": nnn,
    "Top": nnn,
    "Right": nnn,
    "Bottom": nnn
}

Of course, "backgroundImageAlignment" would take precedent, then the padding would be applied. If all the padding values were to be supplied (Left, Top, Right, Bottom), then at most only 2 values would be used. For example, if the alignment was bottomRight, then the Left and Top values would be ignored.

Honestly, I don't know how padding will be applied if the alignment is Center.

Finally, I also don't know what a good unit would be for the padding values. Perhaps a generic unit like WPF uses by default.

Originally created by @JimF42 on GitHub (Feb 13, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement I use the `backgroundImage` and `backgroundImage..`. set of configuration settings, but I would also like to see a setting like `backgroundImagePadding...` (or Margin, or some such). Yes, this is purely an aesthetic request as the point of the Padding would be to keep the icon off the edges the the screen <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) I don't have a single implementation in mind, but I can see it going two different ways. A set of four new fields like: ``` "backgroundImagePaddingLeft" : nnn, "backgroundImagePaddingTop" : nnn, "backgroundImagePaddingRight" : nnn, "backgroundImagePaddingBottom" : nnn ``` Or, it could be implemented like this ``` "backgroundImagePadding" : { "Left": nnn, "Top": nnn, "Right": nnn, "Bottom": nnn } ``` Of course, "backgroundImageAlignment" would take precedent, then the padding would be applied. If all the padding values were to be supplied (Left, Top, Right, Bottom), then at most only 2 values would be used. For example, if the alignment was bottomRight, then the Left and Top values would be ignored. Honestly, I don't know how padding will be applied if the alignment is Center. Finally, I also don't know what a good unit would be for the padding values. Perhaps a generic unit like WPF uses by default. <!-- A clear and concise description of what you want to happen. -->
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 03:18:45 +00:00
claunia commented 2026-01-31 03:18:46 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 13, 2021):

Thanks for the request. This looks like a /duplicate of #1726 + #2370 (combined)

@DHowett commented on GitHub (Feb 13, 2021): Thanks for the request. This looks like a /duplicate of #1726 + #2370 (combined)
claunia commented 2026-01-31 03:18:46 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 13, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 13, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Issue-Feature Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12559
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?