starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Digging version info out of WindowsTerminal.exe? #12576

New Issue
Closed
opened 2026-01-31 03:19:13 +00:00 by claunia · 4 comments
claunia commented 2026-01-31 03:19:13 +00:00
Owner
Copy Link

Originally created by @vefatica on GitHub (Feb 14, 2021).

Following examples from the online help, I'm using this code.

struct LANGANDCODEPAGE
{
	WORD wLanguage;
	WORD wCodePage;
} *lpTranslate;

WCHAR szFileName[] = L"v:\\wtpreview\\exe\\WindowsTerminal.exe";
DWORD	dwHandle, dwBufSize = GetFileVersionInfoSizeW(szFileName, &dwHandle);
LPVOID Buf = malloc(dwBufSize);
BOOL b = GetFileVersionInfoW(szFileName, 0, dwBufSize, Buf);
wprintf(L"GetFileVersionInfoW returned %s\n", b ? L"TRUE" : L"FALSE");
UINT uDataSize;
b = VerQueryValue(Buf, L"\\VarFileInfo\\Translation", (LPVOID*)&lpTranslate, &uDataSize);
wprintf(L"VerQueryValue returned %s\n", b ? L"TRUE" : L"FALSE");
if ( b == TRUE )
{
	wprintf(L"VerQueryValue gave %u bytes of data\nwLanguage = %04x\nwCodePage = %04x\n", uDataSize, lpTranslate[0].wLanguage, lpTranslate[0].wCodePage);
}

It produces this.

GetFileVersionInfoW returned TRUE
VerQueryValue returned TRUE
VerQueryValue gave 4 bytes of data
wLanguage = 0000
wCodePage = 04b0

That would seem to be wrong because (1) looking at the raw data (in Buf), and (2) looking at the Version resource with devenv, I see the string "040904b0".

The same code successfully gets wLanguage = 0409 out of the few other EXEs that I've tried.

And if I subsequently try to get "ProductVersion" like this

wsprintf(szQuery, L"\\StringFileInfo\\%04x%04x\\ProductVersion", lpTranslate[i].wLanguage, lpTranslate[i].wCodePage);
wprintf(L"Using query string: %s\n", szQuery);
b = VerQueryValueW(Buf, szQuery, &pVoid, &dwQueryDataSize);

It fails (GLE = 1813 (resource can't be found)). It succeeds if I use L"\StringFileInfo\040904b0\ProductVersion" giving me the string "1.6.210210002-release1.6".

Any ideas? Thanks!

Originally created by @vefatica on GitHub (Feb 14, 2021). Following examples from the online help, I'm using this code. ``` struct LANGANDCODEPAGE { WORD wLanguage; WORD wCodePage; } *lpTranslate; WCHAR szFileName[] = L"v:\\wtpreview\\exe\\WindowsTerminal.exe"; DWORD dwHandle, dwBufSize = GetFileVersionInfoSizeW(szFileName, &dwHandle); LPVOID Buf = malloc(dwBufSize); BOOL b = GetFileVersionInfoW(szFileName, 0, dwBufSize, Buf); wprintf(L"GetFileVersionInfoW returned %s\n", b ? L"TRUE" : L"FALSE"); UINT uDataSize; b = VerQueryValue(Buf, L"\\VarFileInfo\\Translation", (LPVOID*)&lpTranslate, &uDataSize); wprintf(L"VerQueryValue returned %s\n", b ? L"TRUE" : L"FALSE"); if ( b == TRUE ) { wprintf(L"VerQueryValue gave %u bytes of data\nwLanguage = %04x\nwCodePage = %04x\n", uDataSize, lpTranslate[0].wLanguage, lpTranslate[0].wCodePage); } ``` It produces this. ``` GetFileVersionInfoW returned TRUE VerQueryValue returned TRUE VerQueryValue gave 4 bytes of data wLanguage = 0000 wCodePage = 04b0 ``` That would seem to be wrong because (1) looking at the raw data (in Buf), and (2) looking at the Version resource with devenv, I see the string "040904b0". The same code successfully gets wLanguage = 0409 out of the few other EXEs that I've tried. And if I subsequently try to get "ProductVersion" like this ``` wsprintf(szQuery, L"\\StringFileInfo\\%04x%04x\\ProductVersion", lpTranslate[i].wLanguage, lpTranslate[i].wCodePage); wprintf(L"Using query string: %s\n", szQuery); b = VerQueryValueW(Buf, szQuery, &pVoid, &dwQueryDataSize); ``` It fails (GLE = 1813 (resource can't be found)). It succeeds if I use L"\\StringFileInfo\\040904b0\\ProductVersion" giving me the string "1.6.210210002-release1.6". Any ideas? Thanks!
claunia added the Needs-TriageNeeds-Tag-Fix labels 2026-01-31 03:19:13 +00:00
claunia commented 2026-01-31 03:19:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 14, 2021):

Check out the code here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L921

There is something in our build system that produces the wrong version locale info, but because this is not an API contract we haven’t cared to fix it.

@DHowett commented on GitHub (Feb 14, 2021): Check out the code here: https://github.com/microsoft/terminal/blob/main/src/cascadia/TerminalSettingsModel/CascadiaSettings.cpp#L921 There is something in our build system that produces the wrong version locale info, but because this is not an API contract we haven’t cared to fix it.
claunia commented 2026-01-31 03:19:14 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Feb 14, 2021):

Thanks. I'll look later. What's an "API contract"?

@vefatica commented on GitHub (Feb 14, 2021): Thanks. I'll look later. What's an "API contract"?
claunia commented 2026-01-31 03:19:14 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 14, 2021):

That is to say, “if we break it or change it we never offered you specific support to begin with.” 😄

@DHowett commented on GitHub (Feb 14, 2021): That is to say, “if we break it or change it we never offered you specific support to begin with.” 😄
claunia commented 2026-01-31 03:19:14 +00:00
Author
Owner
Copy Link

@vefatica commented on GitHub (Feb 15, 2021):

I still don't understand. Let's drop it.

@vefatica commented on GitHub (Feb 15, 2021): I still don't understand. Let's drop it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Needs-Tag-Fix Needs-Triage
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12576
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?