starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-03 21:25:34 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Settings UI removes comments in settings.json #12588

New Issue
Closed
opened 2026-01-31 03:19:37 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:19:37 +00:00
Owner
Copy Link

Originally created by @DennisGaida on GitHub (Feb 15, 2021).

Environment

Windows build number: Microsoft Windows NT 10.0.19042.0
Windows Terminal version: 1.6.10412.0

Steps to reproduce

Open the settings UI settingsUI, make some changes, save

Expected behavior

I would assume that the settings.json is just changed with new values. Whatever is changed is written.

Actual behavior

It seems that the settings are completely rewritten by the settingsUI - meaning my order of things in the json is completely gone and more importantly some comments are gone. I'm playing around with different fonts for example and the section looked like this:

"defaults": 
        {
            //"fontFace": "Cascadia Code",
            "fontFace": "CaskaydiaCove NF"
        },

After saving with the settings UI, the commented out fontFace is gone. The same behavior I observed for colorScheme within the list of profiles. Other comments are still there (e.g. in the keybindings section)

Originally created by @DennisGaida on GitHub (Feb 15, 2021). # Environment ```none Windows build number: Microsoft Windows NT 10.0.19042.0 Windows Terminal version: 1.6.10412.0 ``` # Steps to reproduce Open the settings UI `settingsUI`, make some changes, *save* # Expected behavior I would assume that the `settings.json` is just changed with new values. Whatever is changed is written. # Actual behavior It seems that the settings are completely rewritten by the `settingsUI` - meaning my order of things in the json is completely gone and more importantly *some* comments are gone. I'm playing around with different fonts for example and the section looked like this: ``` "defaults": { //"fontFace": "Cascadia Code", "fontFace": "CaskaydiaCove NF" }, ``` After saving with the settings UI, the commented out `fontFace` is gone. The same behavior I observed for `colorScheme` within the list of profiles. Other comments are still there (e.g. in the `keybindings` section)
claunia added the Resolution-Duplicate label 2026-01-31 03:19:37 +00:00
claunia commented 2026-01-31 03:19:38 +00:00
Author
Owner
Copy Link

@Don-Vito commented on GitHub (Feb 15, 2021):

There is a discussion about similar problems here: https://github.com/microsoft/terminal/issues/8991.
Probably worth adding this issue there as well.

@Don-Vito commented on GitHub (Feb 15, 2021): There is a discussion about similar problems here: https://github.com/microsoft/terminal/issues/8991. Probably worth adding this issue there as well.
claunia commented 2026-01-31 03:19:38 +00:00
Author
Owner
Copy Link

@DennisGaida commented on GitHub (Feb 15, 2021):

Good link, I tried to find a related issue before. My "removing comments" issue isn't addressed in the original issue though.

@DennisGaida commented on GitHub (Feb 15, 2021): Good link, I tried to find a related issue before. My "removing comments" issue isn't addressed in the original issue though.
claunia commented 2026-01-31 03:19:38 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 15, 2021):

/dup #8991 these are all part of the same umbrella of issues -- we don't have good "in-place" editing for the settings file. thanks for bringing this up!

(We re-serialize the entire document, but since the settings UI doesn't support key bindings we just move that part of the serialization tree over from the original... this is why comments remain with bindings but nothing else.)

@DHowett commented on GitHub (Feb 15, 2021): /dup #8991 these are all part of the same umbrella of issues -- we don't have good "in-place" editing for the settings file. thanks for bringing this up! (We re-serialize the entire document, but since the settings UI doesn't support key bindings we just move that part of the serialization tree over from the original... this is why comments remain with bindings but nothing else.)
claunia commented 2026-01-31 03:19:38 +00:00
Author
Owner
Copy Link

@ghost commented on GitHub (Feb 15, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 15, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
claunia commented 2026-01-31 03:19:39 +00:00
Author
Owner
Copy Link

@DennisGaida commented on GitHub (Feb 16, 2021):

@DHowett thanks for the additional information. This is how you close an issue. I'll follow #8991 closely.

@DennisGaida commented on GitHub (Feb 16, 2021): @DHowett thanks for the additional information. This is how you close an issue. I'll follow #8991 closely.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Resolution-Duplicate
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12588
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?