fontWeightBold setting #12609

Closed
opened 2026-01-31 03:20:13 +00:00 by claunia · 3 comments
Owner

Originally created by @trajano on GitHub (Feb 15, 2021).

Description of the new feature/enhancement

When https://github.com/microsoft/terminal/issues/109 gets implemented, we should also add a setting

"fontWeightBold": "bold",

Proposed technical implementation details (optional)

The default may be bold but allow users to change.

Originally created by @trajano on GitHub (Feb 15, 2021). <!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> # Description of the new feature/enhancement When https://github.com/microsoft/terminal/issues/109 gets implemented, we should also add a setting ``` "fontWeightBold": "bold", ``` <!-- A clear and concise description of what the problem is that the new feature would solve. Describe why and how a user would use this new functionality (if applicable). --> # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. --> The default may be `bold` but allow users to change.
claunia added the Issue-FeatureResolution-Duplicate labels 2026-01-31 03:20:13 +00:00
Author
Owner

@DHowett commented on GitHub (Feb 15, 2021):

We're going to tackle this with /dup #1790

@DHowett commented on GitHub (Feb 15, 2021): We're going to tackle this with /dup #1790
Author
Owner

@ghost commented on GitHub (Feb 15, 2021):

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@ghost commented on GitHub (Feb 15, 2021): Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!
Author
Owner

@DHowett commented on GitHub (Feb 15, 2021):

I am resistant to adding a bunch of fontxxxBold, because when we have support for more font things (right now size, weight, face, stylisticSets, variantAxes, etc etc etc) we'll have to multiply that out by the number of styles we support (bold, italic, maybe even underline or applicationStyle53 (SGRs for selecting fonts do exist ...)) and end up with a combinatorial explosion of options.

I'd rather, before we add more individual font options, come to an agreement on how we should represent a single font with all its configuration fields. Then we can stamp out a bunch of those, one per style.

@DHowett commented on GitHub (Feb 15, 2021): I am resistant to adding a bunch of `fontxxxBold`, because when we have support for more font things (right now `size`, `weight`, `face`, `stylisticSets`, `variantAxes`, etc etc etc) we'll have to multiply that out by the number of styles we support (`bold`, `italic`, maybe even `underline` or `applicationStyle53` (SGRs for selecting fonts do exist ...)) and end up with a combinatorial explosion of options. I'd rather, before we add more individual font options, come to an agreement on how we should represent a _single font with all its configuration fields_. Then we can stamp out a bunch of those, one per style.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12609