starred/terminal
1
0
Fork 0
mirror of https://github.com/microsoft/terminal.git synced 2026-02-04 05:35:20 +00:00
Code Issues 19.0k Packages Projects Releases 20 Wiki Activity

Add nullable colors to Settings UI #12626

New Issue
Closed
opened 2026-01-31 03:20:35 +00:00 by claunia · 5 comments
claunia commented 2026-01-31 03:20:35 +00:00
Owner
Copy Link

Originally created by @carlos-zamora on GitHub (Feb 16, 2021).

Originally assigned to: @carlos-zamora on GitHub.

Description of the new feature/enhancement

The following settings are missing from the Profile > Appearance page in the Settings UI:

  • tabColor
  • foreground
  • background
  • selectionBackground
  • cursorColor

This is because the color picker has no way to select "I don't have a color".

Proposed technical implementation details (optional)

  • Introduce a new control called "nullable color picker" containing...
    • a color picker
    • a checkbox (or toggle button) to inherit from the color scheme
    • (maybe) a dependency property to bind the color from the settings model to the control
  • use that new control in the Profile > Appearance page under a new "Colors" grouping

A minor design is needed for this. Particularly, we need to think about how this should be represented along with inheritance (SettingContainer). We want to make sure we don't confuse users with "inherit value from color scheme" and "inherit value from base layer", for example.

Originally created by @carlos-zamora on GitHub (Feb 16, 2021). Originally assigned to: @carlos-zamora on GitHub. # Description of the new feature/enhancement The following settings are missing from the Profile > Appearance page in the Settings UI: - `tabColor` - `foreground` - `background` - `selectionBackground` - `cursorColor` This is because the color picker has no way to select "I don't have a color". # Proposed technical implementation details (optional) - [ ] Introduce a new control called "nullable color picker" containing... - a color picker - a checkbox (or toggle button) to inherit from the color scheme - (maybe) a dependency property to bind the color from the settings model to the control - [ ] use that new control in the Profile > Appearance page under a new "Colors" grouping A minor design is needed for this. Particularly, we need to think about how this should be represented along with inheritance (`SettingContainer`). We want to make sure we don't confuse users with "inherit value from color scheme" and "inherit value from base layer", for example.
claunia added the Issue-FeatureNeeds-Tag-FixProduct-TerminalArea-SettingsUI labels 2026-01-31 03:20:35 +00:00
claunia commented 2026-01-31 03:20:36 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Feb 17, 2021):

Can this control also allow for a "Use my system Accent colour"

@mdtauk commented on GitHub (Feb 17, 2021): Can this control also allow for a "Use my system Accent colour"
claunia commented 2026-01-31 03:20:36 +00:00
Author
Owner
Copy Link

@zadjii-msft commented on GitHub (Feb 17, 2021):

@mdtauk Perhaps, though, then we'd need a spec for how we use the system accent color as one of these terminal colors 😉 It'd be fairly trivial to just lookup the current value of the accent color and throw that in the settings. It'd require a pretty big design change to allow the user to say "I want the background to be {accentColor}", and have that color automatically reflect changes to the accent color in the OS.

It's maybe something that could be done in the post-#3327 world easier, but it's definitely something out of scope for now

@zadjii-msft commented on GitHub (Feb 17, 2021): @mdtauk Perhaps, though, then we'd need a spec for how we use the system accent color as one of these terminal colors 😉 It'd be fairly trivial to just lookup the current value of the accent color and throw that in the settings. It'd require a pretty big design change to allow the user to say "I want the background to be `{accentColor}`", and have that color automatically reflect changes to the accent color in the OS. It's maybe something that could be done in the post-#3327 world _easier_, but it's definitely something out of scope for now
claunia commented 2026-01-31 03:20:37 +00:00
Author
Owner
Copy Link

@mdtauk commented on GitHub (Feb 17, 2021):

For anything Xaml, it's just using a theme resource and it updates automatically.

For the terminal, it is more complicated as it requires listening for the event and redrawing the screen

@mdtauk commented on GitHub (Feb 17, 2021): For anything Xaml, it's just using a theme resource and it updates automatically. For the terminal, it is more complicated as it requires listening for the event and redrawing the screen
claunia commented 2026-01-31 03:20:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Feb 17, 2021):

Right. I'd rather not complicate this with that just yet. Incremental progress.

@DHowett commented on GitHub (Feb 17, 2021): Right. I'd rather not complicate _this_ with _that_ just yet. Incremental progress.
claunia commented 2026-01-31 03:20:37 +00:00
Author
Owner
Copy Link

@DHowett commented on GitHub (Jun 10, 2025):

Fixed in #17870

@DHowett commented on GitHub (Jun 10, 2025): Fixed in #17870
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
⛺ Reserved
A11yCO
A11yMAS
A11ySev1
A11ySev2
A11ySev3
A11yTTValidated
A11yUsable
A11yVoiceAccess
A11yWCAG
Area-Accessibility
Area-AtlasEngine
Area-AzureShell
Area-Build
Area-Build
Area-Chat
Area-CmdPal
Area-CodeHealth
Area-Commandline
Area-CookedRead
Area-DefApp
Area-Extensibility
Area-Fonts
Area-GroupPolicy
Area-i18n
Area-Input
Area-Interaction
Area-Interop
Area-Localization
Area-Output
Area-Performance
Area-Portable
Area-Quality
Area-Remoting
Area-Rendering
Area-Schema
Area-Server
Area-Settings
Area-SettingsUI
Area-ShellExtension
Area-ShellExtension
Area-ShellExtension
Area-Suggestions
Area-Suggestions
Area-TerminalConnection
Area-TerminalControl
Area-Theming
Area-UserInterface
Area-VT
Area-Windowing
Area-WPFControl
AutoMerge
Blocking-Ingestion
Culprit-Centennial
Culprit-WinUI
Disability-All
Disability-Blind
Disability-LowVision
Disability-Mobility
External-Blocked-WinUI3
Fixed
Gathering-Data
good first issue
HCL-E+D
HCL-WindowsTerminal
Help Wanted
Impact-Compatibility
Impact-Compliance
Impact-Correctness
Impact-Visual
In-PR
InclusionBacklog
InclusionBacklog-Windows TerminalWin32
InclusionCommitted-202206
Issue-Bug
Issue-Docs
Issue-Feature
Issue-Feature
Issue-Question
Issue-Samples
Issue-Scenario
Issue-Task
Needs-Attention
Needs-Author-Feedback
Needs-Bisect
Needs-Discussion
Needs-Repro
Needs-Tag-Fix
Needs-Tag-Fix
Needs-Triage
No-Recent-Activity
Priority-0
Priority-1
Priority-2
Priority-3
Product-Cmd.exe
Product-Colortool
Product-Colortool
Product-Colortool
Product-Conhost
Product-Conpty
Product-Meta
Product-Powershell
Product-Terminal
Product-WSL
pull-request
Mirrored from GitHub Pull Request
 Resolution-Answered
Resolution-By-Design
Resolution-Duplicate
Resolution-External
Resolution-Fix-Available
Resolution-Fix-Committed
Resolution-No-Repro
Resolution-Won't-Fix
Severity-Blocking
Severity-Crash
Severity-DataLoss
spam
this-will-be-a-breaking-change
Tracking-External
WindowsTerminal_Win32
Work-Item
zAskModeBug
zInbox-Bug
No Label Area-SettingsUI Issue-Feature Needs-Tag-Fix Product-Terminal
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/terminal#12626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?